Re: [openorb-devel] Notification Service Patches

[Lars K. <lak...@t-...>]

Eric Thomas wrote:
> Hi Lars,
>      I tried to post to the openorb-devel list but the message bounced 
> -- is the list still alive?

Yes, my test mail just went through. I also checked that you are still 
subscribed. Not sure what went wrong, maybe just a temporary hickup in 
the sourceforge infrastructure.

Your other - preferred - option is to open bug reports in the issue 
tracker and attach the fixes, that makes things more traceable than 
private emails.

> Below is the message I wanted to post.
>
> ------------------
>
> Hi Lars (or other OpenORB committer),
>      I've contributed OpenORB / Notification-Service patches in the 
> past.  The attached archive contains patch files that address the 
> following bugs in the OpenORB v1.4.0 Notification Service:
>
> 1. There was a memory leak due to a lack of message-tracking cleanup 
> when client connections failed.  The memory leak manifested itself in 
> the growth of the 'm_undeliveredEventsMap' table.  The fix was to make 
> sure that events are always reported as "delivered" when 
> communications failures are trapped.
>
> 2. The service would (on occasion) get into a state where 
> disconnected-client channels were no longer being closed and would 
> build up over time.  The apparent reason was that the channel-reaper 
> thread could get "stuck" while trying to close a channel.  The fix was 
> to add extra threading and timeouts.
>
> 3. Implemented various other minor fixes and improvements (including 
> fix of bug that had made 'NumberCache' non-operational).
>
>      The patches were applied against the version of OpenORB in 
> Sourceforge CVS on 4/1/2008.  See the "info.txt" file in the archive 
> for more details.
>
>      Before these patches, we were seeing occasional Notification 
> Service crashes due to out-of-memory exceptions and build-ups of 
> "stuck" connections.  We've been running a version with all these 
> patches for quite a few months, and have had no crashes.
>
> Best Regards
> --Eric Thomas


Thanks for the patch, much appreciated, and good to see success stories 
as well.

The NumberCache bug is almost embarrassing, can't believe that it went 
unnoticed for so long. I'll try to look into your other patches.

Regards,
Lars