[OpenOCD-commit] Main OpenOCD repository branch, master, updated. v0.12.0-202-g7fa29dc51

[openocd-gerrit <ope...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Main OpenOCD repository".

The branch, master has been updated
       via  7fa29dc5196accb3ea159e6a29fd969640e30421 (commit)
      from  04a11812883fafee8f0fcb4fee64832716fd43ca (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 7fa29dc5196accb3ea159e6a29fd969640e30421
Author: Antonio Borneo <bor...@gm...>
Date:   Sat May 6 21:28:51 2023 +0200

    jtag: move declaration outside function
    
    The function jtag_debug_state_machine_() is only used by a static
    inline function and declared inside it as private.
    The static analyser 'sparse' complains that the function is
    defined as global but not cross checked against a prototype in an
    include file.
    
    Move the declaration outside the inline function so it get visible
    by interface.c, which already includes interface.h
    While there, change the argument type from 'unsigned' to 'unsigned
    int' to pass checkpatch check.
    
    Change-Id: Ia5dfb92dc4bc6d52ead4f0cb8c68319c83ff85b0
    Signed-off-by: Antonio Borneo <bor...@gm...>
    Reviewed-on: https://review.openocd.org/c/openocd/+/7672
    Tested-by: jenkins

diff --git a/src/jtag/interface.c b/src/jtag/interface.c
index bc9ff3e35..1230bb1b3 100644
--- a/src/jtag/interface.c
+++ b/src/jtag/interface.c
@@ -372,7 +372,7 @@ tap_state_t tap_state_by_name(const char *name)
 	tap_state_name(a), tap_state_name(b), astr, bstr)
 
 tap_state_t jtag_debug_state_machine_(const void *tms_buf, const void *tdi_buf,
-	unsigned tap_bits, tap_state_t next_state)
+	unsigned int tap_bits, tap_state_t next_state)
 {
 	const uint8_t *tms_buffer;
 	const uint8_t *tdi_buffer;
diff --git a/src/jtag/interface.h b/src/jtag/interface.h
index ccea9b266..50044935b 100644
--- a/src/jtag/interface.h
+++ b/src/jtag/interface.h
@@ -147,6 +147,8 @@ void tap_use_new_tms_table(bool use_new);
 /** @returns True if new TMS table is active; false otherwise. */
 bool tap_uses_new_tms_table(void);
 
+tap_state_t jtag_debug_state_machine_(const void *tms_buf, const void *tdi_buf,
+		unsigned int tap_len, tap_state_t start_tap_state);
 
 /**
  * @brief Prints verbose TAP state transitions for the given TMS/TDI buffers.
@@ -159,10 +161,6 @@ bool tap_uses_new_tms_table(void);
 static inline tap_state_t jtag_debug_state_machine(const void *tms_buf,
 		const void *tdi_buf, unsigned tap_len, tap_state_t start_tap_state)
 {
-	/* Private declaration */
-	tap_state_t jtag_debug_state_machine_(const void *tms_buf, const void *tdi_buf,
-			unsigned tap_len, tap_state_t start_tap_state);
-
 	if (LOG_LEVEL_IS(LOG_LVL_DEBUG_IO))
 		return jtag_debug_state_machine_(tms_buf, tdi_buf, tap_len, start_tap_state);
 	else

-----------------------------------------------------------------------

Summary of changes:
 src/jtag/interface.c | 2 +-
 src/jtag/interface.h | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Main OpenOCD repository