From: Alex S. <ml...@os...> - 2008-11-22 07:31:42
|
Hi I updated OpenOBEX in FreeBSD port collection (http://www.freshports.org/comms/openobex/) and while updating found 2 minor bugs. First one is just incomplete define set for freebsd, patch is diff -ur lib/bluez_compat.h work.2/openobex-1.4/lib/bluez_compat.h --- lib/bluez_compat.h 2008-11-07 14:36:09.000000000 +0200 +++ lib/bluez_compat.h 2008-11-19 02:34:53.000000000 +0200 @@ -53,6 +53,8 @@ #define rc_family rfcomm_family #define rc_bdaddr rfcomm_bdaddr #define rc_channel rfcomm_channel +#define BDADDR_ANY NG_HCI_BDADDR_ANY +#define BTPROTO_RFCOMM BLUETOOTH_PROTO_RFCOMM #elif defined(HAVE_BLUETOOTH_NETBSD) #include <bluetooth.h> without it compilation will fail. And another diff is a bit more complicated. While trying to compile with libusb to enable usb obex with my mobile (nokia 3500C) I found that usb is not working in FreeBSD-openobex. I am not guru in libusb programming, but IMHO usbobex.c is a bit wrong. Why we have 2 usb_open() calls on the same device? it fail on FreeBSD. IMHO it is a wrong way, because i found no references about such usage. After removing most of the code related with second call and so called "control connection" i was able to use my mobile in USB mode. Also i added usb_clear_halt() on disconnect, because without this i was not able to use obex-usb second time without replugging. Currently i have no USB cord to test if if cause regressions on Linux, but i`ll be able to do this soon. http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/comms/openobex/files/patch-usb |
From: Alex S. <sa...@os...> - 2008-11-22 07:31:51
|
Hi I updated OpenOBEX in FreeBSD port collection (http://www.freshports.org/comms/openobex/) and while updating found 2 minor bugs. First one is just incomplete define set for freebsd, patch is diff -ur lib/bluez_compat.h work.2/openobex-1.4/lib/bluez_compat.h --- lib/bluez_compat.h 2008-11-07 14:36:09.000000000 +0200 +++ lib/bluez_compat.h 2008-11-19 02:34:53.000000000 +0200 @@ -53,6 +53,8 @@ #define rc_family rfcomm_family #define rc_bdaddr rfcomm_bdaddr #define rc_channel rfcomm_channel +#define BDADDR_ANY NG_HCI_BDADDR_ANY +#define BTPROTO_RFCOMM BLUETOOTH_PROTO_RFCOMM #elif defined(HAVE_BLUETOOTH_NETBSD) #include <bluetooth.h> without it compilation will fail. And another diff is a bit more complicated. While trying to compile with libusb to enable usb obex with my mobile (nokia 3500C) I found that usb is not working in FreeBSD-openobex. I am not guru in libusb programming, but IMHO usbobex.c is a bit wrong. Why we have 2 usb_open() calls on the same device? it fail on FreeBSD. IMHO it is a wrong way, because i found no references about such usage. After removing most of the code related with second call and so called "control connection" i was able to use my mobile in USB mode. Also i added usb_clear_halt() on disconnect, because without this i was not able to use obex-usb second time without replugging. Currently i have no USB cord to test if if cause regressions on Linux, but i`ll be able to do this soon. http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/comms/openobex/files/patch-usb |
From: Alex S. <ml...@os...> - 2008-11-22 10:33:41
|
Alex Samorukov wrote: I tried to apply my patch in ububntu 8.04 with OpenOBEX 1.4 and it work without problems. So i think it could be applied w/o any defines to source tree. > And another diff is a bit more complicated. While trying to compile with > libusb to enable usb obex with my mobile (nokia 3500C) I found that usb > is not working in FreeBSD-openobex. I am not guru in libusb programming, > but IMHO usbobex.c is a bit wrong. Why we have 2 usb_open() calls on the > same device? it fail on FreeBSD. IMHO it is a wrong way, because i found > no references about such usage. After removing most of the code related > with second call and so called "control connection" i was able to use my > mobile in USB mode. Also i added usb_clear_halt() on disconnect, because > without this i was not able to use obex-usb second time without > replugging. Currently i have no USB cord to test if if cause regressions > on Linux, but i`ll be able to do this soon. > > http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/ports/comms/openobex/files/patch-usb > > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's challenge > Build the coolest Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Openobex-users mailing list > Ope...@li... > http://lists.sourceforge.net/lists/listinfo/openobex-users > > |
From: Alex K. <ak...@se...> - 2008-11-22 10:50:11
|
2008/11/22 Alex Samorukov <ml...@os...>: > I tried to apply my patch in ububntu 8.04 with OpenOBEX 1.4 and it work > without problems. So i think it could be applied w/o any defines to > source tree. I'd like to make a few changes to the patch first, will send a better version shortly. -- Alexander |
From: Alex S. <ml...@os...> - 2008-11-22 13:28:21
|
Alex Kanavin wrote: > 2008/11/22 Alex Kanavin <ak...@se...>: > >> 2008/11/22 Alex Samorukov <ml...@os...>: >> >>> I tried to apply my patch in ububntu 8.04 with OpenOBEX 1.4 and it work >>> without problems. So i think it could be applied w/o any defines to >>> source tree. >>> >> I'd like to make a few changes to the patch first, will send a better >> version shortly. >> > > So here's the patch - please test. > work fine with my Nokia. Tested with obexftp from obexapps and syncml-ds-tool from libsyncml project. |
From: Alex K. <ak...@se...> - 2008-11-22 12:40:41
Attachments:
freebsd-usb.patch
|
2008/11/22 Alex Kanavin <ak...@se...>: > 2008/11/22 Alex Samorukov <ml...@os...>: >> I tried to apply my patch in ububntu 8.04 with OpenOBEX 1.4 and it work >> without problems. So i think it could be applied w/o any defines to >> source tree. > > I'd like to make a few changes to the patch first, will send a better > version shortly. So here's the patch - please test. -- Alexander |
From: Alex K. <ak...@se...> - 2008-11-22 14:58:28
|
2008/11/22 Alex Samorukov <ml...@os...>: >>>> I tried to apply my patch in ububntu 8.04 with OpenOBEX 1.4 and it work >>>> without problems. So i think it could be applied w/o any defines to >>>> source tree. >>>> >>> I'd like to make a few changes to the patch first, will send a better >>> version shortly. >>> >> >> So here's the patch - please test. >> > work fine with my Nokia. Tested with obexftp from obexapps and > syncml-ds-tool from libsyncml project. Both in Linux and FreeBSD? -- Alexander |
From: Alex S. <ml...@os...> - 2008-11-22 21:28:34
|
Alex Kanavin wrote: > 2 >> work fine with my Nokia. Tested with obexftp from obexapps and >> syncml-ds-tool from libsyncml project. >> > > Both in Linux and FreeBSD? > For now only in Linux, because i`m out of home and there is only linux around. But as far as I could see you patches is just rewrite of mine, 2nd usb_open() and all related code is dropped, but now not only from usbobex, but also from the corresponding headers. So i think it should work in FreeBSD too. |