From: Marcel H. <ma...@ho...> - 2009-02-08 21:21:25
|
Hi Folks, this release reverts the USB changes that broke the ABI. So please don't use openobex-1.4 and use openobex-1.5 instead. We will be putting the new USB API back in place, but might have to bump the library SO name for that. For now we are trying to avoid that. Additionally this version includes an important fix for the suspend and resume support that was needed when connecting to some Bluetooth phones. And as usual; the code name for this release is "San Francisco" :) The sources can be found at http://www.kernel.org/pub/linux/bluetooth/ Regards Marcel |
From: Hendrik S. <po...@he...> - 2009-02-08 21:55:23
|
Am Sonntag 08 Februar 2009 22:21:21 schrieb Marcel Holtmann: > this release reverts the USB changes that broke the ABI. So please don't > use openobex-1.4 and use openobex-1.5 instead. We will be putting the > new USB API back in place, but might have to bump the library SO name > for that. For now we are trying to avoid that. Great. > Additionally this version includes an important fix for the suspend and > resume support that was needed when connecting to some Bluetooth phones. > > And as usual; the code name for this release is "San Francisco" :) You forgot to change the version number in the CMakeLists.txt file. Updated Windows binaries and Debian packages will be available soon. HS |
From: Hendrik S. <po...@he...> - 2009-02-08 22:46:14
|
Am Sonntag 08 Februar 2009 22:56:03 schrieb Hendrik Sattler: > Am Sonntag 08 Februar 2009 22:21:21 schrieb Marcel Holtmann: > > this release reverts the USB changes that broke the ABI. So please don't > > use openobex-1.4 and use openobex-1.5 instead. We will be putting the > > new USB API back in place, but might have to bump the library SO name > > for that. For now we are trying to avoid that. > > Great. > > > Additionally this version includes an important fix for the suspend and > > resume support that was needed when connecting to some Bluetooth phones. > > > > And as usual; the code name for this release is "San Francisco" :) > > You forgot to change the version number in the CMakeLists.txt file. BTW: you can find all my changes to openobex-1.5 at http://gitorious.org/projects/openobex/repos/mainline/logs/updates Only small fixes, including the version number patch. HS |
From: Marcel H. <ma...@ho...> - 2009-02-09 12:43:45
|
Hi Hendrik, > > > this release reverts the USB changes that broke the ABI. So please don't > > > use openobex-1.4 and use openobex-1.5 instead. We will be putting the > > > new USB API back in place, but might have to bump the library SO name > > > for that. For now we are trying to avoid that. > > > > Great. > > > > > Additionally this version includes an important fix for the suspend and > > > resume support that was needed when connecting to some Bluetooth phones. > > > > > > And as usual; the code name for this release is "San Francisco" :) > > > > You forgot to change the version number in the CMakeLists.txt file. > > BTW: you can find all my changes to openobex-1.5 at > http://gitorious.org/projects/openobex/repos/mainline/logs/updates > > Only small fixes, including the version number patch. sorry about the CMakeLists.txt file. I will try to remember it next time. Send me a pull request and I merge your changes. Next step are your authentication patches and then I wanna go release 1.6 as quickly as possible. Can you send your latest version for review? Regards Marcel |
From: Alex K. <ak...@se...> - 2009-02-10 09:03:28
Attachments:
0001-Revert-Revert-Add-support-for-USB-OBEX-service-ide.patch
0002-Revert-Revert-Fix-win32-breakage-from-USB-OBEX-ser.patch
0003-FreeBSD-fixes.patch
0004-Change-USB-interface-discovery-API-to-prevent-ABI-co.patch
0005-Added-support-for-libusb-1.0.patch
0006-Added-USB-vendor-product-ids-bus-device-interface-n.patch
|
2009/2/9 Hendrik Sattler <po...@he...>: > BTW: you can find all my changes to openobex-1.5 at > http://gitorious.org/projects/openobex/repos/mainline/logs/updates > > Only small fixes, including the version number patch. And here are the patches that I've accumulated - the first two revert the revert of USB service descriptor patch that broke the ABI, then there are FreeBSD fixes, and the USB API change (both previously sent to the list), 0005 adds support for libusb 1.0 (libusb 0.x support remains, via ifdefs), and 0006 adds USB vendor/product ids and bus/device/interface numbers to USB OBEX interface API. -- Alexander |
From: Hendrik S. <po...@he...> - 2009-02-10 10:08:45
|
Alex Kanavin schrieb: > And here are the patches that I've accumulated - the first two revert > the revert of USB service descriptor patch that broke the ABI, then > there are FreeBSD fixes, and the USB API change (both previously sent > to the list), 0005 adds support for libusb 1.0 (libusb 0.x support > remains, via ifdefs), and 0006 adds USB vendor/product ids and > bus/device/interface numbers to USB OBEX interface API. Please merge path 0001 and 0002. This patch should then also update the API version at least for libtool. I'll handle the cmake updates if you don't do it. Why are you changing from char* to unsigned char* in obex_const.h? If those are strings, they should stay as char*, even when they are UTF-8 (or other 8-bit) strings. If you say they are 8bit binary data, use uint8_t*. Defining also HAVE_USB when you define HAVE_USB1 saves you from changing all those defines. You should assume in the code that the build system will only compile one in, either usb1obex.c or usbobex.c. You should thus also remove teh #ifndef _WIN32 in usb1obex.c. BTW: Is the split in two different files really necessary? I'll look at them more closely, later. HS |
From: Alex K. <ak...@se...> - 2009-02-10 13:28:13
|
2009/2/10 Hendrik Sattler <po...@he...>: >> And here are the patches that I've accumulated - the first two revert >> the revert of USB service descriptor patch that broke the ABI, then >> there are FreeBSD fixes, and the USB API change (both previously sent >> to the list), 0005 adds support for libusb 1.0 (libusb 0.x support >> remains, via ifdefs), and 0006 adds USB vendor/product ids and >> bus/device/interface numbers to USB OBEX interface API. > > Please merge path 0001 and 0002. This patch should then also update the > API version at least for libtool. I'll handle the cmake updates if you > don't do it. Er, I thought that Marcel would do the API version update - anyway, just to be sure, how should it look like? > Why are you changing from char* to unsigned char* in obex_const.h? If > those are strings, they should stay as char*, even when they are UTF-8 > (or other 8-bit) strings. If you say they are 8bit binary data, use > uint8_t*. Just to be consistent with libusb 1.x, which is using unsigned char: http://libusb.sourceforge.net/api-1.0/group__desc.html#gf3f92d0a7465d49a5e61eb3f8689fae4 I can revert to char*, no problem. > Defining also HAVE_USB when you define HAVE_USB1 saves you from changing > all those defines. You should assume in the code that the build system > will only compile one in, either usb1obex.c or usbobex.c. > You should thus also remove teh #ifndef _WIN32 in usb1obex.c. Sure, will fix. > BTW: Is the split in two different files really necessary? Yes, I think so. Libusb 1.x has changed the names of all structs and functions and those are scattered all over usbobex.c I will redo the patches after I get further comments from you. -- Alexander |
From: Alex K. <ak...@se...> - 2009-02-10 20:43:16
|
2009/2/10 Alex Kanavin <ak...@se...>: > Er, I thought that Marcel would do the API version update - anyway, > just to be sure, how should it look like? Nevermind, figured it out (hopefully). Here's the updated patch set for review. -- Alexander |
From: Hendrik S. <po...@he...> - 2009-02-10 23:12:48
|
Am Dienstag 10 Februar 2009 21:43:10 schrieb Alex Kanavin: > 2009/2/10 Alex Kanavin <ak...@se...>: > > Er, I thought that Marcel would do the API version update - anyway, > > just to be sure, how should it look like? > > Nevermind, figured it out (hopefully). Here's the updated patch set for > review. No, 6:0:0 is not the right thing but the -version-info libtool thing is just insane. It sets the soname to libopenobex.so.6 but we want libopenobex.so.2. Sometimes eating GNU stuff can really hurt :-( Maybe Marcels can make some sense out of this, I stopped trying to long ago. HS |
From: Marcel H. <ma...@ho...> - 2009-02-10 15:33:02
|
Hi Alex, > > BTW: you can find all my changes to openobex-1.5 at > > http://gitorious.org/projects/openobex/repos/mainline/logs/updates > > > > Only small fixes, including the version number patch. > > And here are the patches that I've accumulated - the first two revert > the revert of USB service descriptor patch that broke the ABI, then > there are FreeBSD fixes, and the USB API change (both previously sent > to the list), 0005 adds support for libusb 1.0 (libusb 0.x support > remains, via ifdefs), and 0006 adds USB vendor/product ids and > bus/device/interface numbers to USB OBEX interface API. I did revert two USB changes from you already. Which ones are these? And please either have me pull from a GIT repository or send one patch per email. Makes it a lot easier to review and apply cleanly. I wanna make sure that the author information stay the same and not get changed to me. If I have to touch a patch, I don't bother to make sure that the authorship stays correct. Last editor wins ;) Regards Marcel |
From: Hendrik S. <po...@he...> - 2009-02-10 21:26:03
|
Am Dienstag 10 Februar 2009 16:33:01 schrieb Marcel Holtmann: > > > BTW: you can find all my changes to openobex-1.5 at > > > http://gitorious.org/projects/openobex/repos/mainline/logs/updates > > > > > > Only small fixes, including the version number patch. > > > > And here are the patches that I've accumulated - the first two revert > > the revert of USB service descriptor patch that broke the ABI, then > > there are FreeBSD fixes, and the USB API change (both previously sent > > to the list), 0005 adds support for libusb 1.0 (libusb 0.x support > > remains, via ifdefs), and 0006 adds USB vendor/product ids and > > bus/device/interface numbers to USB OBEX interface API. > > I did revert two USB changes from you already. Which ones are these? 0001 and 0002, with the updated patchset 0001 only. > And please either have me pull from a GIT repository or send one patch > per email. Makes it a lot easier to review and apply cleanly. I wanna > make sure that the author information stay the same and not get changed > to me. If I have to touch a patch, I don't bother to make sure that the > authorship stays correct. Last editor wins ;) I pushed them to the 'usb' branch in my repository at gitorious. Not yet reviewed, you can pull that branch from git://gitorious.org/openobex/mainline.git The patches had the proper headers, so git am worked fine, except one Applying Added support for libusb 1.0 .dotest/patch:95: trailing whitespace. PREDEFINED = "LIB_SYMBOL=" "CALLAPI=" "OPENOBEX_SYMBOL(retval)=retval" HAVE_IRDA HAVE_USB HAVE_USB1 HAVE_BLUETOOTH warning: 1 line adds whitespace errors. Maybe Alex can fix that. But that should make review fairly easy for you :) HS |
From: Alex K. <ak...@se...> - 2009-02-11 09:20:27
|
2009/2/10 Hendrik Sattler <po...@he...>: >> And please either have me pull from a GIT repository or send one patch >> per email. Makes it a lot easier to review and apply cleanly. I wanna >> make sure that the author information stay the same and not get changed >> to me. If I have to touch a patch, I don't bother to make sure that the >> authorship stays correct. Last editor wins ;) > > I pushed them to the 'usb' branch in my repository at gitorious. Not yet > reviewed, you can pull that branch from > git://gitorious.org/openobex/mainline.git > The patches had the proper headers, so git am worked fine, except one Strange, I never got the original email from Marcel. Anyway, the patches were made with git-format-patch and indeed should have all the headers, so I don't see why attaching them all to one email is a problem. > Applying Added support for libusb 1.0 > .dotest/patch:95: trailing whitespace. > PREDEFINED = "LIB_SYMBOL=" "CALLAPI=" > "OPENOBEX_SYMBOL(retval)=retval" HAVE_IRDA HAVE_USB HAVE_USB1 HAVE_BLUETOOTH > warning: 1 line adds whitespace errors. > > Maybe Alex can fix that. But that should make review fairly easy for you :) The trailing whitespace is actually ^M, which is what all of the lines in that file end with. I'm just being consistent :) -- Alexander |
From: Hendrik S. <po...@he...> - 2009-02-10 23:13:45
|
Am Dienstag 10 Februar 2009 14:28:07 schrieb Alex Kanavin: > 2009/2/10 Hendrik Sattler <po...@he...>: > >> And here are the patches that I've accumulated - the first two revert > >> the revert of USB service descriptor patch that broke the ABI, then > >> there are FreeBSD fixes, and the USB API change (both previously sent > >> to the list), 0005 adds support for libusb 1.0 (libusb 0.x support > >> remains, via ifdefs), and 0006 adds USB vendor/product ids and > >> bus/device/interface numbers to USB OBEX interface API. In patch 0004 of the new patch set (the one that adds libusb-1.0 support), I get the following ./configure output: checking for USB... yes checking for /usr/local/lib/pkgconfig/libusb.pc... no checking for usb_get_busses in -lusb... yes checking for usb_interrupt_read in -lusb... yes checking for USB1... no no checking for /usr/local/lib/pkgconfig/libusb-1.0.pc... no checking for libusb_get_device_list in -lusb-1.0... no What is the lonly "no" there? HS |
From: Alex K. <ak...@se...> - 2009-02-11 09:22:58
|
2009/2/11 Hendrik Sattler <po...@he...>: > In patch 0004 of the new patch set (the one that adds libusb-1.0 support), I > get the following ./configure output: > checking for USB... yes > checking for /usr/local/lib/pkgconfig/libusb.pc... no > checking for usb_get_busses in -lusb... yes > checking for usb_interrupt_read in -lusb... yes > checking for USB1... no > no > checking for /usr/local/lib/pkgconfig/libusb-1.0.pc... no > checking for libusb_get_device_list in -lusb-1.0... no > > What is the lonly "no" there? If you remove bluez or usb 0.x headers/libs, you'll get lonely no for them as well. I'll send a patch for that. -- Alexander |
From: Christian Z. <Christian@Zuckschwerdt.org> - 2009-02-11 00:19:30
|
Hi, libtool is tricky but has a clear pattern there. Starting with a c:r:a of 5:1:4 set the revision to 0 and increase the current to 6 to account for the ABI change. Since the original API is still supported (compatible changes only) increase the age to 5 (this indicates all prior APIs are supported). See e.g. http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html So it's 6:0:0 if you broke the API, and for ABI changes only it's 6:0:5 actually. Am 10.02.2009 um 23:41 schrieb Hendrik Sattler: > Am Dienstag 10 Februar 2009 21:43:10 schrieb Alex Kanavin: >> 2009/2/10 Alex Kanavin <ak...@se...>: >>> Er, I thought that Marcel would do the API version update - anyway, >>> just to be sure, how should it look like? >> >> Nevermind, figured it out (hopefully). Here's the updated patch set >> for >> review. > > No, 6:0:0 is not the right thing but the -version-info libtool thing > is just > insane. > It sets the soname to libopenobex.so.6 but we want libopenobex.so.2. regards, Christian |
From: Hendrik S. <po...@he...> - 2009-02-11 08:18:50
|
Christian Zuckschwerdt schrieb: > So it's 6:0:0 if you broke the API, and for ABI changes only it's > 6:0:5 actually. That's actually the case! HS |
From: Alex K. <ak...@se...> - 2009-02-11 09:24:19
|
2009/2/11 Christian Zuckschwerdt <Chr...@zu...>: > libtool is tricky but has a clear pattern there. Starting with a c:r:a > of 5:1:4 set the revision to 0 and increase the current to 6 to > account for the ABI change. Since the original API is still supported > (compatible changes only) increase the age to 5 (this indicates all > prior APIs are supported). > See e.g. http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html > > So it's 6:0:0 if you broke the API, and for ABI changes only it's > 6:0:5 actually. Actually, the changes are not compatible (neither binary nor source), so it has to be 6:0:0. Alex |
From: Alex K. <ak...@se...> - 2009-02-11 09:28:15
|
2009/2/11 Christian Zuckschwerdt <Chr...@zu...>: > libtool is tricky but has a clear pattern there. Starting with a c:r:a > of 5:1:4 set the revision to 0 and increase the current to 6 to > account for the ABI change. Since the original API is still supported > (compatible changes only) increase the age to 5 (this indicates all > prior APIs are supported). > See e.g. http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html > > So it's 6:0:0 if you broke the API, and for ABI changes only it's > 6:0:5 actually. It's 6:0:5 for backwards compatible ABI changes, which this one isn't. And another patch replaces the USB API. So, 6:0:0 :) -- Alexander |
From: Hendrik S. <po...@he...> - 2009-02-14 15:53:47
|
Am Sonntag 08 Februar 2009 22:21:21 schrieb Marcel Holtmann: > Hi Folks, > > this release reverts the USB changes that broke the ABI. So please don't > use openobex-1.4 and use openobex-1.5 instead. We will be putting the > new USB API back in place, but might have to bump the library SO name > for that. For now we are trying to avoid that. > > Additionally this version includes an important fix for the suspend and > resume support that was needed when connecting to some Bluetooth phones. > > And as usual; the code name for this release is "San Francisco" :) > > The sources can be found at http://www.kernel.org/pub/linux/bluetooth/ As promised earlier: You can download updated Debian packages from: http://www.hendrik-sattler.de/debian/ They will go into the official Debian repository when the Lenny freeze is over. The Windows binaries (cross-built using mingw32) can be downloaded from: http://www.hendrik-sattler.de/downloads/openobex/ They already include all updates from my git repository that fix some things. @Marcel: you can pull those changes from the "updates" branch at git://gitorious.org/openobex/mainline.git Have fun HS |
From: Marcel H. <ma...@ho...> - 2009-02-14 16:03:06
|
Hi Hendrik, > > this release reverts the USB changes that broke the ABI. So please don't > > use openobex-1.4 and use openobex-1.5 instead. We will be putting the > > new USB API back in place, but might have to bump the library SO name > > for that. For now we are trying to avoid that. > > > > Additionally this version includes an important fix for the suspend and > > resume support that was needed when connecting to some Bluetooth phones. > > > > And as usual; the code name for this release is "San Francisco" :) > > > > The sources can be found at http://www.kernel.org/pub/linux/bluetooth/ > > As promised earlier: > You can download updated Debian packages from: > http://www.hendrik-sattler.de/debian/ > > They will go into the official Debian repository when the Lenny freeze is over. > > The Windows binaries (cross-built using mingw32) can be downloaded from: > http://www.hendrik-sattler.de/downloads/openobex/ > > They already include all updates from my git repository that fix some things. > > @Marcel: you can pull those changes from the "updates" branch at > git://gitorious.org/openobex/mainline.git pulled and pushed back out. Thanks. Regards Marcel |
From: Hendrik S. <po...@he...> - 2009-02-18 23:39:36
|
Am Samstag 14 Februar 2009 17:02:52 schrieb Marcel Holtmann: > Hi Hendrik, > > > > this release reverts the USB changes that broke the ABI. So please > > > don't use openobex-1.4 and use openobex-1.5 instead. We will be putting > > > the new USB API back in place, but might have to bump the library SO > > > name for that. For now we are trying to avoid that. > > > > > > Additionally this version includes an important fix for the suspend and > > > resume support that was needed when connecting to some Bluetooth > > > phones. > > > > > > And as usual; the code name for this release is "San Francisco" :) > > > > > > The sources can be found at http://www.kernel.org/pub/linux/bluetooth/ > > > > As promised earlier: > > You can download updated Debian packages from: > > http://www.hendrik-sattler.de/debian/ > > > > They will go into the official Debian repository when the Lenny freeze is > > over. > > > > The Windows binaries (cross-built using mingw32) can be downloaded from: > > http://www.hendrik-sattler.de/downloads/openobex/ > > > > They already include all updates from my git repository that fix some > > things. > > > > @Marcel: you can pull those changes from the "updates" branch at > > git://gitorious.org/openobex/mainline.git > > pulled and pushed back out. Thanks. Please do again, I took over the FreeBSD patch for bluetooth (two defines were missing). HS |
From: Marcel H. <ma...@ho...> - 2009-02-20 02:48:41
|
Hi Hendrik, > > > > this release reverts the USB changes that broke the ABI. So please > > > > don't use openobex-1.4 and use openobex-1.5 instead. We will be putting > > > > the new USB API back in place, but might have to bump the library SO > > > > name for that. For now we are trying to avoid that. > > > > > > > > Additionally this version includes an important fix for the suspend and > > > > resume support that was needed when connecting to some Bluetooth > > > > phones. > > > > > > > > And as usual; the code name for this release is "San Francisco" :) > > > > > > > > The sources can be found at http://www.kernel.org/pub/linux/bluetooth/ > > > > > > As promised earlier: > > > You can download updated Debian packages from: > > > http://www.hendrik-sattler.de/debian/ > > > > > > They will go into the official Debian repository when the Lenny freeze is > > > over. > > > > > > The Windows binaries (cross-built using mingw32) can be downloaded from: > > > http://www.hendrik-sattler.de/downloads/openobex/ > > > > > > They already include all updates from my git repository that fix some > > > things. > > > > > > @Marcel: you can pull those changes from the "updates" branch at > > > git://gitorious.org/openobex/mainline.git > > > > pulled and pushed back out. Thanks. > > Please do again, I took over the FreeBSD patch for bluetooth (two defines were > missing). pulled and pushed back out. Regards Marcel |
From: Petit E. <sur...@gm...> - 2009-02-22 18:45:06
|
2009/2/8 Hendrik Sattler <po...@he...>: > Am Sonntag 08 Februar 2009 22:21:21 schrieb Marcel Holtmann: >> this release reverts the USB changes that broke the ABI. So please don't >> use openobex-1.4 and use openobex-1.5 instead. We will be putting the >> new USB API back in place, but might have to bump the library SO name >> for that. For now we are trying to avoid that. > > Great. > >> Additionally this version includes an important fix for the suspend and >> resume support that was needed when connecting to some Bluetooth phones. >> >> And as usual; the code name for this release is "San Francisco" :) > > You forgot to change the version number in the CMakeLists.txt file. > > Updated Windows binaries and Debian packages will be available soon. Windows binary are ready ? where ? > > HS > > > ------------------------------------------------------------------------------ > Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) > software. With Adobe AIR, Ajax developers can use existing skills and code to > build responsive, highly engaging applications that combine the power of local > resources and data with the reach of the web. Download the Adobe AIR SDK and > Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com > _______________________________________________ > Openobex-users mailing list > Ope...@li... > http://lists.sourceforge.net/lists/listinfo/openobex-users > -- Cordially. Small Eric Quotations of the days: --------------------------------------------------------------------------- If one day one reproaches you that your work is not a work of professional, say you that: Amateurs built the arch of Noah, and professionals the Titanic. --------------------------------------------------------------------------- Few people are done for independence, it is the privilege of the powerful ones. --------------------------------------------------------------------------- No key was wounded during the drafting of this message. |
From: Hendrik S. <po...@he...> - 2009-02-22 19:01:33
|
Am Sonntag 22 Februar 2009 19:44:55 schrieb Petit Eric: > 2009/2/8 Hendrik Sattler <po...@he...>: > > Am Sonntag 08 Februar 2009 22:21:21 schrieb Marcel Holtmann: > >> this release reverts the USB changes that broke the ABI. So please don't > >> use openobex-1.4 and use openobex-1.5 instead. We will be putting the > >> new USB API back in place, but might have to bump the library SO name > >> for that. For now we are trying to avoid that. > > > > Great. > > > >> Additionally this version includes an important fix for the suspend and > >> resume support that was needed when connecting to some Bluetooth phones. > >> > >> And as usual; the code name for this release is "San Francisco" :) > > > > You forgot to change the version number in the CMakeLists.txt file. > > > > Updated Windows binaries and Debian packages will be available soon. > > Windows binary are ready ? where ? You can find the mingw32 build at http://www.hendrik-sattler.de/downloads/openobex/ Eventually, I will upload binaries for MSVC7/8/9 to the same location. HS |