From: Johan H. <joh...@no...> - 2005-10-12 15:53:26
Attachments:
mtu.patch
|
Hi, Currently OpenObex doesn't allow setting the MTU to greater than 32kB even though the OBEX protocol itself would allow it. I don't think that it should be OpenObex's task to limit the MTU to some arbitrary value. Especially when OBEX is used over high speed connections (e.g. Bluetooth EDR) it might not be such a bad idea to use a high MTU. The attached patch increases the allowed maximum MTU to 64kB - 1 which is also the maximum MTU allowed by the OBEX protocol. Johan |
From: Marcel H. <ma...@ho...> - 2005-10-13 09:43:25
|
Hi Johan, > Currently OpenObex doesn't allow setting the MTU to greater than 32kB > even though the OBEX protocol itself would allow it. I don't think that > it should be OpenObex's task to limit the MTU to some arbitrary value. > Especially when OBEX is used over high speed connections (e.g. Bluetooth > EDR) it might not be such a bad idea to use a high MTU. > > The attached patch increases the allowed maximum MTU to 64kB - 1 which > is also the maximum MTU allowed by the OBEX protocol. I applied the patch to the CVS. Do you have more fixes? Regards Marcel |
From: Johan H. <joh...@no...> - 2005-10-13 11:19:01
|
On Thu, Oct 13, 2005, Marcel Holtmann wrote: > Do you have more fixes? Not currently. Johan |
From: Johan H. <joh...@no...> - 2005-10-29 22:40:47
|
Hi Marcel, > > The attached patch increases the allowed maximum MTU to 64kB - 1 which > > is also the maximum MTU allowed by the OBEX protocol. > > I applied the patch to the CVS. The CVS still shows the old (32k) MTU in obex_const.h. Are you sure that you applied the patch? It seems there's a log entry for obex_object.c revision 1.21 which says "Increase the allowed maximum MTU to 64kB - 1", but the actual change is something completely different. Johan |
From: Marcel H. <ma...@ho...> - 2005-10-29 22:59:39
|
Hi Johan, > > > The attached patch increases the allowed maximum MTU to 64kB - 1 which > > > is also the maximum MTU allowed by the OBEX protocol. > > > > I applied the patch to the CVS. > > The CVS still shows the old (32k) MTU in obex_const.h. Are you sure that > you applied the patch? It seems there's a log entry for obex_object.c > revision 1.21 which says "Increase the allowed maximum MTU to 64kB - 1", > but the actual change is something completely different. lets try again. The patch should now be in the CVS. Regards Marcel |