From: Eduardo P. H. <eha...@ra...> - 2006-01-10 18:34:57
|
Hi, I've noticed that protocol version set by openobex on all connect requests is 1.1 (as OBEX_VERSION is defined). But as far as I know, both the 1.2 and 1.3 specification documents states the protocol version as 1.0. All references I've found for the specifications point to the 1.2 and 1.3 specifications. So, to me it seems that there are no specification documents for the protocol version 1.1. What am I missing? --=20 Eduardo |
From: Marcel H. <ma...@ho...> - 2006-01-13 14:33:38
|
Hi Eduardo, > I've noticed that protocol version set by openobex on all connect requests > is 1.1 (as OBEX_VERSION is defined). But as far as I know, both the 1.2 > and 1.3 specification documents states the protocol version as 1.0. All > references I've found for the specifications point to the 1.2 and 1.3 > specifications. > > So, to me it seems that there are no specification documents for the > protocol version 1.1. What am I missing? please provide a patch for it and I like to get some comments from others on this topic. Regards Marcel |
From: Christian W. Z. <Christian@Zuckschwerdt.org> - 2006-01-13 14:52:00
|
Hi, Eduardo is right. The specs (e.g. IrOBEX sec. 3.3.1.1.) explicitly state that the protocol version is not the specification version. The current protocol version is 1.0 (0x10). Perhaps the different version strings could be set apart better: OBEX_VERSION=x.y.z from configure.in -> OBEX_LIB_VERSION OBEX_VERSION=0x11 from obex_main.h -> OBEX_PROTOCOL_VERSION as well as OPENOBEX_VERSION and OPENOBEX_VERSION_CODE in obex.h If everybody is happy with that, I'll make a patch. cu, Christian Marcel Holtmann wrote: >>I've noticed that protocol version set by openobex on all connect requests >>is 1.1 (as OBEX_VERSION is defined). But as far as I know, both the 1.2 >>and 1.3 specification documents states the protocol version as 1.0. >> >> > >I like to get some comments from others on this topic. > > |
From: Marcel H. <ma...@ho...> - 2006-01-13 14:59:37
|
Hi Christian, > Eduardo is right. The specs (e.g. IrOBEX sec. 3.3.1.1.) explicitly state > that the protocol version is not the specification version. The current > protocol version is 1.0 (0x10). > > Perhaps the different version strings could be set apart better: > OBEX_VERSION=x.y.z from configure.in -> OBEX_LIB_VERSION > OBEX_VERSION=0x11 from obex_main.h -> OBEX_PROTOCOL_VERSION > as well as OPENOBEX_VERSION and OPENOBEX_VERSION_CODE in obex.h > > If everybody is happy with that, I'll make a patch. the OPENOBEX_VERSION_CODE and all other weird stuff will go away and we will use pkg-config for the next release. Please check the CVS, because I fully rearranged most of it now. Regards Marcel |
From: Eduardo P. H. <eha...@ra...> - 2006-01-13 15:50:41
|
On Fri, Jan 13, 2006 at 03:34:21PM +0100, Marcel Holtmann wrote: > Hi Eduardo, >=20 > > I've noticed that protocol version set by openobex on all connect reque= sts > > is 1.1 (as OBEX_VERSION is defined). But as far as I know, both the 1.2 > > and 1.3 specification documents states the protocol version as 1.0. All > > references I've found for the specifications point to the 1.2 and 1.3 > > specifications. > >=20 > > So, to me it seems that there are no specification documents for the > > protocol version 1.1. What am I missing? >=20 > please provide a patch for it and I like to get some comments from > others on this topic. I couldn't write a patch for it because I wrote this message trying to find out what was wrong, exactly. If the version is really supposed to be 1.0, the fix seems to be really simple, as below. If the version was always supposed to be 0x10, I am surprised that this was unnoticed for years. --- openobex/lib/obex_main.h +++ openobex/lib/obex_main.h 2006-01-13 13:45:11.000000000 -0200 @@ -102,7 +102,7 @@ =20 #endif /* _WIN32 */ =20 -#define OBEX_VERSION 0x11 /* Version 1.1 */ +#define OBEX_VERSION 0x10 /* OBEX Protocol Version 1.0 */ =20 // Note that this one is also defined in obex.h typedef void (*obex_event_t)(obex_t *handle, obex_object_t *obj, int mode,= int event, int obex_cmd, int obex_rsp); --=20 Eduardo |
From: Marcel H. <ma...@ho...> - 2006-01-18 14:26:57
|
Hi Eduardo, > If the version is really supposed to be 1.0, the fix seems to be really > simple, as below. If the version was always supposed to be 0x10, I am > surprised that this was unnoticed for years. most protocol implementation doesn't seem to care. However I applied your patch to the CVS and now everything should be fine. Thanks. Regards Marcel |