Re: [opennms-devel] Threshd oddness; code perspective

[Miskell, C. <Cra...@ag...>]

> Hey, great work Craig...  Rewriting the threshd code to operate on =20
> collected values is something that is on the list for 1.8.0-1.
>=20
> I strongly suggest that you contact brozow because we don't want to =20
> duplicate effort and/or invalidate any of the hard work that you are =20
> doing.  As an FYI, the strategy that we have been working on=20
> moves the =20
> persistence of RRD data out of the Collection Services and into =20
> Collectd... i.e. out of SnmpCollector, HttpCollector, and =20
> JmxCollector.  This is similar to what we did with Poller=20
> recently and =20
> moving the RRD persistence out of the Monitors and into the Poller =20
> class.
That's pretty much what I've done; makes for much nicer code too.

> Eventually, all RRD persistence will need to be centralized=20
> so that a =20
> realtime thresholder can operate against any RRD data be it =20
> performance or latency data and not have to re-write each=20
> collector.  =20
That's the effect of my code; I've done the centralised performance
persistence, and am extending that to thresholding.

> Once the data is collected, it really doesn't matter what the source =20
> of that data is and it should be able to support a generic=20
> thresholder =20
> with algorithms that work against all collected data.
Exactly; threshd goes away, thresholding becomes a single Visitor class
that visits a CollectionSet.  Very "patterny" ;-)

> Perhaps it's time we had an OGP call?  It is tremendous help=20
> that you =20
> are working on this and I think that we just need to sync up with =20
> brozow.  Are you working on a feature branch?
I'll be in touch with brozow; I have a branch for this, but haven't
committed anythign yet (got some more testing to do).  Hopefully done by
Wednesday this week (my time). =20

Craig
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Attention: The information contained in this message and/or attachments
from AgResearch Limited is intended only for the persons or entities
to which it is addressed and may contain confidential and/or privileged
material. Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by persons or
entities other than the intended recipients is prohibited by AgResearch
Limited. If you have received this message in error, please notify the
sender immediately.
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D