From: Florian D. <fd...@e8...> - 2006-12-22 22:47:29
Attachments:
pkt-header-end-mark.patch
|
This patch adds a end marker to the kcom_pkt struct so that useless fields are not anymore sent to the network. That way, the kcom_pkt struct can be extended to offer precious fields without cost. --- hpc/kcom.c | 8 +++++--- hpc/kcomd.c | 2 +- include/hpc/kcom.h | 26 +++++++++++++++----------- 3 files changed, 21 insertions(+), 15 deletions(-) |
From: <ta...@sn...> - 2006-12-24 15:43:19
|
On Fri, Dec 22, 2006 at 11:46:36PM +0100, Florian Delizy wrote: > This patch adds a end marker to the kcom_pkt struct so that useless > fields are not anymore sent to the network. That way, the kcom_pkt > struct can be extended to offer precious fields without cost. This is hideous. you better duplicate the structure to what you need and having *explicit* operations to convert from and to, the sent-structure. (also those 2 extras fields has absoluty no cost on a typical network) -- Vincent Hanquez |
From: Florian D. <fd...@e8...> - 2007-01-02 10:54:07
|
Vincent Hanquez wrote: > On Fri, Dec 22, 2006 at 11:46:36PM +0100, Florian Delizy wrote: > >> This patch adds a end marker to the kcom_pkt struct so that useless >> fields are not anymore sent to the network. That way, the kcom_pkt >> struct can be extended to offer precious fields without cost. >> > > This is hideous. you better duplicate the structure to what you need and > having *explicit* operations to convert from and to, the sent-structure. > > (also those 2 extras fields has absoluty no cost on a typical network) > > I don't agree on both points, ... I don't think this is 'hideous' (it's the kernel way ...) and 2 extra fields can have a cost on high communication duty ... Moreover they really *are* useless to send. About the pkt struct split, this is a solution, I'll consider it Cheers Florian Delizy |