Menu ▾ ▴

#39 QueuePopulatorExcel repeating date handling

open
nobody
Backend - Souce (3)
7
2012-09-12
2012-02-14
Ben Allen
No

There was logic added to QueuePopulatorExcel in inject "skipNullDates" that allows the queue populator to deal with nulldate attributes. There are three items that need to be cleaned up in QueuePopulatorExcel and QueuePopulatorExcelWithAssociations:

1. The date parsing code in QueuePopulatorExcelWithAssociations was not updated when a bug was fixed in QueuePopulatorExcel... this date parsing logic needs to be the same in both classes and all have the same injectables
2. QueuePopulatorExcel has comments that say "skipNullDates" defaults to FALSE, but it is misleading as to which one is actually the default and what it does
3. Both QueuePopulatorExcel and QueuePopulatorExcelWithAssociations are hard coded to split on a ";" character when parsing repeating dates... this delimiter character needs to be an injectable

Discussion

  • Ben Allen

    Ben Allen - 2012-09-12
    • priority: 5 --> 7
     

  • Ben Allen

    Ben Allen - 2012-09-12

    A client just noticed that the behaviour of dates in QueuePopulatorExcelWithAssociations is different than in QueuePopulatorExcel. I would recommend we compare these two files to ensure they are exactly the same except for the association stuff.

     
MongoDB Logo MongoDB