[OpenEMed-developer] Re: Your contributions

[Joncheng K. <ck...@sy...>]

David Forslund wrote:

>it might be a good idea if you pass by me the structure that you are going to submit, so I can make sure that it fits it with the overall design (that might not be that clear).
>
I will. I've been thinking about the design and changes needed for a few 
days. Here are some thoughts that I'm considering.

1. Create an interface called "PersistentObservationAccess" (see the 
attached file).
This interface is neutral to specific database schema. It is basically 
the replacement for the retrieveObservations() method in 
QueryAccessImpl. In this way, QueryAccessImpl will be independent from 
any particular database schema. We can configure the actual class 
implementing this interface depending on any specific database 
schema/structure.

2. Create a "remote" package under gov.lanl.COAS and implement 
interfaces related to ObservationRemote such as ObservedSubject, 
ObservationRemoteIterator, etc. in this package. The BrowseAccessImpl 
class will be still under gov.lanl.COAS, but it'll use classes 
implemented in this "remote" package.

Besides, I found that the done() method is not adequately implemented. 
We have to deactivate objects like ObservationDataIterator from their 
POA or they never get removed. Both COAS and PIDS will need to use this 
deactivate code.

Joncheng

>
>Thanks,
>
>Dave
>
>
>
>
>
>  
>