[Openjgraph-development] Re: Patches

[Jesus M. S. Jr. <jm...@ih...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Okay, that patch is now in CVS. However, I did make some 
adjustments. The most important of this is that of ChangeStateEvent. There 
are no longer the various ChangeToXXXStateEvent classes. Instead, you pass as 
a parameter to the ChangeStateEvent's constructor the new state you are 
requesting.

The end result is that, instead of ending up with N state classes and N 
ChangeStateEvent classes, you end up with N state classes and only 1 
ChangeStateEvent class. I know some who have more than a handful of 
states ... and writing a separate ChangeTo[statename]Event class maybe more 
of a hassle in those cases.

Furthermore, GraphPanel now also implements KeyListener, and 
VisualGraphComponent and AbstractVisualGraphComponent now have an additional 
processKeyEvent() methods. However, GraphPanel's 
informTargetVisualGraphComponentofKeyEvent ( ... we should really change the 
name of those 2 methods to something shorter ... ) currently does not call 
the prcessKeyEvent of the VisualGraphComponent, since I have not yet figured 
the best way to retrieve the currently focused VisualGraphComponent within 
GraphPanel, though a suggestion is written in the Javadoc for that method.

You may want to get the latest CVS source to try them out.

BTW, it is probably best for all that future discussions WRT openjgraph 
development be made via the development mailing list. I am guilty too of 
failing to put the message on the mailing list. :(

Regards,

John

On Sat,  6 Oct 2001 16:57, you wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
>
> I thought of this again ... and I think you are right with letting the
> state determine the next possible state. ( i.e.: GraphPanelState's methods
> returning GraphPanelState as well ).
>
> It kind of reminds me what I did developing a delivery and tracking system
> way back. An order can be in any of several "states" ( .e.g: ordered,
> purchased, in transit, delivered, attempted delivery, lost, etc. ) I
> remember well documenting the next possible states for each state. ( e.g.:
> for the state to become "delivered", its current state must be one of "in
> transit", "attempted delivery", etc. )
>
> I'll put your changes in and add the the keyXXX() methods as well to the
> GraphPanelState and GraphPanel classes.
>
> Then we should be ready for 0.9.1 release.
>
> On Fri,  5 Oct 2001 18:37, you wrote:
> > Question: When do you sleep? I see a 5 a.m. at this email. And a 11 pm at
> > the email before.
>
> My last e-mail to you was "Fri, 5 Oct 2001 13:01:57 +1000". I sent it at
> 1:00pm yesterday. I think what you see is 13:00 - 10:00 = 3:00 + 2:00 ( for
> Germany ) = 5:00.
>
> > Regards,
> >
> > Armin
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.4 (GNU/Linux)
> Comment: For info see http://www.gnupg.org
>
> iEYEARECAAYFAju+q1EACgkQAvd5SY4qWYzqLACfVEdn8uC8DHn4Ma7VBxj2TAB9
> QkoAn3ct5MNK9F3hrt+v4GMj2xIlNrDe
> =72Y/
> -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iEYEARECAAYFAjvC1XoACgkQAvd5SY4qWYzMHACfdHX1oSsQvjZl8JyDrYz+22Vf
k8IAmQFfsjHqsZu7qWUpWWFGbHtK7q1w
=FYYW
-----END PGP SIGNATURE-----