Re: [Openipmi-developer] Blade IPMB address in ATCA
Brought to you by:
cminyard
Menu
▾
▴
Re: [Openipmi-developer] Blade IPMB address in ATCA
|
From: Corey M. <mi...@ac...> - 2003-12-16 02:04:27
|
The patch looks good, except that it has no framework to plug into :-). The only nitpick I have is that the ATCA-specific defines should go into their own file. I will use this as a basis for the ATCA work I do. Zheng, Jeff wrote: >Corey, > >Another question is: how about the patch? The patch does not deal with "Sensor Owner ID". It just detect the current IPMB address. > > > >>Thanks >>Jeff Jef...@in... >>BTW, I speak for myself, not for Intel Corp. >> >> > > >-----Original Message----- >From: Corey Minyard [mailto:mi...@ac...] >Sent: Monday, December 15, 2003 9:46 PM >To: Zheng, Jeff >Cc: openipmi-developer >Subject: Re: [Openipmi-developer] Blade IPMB address in ATCA > > >OpenIPMI already has code that will handle a changing IPMB address, all >you have to supply is the function to detect the current IPMB address. >If you need to detect or remove an no-longer-existing IPMB, you need to >call the MC scan code for that address and let OpenIPMI add/remove it by >its normal mechanisms. The code you have below will cause some confusion. > >Also, this is not correct ATCA if the IPMB address is changing all the >time. With ATCA, you have two basic options: > > * One ShMC at IPMB address 0x20 and the other inactive one not on > the IPMB bus. > * Each ShMC at its own unique IPMB address (determined by the > hardware address), and the 0x20 address switches between them. In > this case, the sensors on the ShMC should use the unique IPMB > address for their sensors. I prefer this implementation. > >For individual IPMCs, the IPMB address may not change. So if the sensor >owner is not correct in an SDR because the IPMB address changed, that is >not valid IPMB. I don't know of a good way to handle this situation, it >will be very hard to handle. > >Anything else is wrong and violates the spec, as is leads to difficult >usage (as you are finding out). > >I was thinking about adding a a new framework in that would allow code >to be run right after the conenction to the system to detect general >system types. Are you working on this, too? > >-Corey > >Zheng, Jeff wrote: > > > >>Corey, >> >>OK. Now I moved the code into oem_atca_conn.c. >> >>One issue that I have is about "Sensor Owner ID" of SDR record in blade device SDR repository. Because the IPMB address of blade IPMC is changing, we cannot get correct mc from "Sensor Owner ID" of device SDR record. So following code in get_sensors_from_sdrs does get mc of sensor correctly for ATCA blade: >> >> rv = _ipmi_find_or_create_mc_by_slave_addr(domain, >> sdr.data[0], >> &(s[p]->mc)); >> if (rv) >> goto out_err; >> s[p]->source_mc = source_mc; >> >>One solution can be: >> >>if (sdrs is from device sdr repository) then >> s[p]->mc = source_mc; >>eles >> s[p]->mc = mc from sdr.data[0]; >> >>Is it correct? >> >> >> >> >> >>>Thanks >>>Jeff Jef...@in... >>>BTW, I speak for myself, not for Intel Corp. >>> >>> >>> >>> >>-----Original Message----- >>From: Corey Minyard [mailto:mi...@ac...] >>Sent: Friday, December 12, 2003 9:39 PM >>To: Zheng, Jeff >>Cc: openipmi-developer >>Subject: Re: [Openipmi-developer] Blade IPMB address in ATCA >> >> >>Thanks, Jeff. >> >>This is something I have been meaning to work on (as soon as I got ATCA >>hardware and some time). The code you have done looks good, but there >>are some general issues that need to be tackled first. >> >>Your solution needs some more work because it will break non-ATCA >>hardware (as non-ATCA hardware does not handle this message). There >>needs to be some plug-in that things can use to detect general hardware >>types that comes before the specific vendor check. The ATCA stuff can >>plug into there. Also, I would like to keep OEM-type stuff in separate >>files (IE oem_atca.c). >> >>On a more minor note, I would like the NetFN, cmds, and PICMG >>identifiers that are ATCA-specific to be defines in the ATCA file. >> >>-Corey >> >>Zheng, Jeff wrote: >> >> >> >> >> >>>Corey, >>> >>>On ATCA blade, system interface connects to IPMC whose address is not 0x20. I use Get Address Info of ATCA to get ipmb address so that OpenIPMI can get information from IPMC correctly. >>> >>>Hope it is helpful. >>> >>> >>> >>> >>> >>> >>> >>>>Thanks >>>>Jeff Jef...@in... >>>>BTW, I speak for myself, not for Intel Corp. >>>> >>>> >>>> >>>> >>>> >>>> >>><<atca_ipmb_addr.diff>> >>> >>> >>> >>> >>> >>> >> >> >> >> > > > > >------------------------------------------------------- >This SF.net email is sponsored by: SF.net Giveback Program. >Does SourceForge.net help you be more productive? Does it >help you create better code? SHARE THE LOVE, and help us help >YOU! Click Here: http://sourceforge.net/donate/ >_______________________________________________ >Openipmi-developer mailing list >Ope...@li... >https://lists.sourceforge.net/lists/listinfo/openipmi-developer > > |