Update of /cvsroot/openinteract/OpenInteract2/lib/OpenInteract2
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv28817/OpenInteract2
Modified Files:
Package.pm
Log Message:
OIN-105: check name of all message files in a package in 'check()'; move language extraction code to I18N initialization module
Index: Package.pm
===================================================================
RCS file: /cvsroot/openinteract/OpenInteract2/lib/OpenInteract2/Package.pm,v
retrieving revision 1.43
retrieving revision 1.44
diff -C2 -d -r1.43 -r1.44
*** Package.pm 25 Jan 2005 03:09:16 -0000 1.43
--- Package.pm 25 Jan 2005 04:03:19 -0000 1.44
***************
*** 22,25 ****
--- 22,26 ----
use OpenInteract2::Config::TransferSample;
use OpenInteract2::Exception qw( oi_error );
+ use OpenInteract2::I18N::Initializer;
use OpenInteract2::Repository;
use OpenInteract2::Util;
***************
*** 487,490 ****
--- 488,494 ----
push @status, $self->_check_templates( \@template_files );
+ my $message_files = $self->get_message_files;
+ push @status, $self->_check_message_files( $message_files );
+
chdir( $pwd );
return @status;
***************
*** 1146,1149 ****
--- 1150,1175 ----
}
+ sub _check_message_files {
+ my ( $self, $message_files ) = @_;
+ my @status = ();
+ my $action = 'Check localization filename';
+ foreach my $message_file ( @{ $message_files } ) {
+ my $full_file = $self->find_file( $message_file );
+ $log->is_debug && $log->debug( "Checking message file '$full_file'" );
+ my $lang = OpenInteract2::I18N::Initializer
+ ->is_valid_message_file( $full_file );
+ my $msg = ( $lang )
+ ? "Extracted language '$lang' from '$message_file'"
+ : "File '$message_file' is invalid";
+ push @status, {
+ action => $action,
+ is_ok => ( $lang ) ? 'yes' : 'no',
+ message => $msg,
+ filename => $message_file,
+ };
+ }
+ return @status;
+ }
+
# Ensure that the package config has all necessary fields
|
