From: <an...@io...> - 2006-01-15 17:06:46
|
Chris Winters wrote: > I think it's just because I never thought of it :-) Patches (or > commits) would be great. (I assume you're initializing the map in > OI2::Observer->initialize()?) Just one note: I'd name it > 'observer_map' instead of 'map' in the package.ini just to eliminate > ambiguity. You have even commented it this way so I thought you might have some good reason: "Mapping an observer to an action is exclusively done in C<$WEBSITE_DIR/conf/observer.ini>." One reason I thought up when doing that change was that you can not disable those mappings in any way from the global configuration - you can just add more mappings. Also I noticed that because package.ini requires the package-namespace to be used, you can not define object- or subroutine-based observers - only class observers (I don't need them, but still..). Would it be better to let packages just define their own conf/observer.ini files? (If the need arises, they can then be made overridable by observer-override.ini) Should I do this instead / also? - Antti PS. For what purpose would one need the global observer.ini if you can define observers and mappings in packages? |