Re: [Openinteract-dev] Experiences with OI2 1.99_06

[Chris W. <ch...@cw...>]

* Teemu Arina (te...@io...) [050323 11:00]:
> Actually I don't. Just noticed they are removed (docs not updated!). I used
> them in several places for various reasons in my code and I had to change the
> code to just get that stuff out of url_relative. I think it's cleaner
> now, I think request has nothing to do with actions anyway.

They'll be updated shortly, sorry about that.
 
> url_relative and url_absolute include the GET parameters now. Nice, now I can
> work with the state as I proposed a long time ago. I used those also as something
> like:
> 
> $url = CTX->request->url_relative . '/help';
> 
> If the URL includes GET parameters, that piece of code obviously doesn't work anymore
> as it did previously. Thinking aloud: No problem with that, I can always strip the GET
> parameters when I use it like that so a GETless accessor is not
> really required.

Yeah, if you think it's useful to have a non-param version of the URL
we can add it in there.

> > My mp2 experience is lacking as well.
> 
> This is still important, some distros like Fedora include (I think?)
> only Apache2.

Absolutely. Just a matter of finding time...
 
> Nothing wrong with the parser, it works ok. This null entry just breaks the
> TT stuff you already suggested to fix.


Ok.
 
> That's great. While you are at it, change the OI2 stock .msg file
> parser to read keys that have spaces etc. in them as well.

Yep, good idea.

>... 
> One thing with this. If the requested translation is:
> 
> Hello [_1]!
> 
> If a translation is found, it gets replaced something like:
> 
> Hello John!
> 
> But if the key is returned (no translation found) that [_1] is not replaced.
> I think this is perfectly ok, although we could just add something like this:
> 
> $key =~ s/\[_(\d+)\]/\%$1/g;
> return sprintf( $key, @params );

Good idea.

(Implementation note: will that work? The resulting %1, %2... do not
seem like valid sprintf syntax... Regardless, the intent is clear.)

Chris 

-- 
Chris Winters (http://www.cwinters.com)
Building enterprise-capable snack solutions since 1988