[Openinteract-dev] oi_manage bugfix

[Andrew H. <hur...@ll...>]

So I was developing a new package yesterday, and when I ran 
check_package through oi_manage it didn't seem like anything was 
happening (I run it through a script I wrote).  So I ran it by hand, 
and this is what happened:

ahurst@sdcsi3 document$ oi_manage --package_dir=./ check_package
[oi_manage]: Using (/usr/local/OpenInteract) for 'base_dir'.
[oi_manage]: Using (/usr/local/OpenInteract/sites/ahurst_dev) for 
'website_dir'.
Running check_package...
=========================

Segmentation fault
ahurst@sdcsi3 document$

and I have a perl.core in that directory now.  Anyway, while I was 
trying to debug this, I found a bug in oi_manage.

Line 546 (related to check_package) of oi_manage revision 1.67 looks like:

     if ( $OPT_package_dir and ! $OPT_package_dir ) {

Looks like a -d is missing.  I tested it and that branch is never 
visited. Changed the line to:

    if ( $OPT_package_dir and ! -d $OPT_package_dir ) {

and it works correctly now.

But it still segfaults.  Of course, had I looked online first I would 
have found this:
http://openinteract.sourceforge.net/docs/actions.shtml#how%20can%20i%20ensure%20the%20configuration%20file's%20syntax%20is%20ok

which showed me a syntax error in my action.perl.

So to summarize, one bug found, one non-bug fixed.  No more segfaulting.

-Andrew