[Openinteract-dev] Re: SPOPS 0.72 (and 0.73) broken

[Chris W. <ch...@cw...>]

Ray Zimmerman wrote:
> I'm back after some time off ...

Hope your holidays were excellent.

> First, I'm getting test 37 failing for t/30_dbi.t ...
> 
> not ok 37 - Field update (multiple object) execution
> #     Failed test (t/30_dbi.t at line 260)
> #          got: '2'
> #     expected: '3'
> 
> ... and a bunch of my ESPOPS tests (which work fine with SPOPS-0.70) 
> still break. Let me respond to your previous e-mail on field_update() ...

Hm, that's interesting. I probably should have tried this out on 
another database before releasing...

> As it stands, I think field_update() always returns true, even if no 
> rows were affected.
> 
> So, I still think the "$rv = ( $rv != 0 )" code from 0.70 is what we (or 
> at least I :-) want.

I just ran the tests with SQLite and got errors in that DBI test 
(plus one other) as well. So this will be going back. Oh well, 
confidence borne of ignornace and all that.

> Ah ... whoops ... all_field_types() was an ESPOPS method that calls 
> db_discover_types(), as you suggest, with the various classes/tables 
> that make up an object with inherited fields.
> 
> However, it looks like db_discover_types() is now returning a 
> SPOPS::DBI::TypeInfo object instead of a simple hash ... I never 
> installed SPOPS-0.71 so I missed this change ... lemme go have a look at 
> the docs for this class ...
> 
> ... hey, the docs thank me for pointing out the need for the 
> functionality in this module ... am I forgetting something or are you 
> just starting to put my name in the credits out of habit :-)

Ha! I should start pasting links to the email archives....

> So your example of how to use db_discover_types() is no longer valid, is 
> it?

Nope. I must have pulled that from the wayback machine by accident. 
Your example is correct and has been placed into the docs for 
SPOPS::SQLInterface. Thanks.

Chris

-- 
Chris Winters (ch...@cw...)
Building enterprise-capable snack solutions since 1988.