From:
<a_...@us...> - 2006-09-05 20:16:41
|
Update of /cvsroot/openinteract/OpenInteract2/lib/OpenInteract2 In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv32260 Modified Files: URL.pm Log Message: added "!" in the list of non-escaped url characters according rfc 2396. Is there a reason why the whole escaping is not done using URI::Escape ? Index: URL.pm =================================================================== RCS file: /cvsroot/openinteract/OpenInteract2/lib/OpenInteract2/URL.pm,v retrieving revision 1.32 retrieving revision 1.33 diff -C2 -d -r1.32 -r1.33 *** URL.pm 21 Sep 2005 04:10:09 -0000 1.32 --- URL.pm 5 Sep 2006 20:16:31 -0000 1.33 *************** *** 200,204 **** my ( $to_encode ) = shift; return undef unless defined( $to_encode ); ! $to_encode =~ s/([^a-zA-Z0-9_~\.\-\*\'\(\)\/\s])/uc sprintf("%%%02x",ord($1))/eg; $to_encode =~ s/\s/%20/g; return $to_encode; --- 200,205 ---- my ( $to_encode ) = shift; return undef unless defined( $to_encode ); ! # Why is this not done using URI::Escape ? ! $to_encode =~ s/([^a-zA-Z0-9_~\.\-\*\!\'\(\)\/\s])/uc sprintf("%%%02x",ord($1))/eg; $to_encode =~ s/\s/%20/g; return $to_encode; |