Re: [Openh323gk-developer] has_SRV not allowed by default

[MÉSZÁROS M. <mi...@al...>]

Hello Jan,

I am very thankful for your answers!

Regards,
Misi
> Hi,
>
> sorry, I wrote that from memory, it actually only auto-activated for
> 1.20.x as you can see from the snippet you posted.
>
> I checked the code and it will compile with other OpenH323 versions
> as well and we only need to check for DNS functionality,
> so I've changed it to activate whenever DNS functions are
> available for GnuGk 2.2.8.
>
> Regards,
> Jan
>
>
> MÉSZÁROS Mihály wrote:
>   
>> Hello!
>>
>> You said "1.19.x"
>>
>> If version of openh323 is 1.19.1
>>
>> Then i am missing the #define hasSRV 1
>> This pwlib_compat.h is not adding this option to defines, as you can see 
>> in the included file part.
>> Is there an reason why it is missed out?
>>
>> Thanks,
>> Misi
>>
>> Part from pwlib_compat.h:
>>
>> #if OPENH323_MAJOR == 1
>>     #if OPENH323_MINOR >= 19
>>        #if OPENH323_MINOR == 19
>>            #if OPENH323_BUILD > 0
>>            #define OpenH323Factory 1         // OpenH323 Factory Loader Auth
>>            #endif
>>            #if OPENH323_BUILD > 4
>>                 #define h323pluslib 1        // Indicate H323plus Library
>>                 #ifdef H323_H460
>>                         #define hasH460 1    // H460 support
>>                 #endif
>>                 #define h323v6 1             // Version 6 features
>>            #endif
>>        #else // h323plus v1.20
>>            #define h323pluslib 1             // Indicate H323plus Library
>>            #define OpenH323Factory 1         // OpenH323 Factory Loader 
>> Auth
>>            #define h323v6 1                  // Version 6 features 
>>          #ifdef H323_H460
>>            #define hasH460 1                 // H460 support
>>          #endif
>>              #ifdef P_DNS
>>                #define hasSRV 1              // DNS SRV
>>              #endif
>>        #endif
>>      #endif
>> #endif
>>
>>     
>>> Hi,
>>>
>>> hasSRV will be automatically activated, if you compile with OpenH323 >
>>> 1.19.x or H323Plus. The code relies on functions not available in older
>>> OpenH323 versions.
>>> You can take alook at pwlib_compat.h to see how its activated.
>>>
>>> Regards,
>>> Jan
>>>
>>>
>>> MÉSZÁROS Mihály wrote:
>>>   
>>>       
>>>> Hi!
>>>>
>>>> I saw that HAS_SRV is not allowed by default in gnugk version 2.2.7-3.
>>>> And can't enable easily from configure script, only exporting STDCCFALGS 
>>>> env variable.
>>>> Is there any code stability problem, or any other reason wherfore this 
>>>> define HAS_SRV is disabled by default?
>>>>
>>>> Your answer is highly appreciated,
>>>> Misi
>>>>         
>
>