#153 vidinput_avc plugin uses deprecated libraw1394 interface

[Anonymous]

The pwlib vidinput_avc plugin uses a long-since deprecated libraw1394 interface, raw1394_set_iso_handler() and friends, which are altogether removed in the new libraw1394 v2.0.0, thus breaking the pwlib build if avc support is enabled.

Example compile failure snippet:
...
g++ -DLDAP_DEPRECATED -fPIC -D_REENTRANT -Wall -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -DP_64BIT -fPIC -DPIC -I/data/sources/fedora-cvs/pwlib/devel/pwlib-1.10.10/include \
-lraw1394 -ldv -lrom1394 \
-I. -shared vidinput_avc.cxx -o ../pwlib/device/videoinput/avc_pwplugin.so
vidinput_avc.cxx: In member function 'virtual BOOL PVideoInputDevice_1394AVC::Start()':
vidinput_avc.cxx:170: error: 'raw1394_set_iso_handler' was not declared in this scope
vidinput_avc.cxx: In member function 'virtual BOOL PVideoInputDevice_1394AVC::GetFrameDataNoDelay(BYTE*, PINDEX*)':
vidinput_avc.cxx:376: error: 'raw1394_start_iso_rcv' was not declared in this scope
vidinput_avc.cxx:420: error: 'raw1394_stop_iso_rcv' was not declared in this scope
make[4]: *** [../pwlib/device/videoinput/avc_pwplugin.so] Error 1

[Dennis]

I get much the same with ptlib but with libraw1394-2.0.2;

make[2]: Entering directory `/usr/src/ptlib-2.4.4/plugins/vidinput_avc'
/usr/bin/make DEBUG= P_SHAREDLIB=1 default_target
make[3]: Entering directory `/usr/src/ptlib-2.4.4/plugins/vidinput_avc'
mkdir -p /usr/src/ptlib-2.4.4/lib_linux_x86/device/videoinput
g++ -O2 -march=athlon64 -pipe -DPTRACING=1 -D_REENTRANT -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/SDL -fno-exceptions -Wall -fPIC -DPIC -DNDEBUG -I/usr/src/ptlib-2.4.4/include \
-s -s -L/usr/src/ptlib-2.4.4/lib_linux_x86 -s -L/usr/src/ptlib-2.4.4/lib_linux_x86 -s -L/usr/src/ptlib-2.4.4/lib_linux_x86 -s -L/usr/src/ptlib-2.4.4/lib_linux_x86 \
-I. -shared vidinput_avc.cxx \
-s -s -L/usr/src/ptlib-2.4.4/lib_linux_x86 -s -L/usr/src/ptlib-2.4.4/lib_linux_x86 -s -L/usr/src/ptlib-2.4.4/lib_linux_x86 -s -L/usr/src/ptlib-2.4.4/lib_linux_x86 -lraw1394 -ldv -lrom1394 \
-o /usr/src/ptlib-2.4.4/lib_linux_x86/device/videoinput/avc_pwplugin.so
vidinput_avc.cxx: In member function 'virtual PBoolean PVideoInputDevice_1394AVC::Start()':
vidinput_avc.cxx:166: error: 'raw1394_set_iso_handler' was not declared in this scope
vidinput_avc.cxx: In member function 'virtual PBoolean PVideoInputDevice_1394AVC::GetFrameDataNoDelay(BYTE*, PINDEX*)':
vidinput_avc.cxx:374: error: 'raw1394_start_iso_rcv' was not declared in this scope
vidinput_avc.cxx:418: error: 'raw1394_stop_iso_rcv' was not declared in this scope
make[3]: *** [/usr/src/ptlib-2.4.4/lib_linux_x86/device/videoinput/avc_pwplugin.so] Error 1
make[3]: Leaving directory `/usr/src/ptlib-2.4.4/plugins/vidinput_avc'
make[2]: *** [optshared] Error 2
make[2]: Leaving directory `/usr/src/ptlib-2.4.4/plugins/vidinput_avc'
make[1]: *** [optshared] Error 2
make[1]: Leaving directory `/usr/src/ptlib-2.4.4/plugins'
make: *** [optshared] Error 2