Re: variantconfig bug: If a control name has EOL character, read panel from INI will fail

[Jim K. <ji...@ji...>]

Jean-Pierre and All,

If you have an illegal name, you will get an error; and, if you have a name 
collision, you will get an error.  So the worse case, when attempting to 
rename an illegal name, is that you get a name collision, and you have a 
different error.

-Jim


Jean-Pierre Drolet <jea...@tr...> said:

> That is a known issue. In the first place, NI's Config VIs don't check for 
EOLs in keynames. I assume that NI's response about this would be "Don't use 
non-printable characters in keynames", which is reasonable. If a user creates 
a FP with the goal to save it on INI files, he must be aware that control 
names must follow the rules of keynames for INI files. If we want 
variantconfig to prevent for this issue, we could filter keynames to replace 
any sequence of non-printable characters (control char., whitespace and few 
others like []) with a space. However, this substitution can create duplicate 
keynames so maybe the best is to generate an error for irregular keynames. 
> 
> Jean-Pierre
> 
> 
> 
> 
>   Jim Kring <ji...@ji...> wrote:
>     Hello All,
> 
>     Philippe submitted the bug shown in the attached email. It is a problem
>     with variantconfig that effects control names with EOL characters in 
their
>     names. Philippe suggests a fix by converting EOL characters to a space. 
I
>     think this is a good fix. This will cause the names to appear as a 
single
>     line in the INI file. The only possible problem is that there could be a
>     name collision with a control that has the same name. However, LabVIEW 
also
>     allows controls with the same name so this problem already exists. Hmmm,
>     sounds like we need some error handling... any thoughts? What 
preconditions
>     should we be testing for?
> 
>     - No two controls can have the same names tested after converting all
>     illegal names to legitimate names (like converting EOLs in control 
names to
>     spaces.)
> 
>     Any others?
> 
>     -Jim
> 
> 
>     -----Original Message-----
>     From: SourceForge.net [mailto:no...@so...] 
>     Sent: Thursday, November 13, 2003 5:25 PM
>     To: no...@so...
>     Subject: [ opengtoolkit-Bugs-841864 ] If a control name is on 2 line, 
read
>     panel from INI will fai
> 
> 
>     Bugs item #841864, was opened at 2003-11-13 17:25
>     Message generated for change (Tracker Item Submitted) made by Item 
Submitter
>     You can respond by visiting: 
>     https://sourceforge.net/tracker/?
func=detail&atid=466832&aid=841864&group_id
>     =52435
> 
>     Category: lib_variantconfig
>     Group: LabVIEW 7.0 (All)
>     Status: Open
>     Resolution: None
>     Priority: 5
>     Submitted By: philippe guerit (pjm_design)
>     Assigned to: Jim Kring (jkring)
>     Summary: If a control name is on 2 line, read panel from INI will fai
> 
>     Initial Comment:
>     If a control name is on 2 line such as
>     "my control
>     name"
>     read panel from INI will fail because the controls was
>     saved as two different keys on two different lines
> 
>     Possible Fix: when saving key name, scan string for end
>     of line or line feed or carriage return and replace it
>     by a space.
>     The same thing is required when getting the name of the
>     control from the variant
> 
> 
>     ----------------------------------------------------------------------
> 
>     You can respond by visiting: 
>     https://sourceforge.net/tracker/?
func=detail&atid=466832&aid=841864&group_id
>     =52435
> 
> 
> 
>     -------------------------------------------------------
>     This SF.Net email sponsored by: ApacheCon 2003,
>     16-19 November in Las Vegas. Learn firsthand the latest
>     developments in Apache, PHP, Perl, XML, Java, MySQL,
>     WebDAV, and more! http://www.apachecon.com/
>     _______________________________________________
>     OpenGToolkit-Developers mailing list
>     Ope...@li...
>     https://lists.sourceforge.net/lists/listinfo/opengtoolkit-developers
> 
> 
> ----------------------------------------------------------------------------
--
>   Do you Yahoo!?
>   Protect your identity with Yahoo! Mail AddressGuard
> 



--