#35 SetData function does not unlock data when error in is TRUE

[Jim Kring]

When an error flows into SetData, the object is not being unlocked. This causes problems, because it requires that the developer check for errors outside this function and then explicitly handle unlocking on the error condition. It is recommended that this function operate in the same fashion regardless of the error in condition and merge any internal errors with the upstream error.

[Jim Kring]

Logged In: YES
user_id=288901
Originator: YES

Image of SetData before fix.
File Added: before_fix.png

[Jim Kring]

Image of SetData before fix.

[Jim Kring]

Logged In: YES
user_id=288901
Originator: YES

Image of SetData after fix.
File Added: after_fix.png

[Jim Kring]

Image of SetData after fix.

[Jim Kring]

Logged In: YES
user_id=288901
Originator: YES

A decision was made by me (Jim Kring) and Tomi Maila to unlock the data and set the data with the input data on error in = TRUE. The input error will take priority over any internal errors raised in this function.

[Jim Kring]

Logged In: YES
user_id=288901
Originator: YES

Note: Classes created with the buggy template will have to be upgraded manually.

[Jim Kring]

Logged In: YES
user_id=288901
Originator: YES

Fixed in SVN revision 680
http://opengtoolkit.svn.sourceforge.net/viewvc/opengtoolkit?view=rev&revision=680

[Jim Kring]

Logged In: YES
user_id=288901
Originator: YES

Changing status to pending for review by Tomi.

[Tomi Maila]

Logged In: YES
user_id=1699817
Originator: NO

The same issue applies to derived template ogrsc_active_obj_tmpl

[Jim Kring]

Logged In: YES
user_id=288901
Originator: YES

Thanks, Tomi. I've changed the issue status back to OPEN.

[Jim Kring]

Logged In: YES
user_id=288901
Originator: YES

active_obj_tmpl Fixed in SVN revision 695
http://opengtoolkit.svn.sourceforge.net/viewvc/opengtoolkit?view=rev&revision=695

[Jim Kring]

Logged In: YES
user_id=288901
Originator: YES

Tomi, I've changing status to pending for your review.