Re: [Openfx-developer] Openfx examples in Nuke, problems and fixes

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Yes it would, I'll add in your patch when I get the chance later on today.

b

On 22 Dec 2010, at 12:04, Pau Gargallo wrote:

> That clarifies my doubts, thanks Bruno!
> 
> Does it make sense to update the openfx examples to handle such case
> and avoid the crash?  I understand that they are not meant to be
> complete implementations, but it would be instructive for newbies like
> me ;-)
> 
> pau
> 
> 
> On Wed, Dec 22, 2010 at 11:46 AM, Bruno Nicoletti
> <br...@th...> wrote:
>> What is happening is that Nuke is interrupting all process when you move a slider about. Which means you plugin gets interrupted.
>> 
>> So if a plugin fetches an image and part way through that Nuke interrupts, then the fetch image will fail, because all upstream processing has halted. This is not a bug in Nuke, it is the way Nuke works. If you check the interruption status after a fetch, you will see that you will have been interrupted.
>> 
>> Interruption is not an error state, you plugin has not gone wrong. In which case you should return OK.
>> 
>> b
>> 
>> 
>> On 21 Dec 2010, at 22:10, Pau Gargallo wrote:
>> 
>>> Fabien,
>>> 
>>> thanks for the answer and the pointer to your plug-ins, they will be
>>> very useful.
>>> 
>>> After catching the kOfxStatFailed when fetching the images the
>>> examples work fine. I'll send a patch with the changes I've made.
>>> 
>>> I'm using the last version of Nuke on a 64bits linux, but I've
>>> compulsively tried a bunch of versions from the Foundry's ftp, to see
>>> if the error happened only some of them. As it turned out, it was not
>>> a version problem but an oversight in the example.
>>> 
>>> cheers,
>>> pau
>>> 
>>> 
>>> 
>>> On Tue, Dec 21, 2010 at 5:10 PM,  <fab...@fr...> wrote:
>>>> Hi,
>>>> The default examples are not really great.
>>>> Effectively, nuke often returns an empty image (I don't know why) and you have to return an error. And nuke does the process again, with a good image...
>>>> We have created an open source project for openfx plugins and a library to batch a graph of openfx nodes. The project is still under early development, but you can found a bunch of plugin examples, simple or advanced ones.
>>>> https://github.com/tuttleofx/TuttleOFX/tree/master/plugins/image/process
>>>> There is no documentation, so if you have any question, don't hesitate to ask me.
>>>> To build see INSTALL.scons (the bjam version is no more used and so not up to date).
>>>> 
>>>> Regards,
>>>> Fabien Castan
>>>> 
>>>> PS: which version of nuke are you using ? There is many openfx bug fixes in nuke >= 6.0.
>>>> 
>>>> ----- Mail Original -----
>>>> De: "Pau Gargallo" <pau...@gm...>
>>>> À: ope...@li...
>>>> Envoyé: Mardi 21 Décembre 2010 13h01:37 GMT +01:00 Amsterdam / Berlin / Berne / Rome / Stockholm / Vienne
>>>> Objet: [Openfx-developer] Openfx examples in Nuke, problems and fixes
>>>> 
>>>> Hi all,
>>>> 
>>>> I'm new to OpenFX. I've downloaded the headers and examples, compiled
>>>> them and loaded them into Nuke without problems. The problems arrive
>>>> when I actually use the plug-in examples. They work properly as long
>>>> as you do not move the sliders too much. But as soon as you move a
>>>> slider (any of them) a bit to fast, Nuke crashes.  I've tried multiple
>>>> combinations of Nuke and OpenFX versions both on linux and mac, and
>>>> had always the same crash.
>>>> 
>>>> The problem seems to be that the render method in the examples does
>>>> not check the validity of the source image. The call
>>>> 
>>>>     gEffectHost->clipGetImage(myData->sourceClip, time, NULL, &sourceImg);
>>>> 
>>>> in line 667 of the basic.cpp example, is sporadically returning
>>>> kOfxStatFailed, but the return value is ignored.
>>>> 
>>>> What is the proper way to handle such failure?
>>>> Should the code in the examples be modified to handle this?
>>>> 
>>>> Thanks in advance,
>>>> pau
>>>> 
>>>> ------------------------------------------------------------------------------
>>>> Lotusphere 2011
>>>> Register now for Lotusphere 2011 and learn how
>>>> to connect the dots, take your collaborative environment
>>>> to the next level, and enter the era of Social Business.
>>>> http://p.sf.net/sfu/lotusphere-d2d
>>>> _______________________________________________
>>>> Openfx-developer mailing list
>>>> Ope...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/openfx-developer
>>>> 
>>> 
>>> ------------------------------------------------------------------------------
>>> Forrester recently released a report on the Return on Investment (ROI) of
>>> Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even
>>> within 7 months.  Over 3 million businesses have gone Google with Google Apps:
>>> an online email calendar, and document program that's accessible from your
>>> browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew
>>> _______________________________________________
>>> Openfx-developer mailing list
>>> Ope...@li...
>>> https://lists.sourceforge.net/lists/listinfo/openfx-developer
>> 
>> --
>> Bruno Nicoletti,
>> Chief Technology Officer
>> The Foundry
>> 6th Floor, The Communications Building,
>> 48, Leicester Square,
>> London, WC2H 7LT, UK
>> Skype: brunonicoletti
>> Tel: +44 (0)20 7968 6828 - Fax: +44 (0)20 7930 8906
>> Web: www.thefoundry.co.uk
>> Email: br...@th...
>> 
>> The Foundry Visionmongers Ltd.
>> Registered in England and Wales No: 4642027
>> 
>> 
>> ------------------------------------------------------------------------------
>> Forrester recently released a report on the Return on Investment (ROI) of
>> Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even
>> within 7 months.  Over 3 million businesses have gone Google with Google Apps:
>> an online email calendar, and document program that's accessible from your
>> browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew
>> _______________________________________________
>> Openfx-developer mailing list
>> Ope...@li...
>> https://lists.sourceforge.net/lists/listinfo/openfx-developer
>> 
> 
> ------------------------------------------------------------------------------
> Forrester recently released a report on the Return on Investment (ROI) of
> Google Apps. They found a 300% ROI, 38%-56% cost savings, and break-even
> within 7 months.  Over 3 million businesses have gone Google with Google Apps:
> an online email calendar, and document program that's accessible from your 
> browser. Read the Forrester report: http://p.sf.net/sfu/googleapps-sfnew
> _______________________________________________
> Openfx-developer mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/openfx-developer

--
Bruno Nicoletti, 
Chief Technology Officer
The Foundry
6th Floor, The Communications Building,
48, Leicester Square,
London, WC2H 7LT, UK
Skype: brunonicoletti
Tel: +44 (0)20 7968 6828 - Fax: +44 (0)20 7930 8906 
Web: www.thefoundry.co.uk
Email: br...@th...  

The Foundry Visionmongers Ltd.
Registered in England and Wales No: 4642027