Update of /cvsroot/openfirst/members
In directory sc8-pr-cvs1:/tmp/cvs-serv15602
Modified Files:
profile.php index.php divisions.php
Log Message:
Add isset checking, make sure text is not rendered unreadable by colours which may conflict with a site's chosen background colour, change ISSET to isset, make no photograph image used (so teams can easily switch the image to a silhouette like in the ICQ profiles), update MS-SQL setup script.
Index: profile.php
===================================================================
RCS file: /cvsroot/openfirst/members/profile.php,v
retrieving revision 1.14
retrieving revision 1.15
diff -C2 -d -r1.14 -r1.15
*** profile.php 26 Sep 2003 03:26:42 -0000 1.14
--- profile.php 28 Sep 2003 14:05:42 -0000 1.15
***************
*** 96,100 ****
</tr>
<?php
! if(! ISSET($_GET["orderby"])) { $_GET["orderby"] = "user"; }
if(isset($extra) == true && $extra != "") {
$query = ofirst_dbquery("SELECT * FROM ofirst_members where " . $_GET["orderby"] . " is NOT NULL $extra ORDER BY " . $_GET["orderby"] . ";");
--- 96,100 ----
</tr>
<?php
! if(! isset($_GET["orderby"])) { $_GET["orderby"] = "user"; }
if(isset($extra) == true && $extra != "") {
$query = ofirst_dbquery("SELECT * FROM ofirst_members where " . $_GET["orderby"] . " is NOT NULL $extra ORDER BY " . $_GET["orderby"] . ";");
***************
*** 125,129 ****
echo("<table width='600'><tr><th></th><th width='70%'>Member Information</th></tr><tr><td style='vertical-align: top;'>");
if($q->picturelocation == "") {
! echo("No photograph provided.");
} else {
echo("<img src='$q->picturelocation' alt='$q->firstname $q->lastname' />");
--- 125,129 ----
echo("<table width='600'><tr><th></th><th width='70%'>Member Information</th></tr><tr><td style='vertical-align: top;'>");
if($q->picturelocation == "") {
! echo("<img src='nophoto.png' alt='No photograph provided'>");
} else {
echo("<img src='$q->picturelocation' alt='$q->firstname $q->lastname' />");
Index: index.php
===================================================================
RCS file: /cvsroot/openfirst/members/index.php,v
retrieving revision 1.7
retrieving revision 1.8
diff -C2 -d -r1.7 -r1.8
*** index.php 13 Sep 2003 15:38:25 -0000 1.7
--- index.php 28 Sep 2003 14:05:42 -0000 1.8
***************
*** 43,47 ****
You are logged in as:
<?php
! echo("<font color='green'>$user->user</font> the <font color='green'>$user->membertype</font> of the <font color='green'>$user->division division of team $user->team.</font>");
?>
</p>
--- 43,47 ----
You are logged in as:
<?php
! echo("<strong>$user->user</strong> the <strong>$user->membertype</strong> of the <strong>$user->division</strong> division of team <strong>$user->team.</strong>");
?>
</p>
Index: divisions.php
===================================================================
RCS file: /cvsroot/openfirst/members/divisions.php,v
retrieving revision 1.3
retrieving revision 1.4
diff -C2 -d -r1.3 -r1.4
*** divisions.php 13 Sep 2003 15:38:25 -0000 1.3
--- divisions.php 28 Sep 2003 14:05:42 -0000 1.4
***************
*** 35,39 ****
if(isset($user->division) == true) { $division = $user->division; }
if(isset($_GET["division"]) == true) { $division = $_GET["division"]; }
! if($division != "") {
$div = ofirst_dbfetch_object(ofirst_dbquery("SELECT * FROM ofirst_divisions WHERE division='$division';"));
echo("<h2>$div->division</h2>
--- 35,39 ----
if(isset($user->division) == true) { $division = $user->division; }
if(isset($_GET["division"]) == true) { $division = $_GET["division"]; }
! if(isset($division) == true && $division != "") {
$div = ofirst_dbfetch_object(ofirst_dbquery("SELECT * FROM ofirst_divisions WHERE division='$division';"));
echo("<h2>$div->division</h2>
|