openfirst-cvscommit Mailing List for openFIRST (Page 35)
Brought to you by:
xtimg
Menu
▾
▴
openfirst-cvscommit — Notify subscribers of changes to files in CVS.
You can subscribe to this list here.
| 2003 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(41) |
Jun
(210) |
Jul
(39) |
Aug
(153) |
Sep
(147) |
Oct
(173) |
Nov
(81) |
Dec
(163) |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 2004 |
Jan
(33) |
Feb
(18) |
Mar
|
Apr
(62) |
May
|
Jun
(100) |
Jul
(38) |
Aug
(58) |
Sep
(1) |
Oct
|
Nov
(25) |
Dec
(172) |
| 2005 |
Jan
(31) |
Feb
(12) |
Mar
(67) |
Apr
(92) |
May
(247) |
Jun
(34) |
Jul
(36) |
Aug
(192) |
Sep
(15) |
Oct
(42) |
Nov
(92) |
Dec
(4) |
| 2006 |
Jan
|
Feb
(21) |
Mar
|
Apr
|
May
|
Jun
(53) |
Jul
(7) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
| 2007 |
Jan
|
Feb
|
Mar
(4) |
Apr
(4) |
May
|
Jun
(15) |
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
|
From: <bug...@we...> - 2005-04-02 23:25:58
|
http://bugzilla.openfirst.org/show_bug.cgi?id=166 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|de...@op... |ja...@op... Status|NEW |UNCONFIRMED ------- Additional Comments From ja...@op... 2005-04-02 17:25 ------- Fixing bug. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You reported the bug, or are watching the reporter. |
|
From: <bug...@we...> - 2005-04-02 02:02:32
|
http://bugzilla.openfirst.org/show_bug.cgi?id=165 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED ------- Additional Comments From ja...@op... 2005-04-01 20:02 ------- Fixed in CVS. ------- You are receiving this mail because: ------- You reported the bug, or are watching the reporter. |
|
From: Astronouth7303 <ast...@us...> - 2005-04-02 02:01:51
|
Update of /cvsroot/openfirst/guestbook In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv27094/guestbook Modified Files: signthanks.php Log Message: Now checks for post values and assigns defaults. Fixes Bug #165. Index: signthanks.php =================================================================== RCS file: /cvsroot/openfirst/guestbook/signthanks.php,v retrieving revision 1.14 retrieving revision 1.15 diff -C2 -d -r1.14 -r1.15 *** signthanks.php 12 Apr 2004 22:27:22 -0000 1.14 --- signthanks.php 2 Apr 2005 02:01:41 -0000 1.15 *************** *** 52,61 **** return $password; } ! $deletecode = RandomPassword(16); ! $query = "INSERT INTO ofirst_guestbook VALUES('" . $_POST["guest"] . "', '" . $_POST["email"] . "', '" . $_POST["icq"] . "', '" . $_POST["aim"] . "', '" . $_POST["msn"] . "', '" . $_POST["yim"] . "', '" . $_POST["irc"] . "', '" . $_POST["webpage"] . "', '" . $_POST["location"] . "', '" . $_POST["comment"] . "', '" . date("D M j G:i:s T Y") . "', '$deletecode');"; $result = ofirst_dbquery($query); ! $message = "Someone has posted a message in your guestbook. --- 52,72 ---- return $password; } ! $deletecode = RandomPassword(16); ! ! if (!isset($_POST['guest']) ) $_POST['guest'] = '(anonymous)'; ! if (!isset($_POST['email']) ) $_POST['email'] = ''; ! if (!isset($_POST['icq']) ) $_POST['icq'] = ''; ! if (!isset($_POST['aim']) ) $_POST['aim'] = ''; ! if (!isset($_POST['msn']) ) $_POST['msn'] = ''; ! if (!isset($_POST['yim']) ) $_POST['yim'] = ''; ! if (!isset($_POST['irc']) ) $_POST['irc'] = ''; ! if (!isset($_POST['webpage']) ) $_POST['webpage'] = ''; ! if (!isset($_POST['location']) ) $_POST['location'] = 'somewhere'; ! if (!isset($_POST['comment']) ) $_POST['comment'] = '(none)'; ! $query = "INSERT INTO ofirst_guestbook VALUES('" . $_POST["guest"] . "', '" . $_POST["email"] . "', '" . $_POST["icq"] . "', '" . $_POST["aim"] . "', '" . $_POST["msn"] . "', '" . $_POST["yim"] . "', '" . $_POST["irc"] . "', '" . $_POST["webpage"] . "', '" . $_POST["location"] . "', '" . $_POST["comment"] . "', '" . date("D M j G:i:s T Y") . "', '$deletecode');"; $result = ofirst_dbquery($query); ! $message = "Someone has posted a message in your guestbook. |
|
From: <bug...@we...> - 2005-04-02 01:59:29
|
http://bugzilla.openfirst.org/show_bug.cgi?id=165 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|de...@op... |ja...@op... Status|NEW |UNCONFIRMED ------- Additional Comments From ja...@op... 2005-04-01 19:59 ------- Taking bug ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You reported the bug, or are watching the reporter. |
|
From: <bug...@we...> - 2005-04-02 01:51:03
|
http://bugzilla.openfirst.org/show_bug.cgi?id=160 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED ------- Additional Comments From ja...@op... 2005-04-01 19:50 ------- Fixed in CVS. ------- You are receiving this mail because: ------- You reported the bug, or are watching the reporter. |
|
From: Astronouth7303 <ast...@us...> - 2005-04-02 01:50:38
|
Update of /cvsroot/openfirst/logger In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv20061/logger Modified Files: logger.php Log Message: Checks for valid results. Fixes Bug #160. Index: logger.php =================================================================== RCS file: /cvsroot/openfirst/logger/logger.php,v retrieving revision 1.11 retrieving revision 1.12 diff -C2 -d -r1.11 -r1.12 *** logger.php 15 Apr 2004 01:25:43 -0000 1.11 --- logger.php 2 Apr 2005 01:50:29 -0000 1.12 *************** *** 110,114 **** //Get current value $visits=ofirst_dbfetch_object($query); ! return ($visits->Value); } --- 110,117 ---- //Get current value $visits=ofirst_dbfetch_object($query); ! if (is_object($visits) && method_exists($visits, 'Value')) ! return ($visits->Value); ! else ! return 0; } *************** *** 116,120 **** $query=ofirst_dbquery('SELECT Value FROM ofirst_hitcount WHERE Name="totalpages"'); $visits=ofirst_dbfetch_object($query); ! return ($visits->Value); } --- 119,126 ---- $query=ofirst_dbquery('SELECT Value FROM ofirst_hitcount WHERE Name="totalpages"'); $visits=ofirst_dbfetch_object($query); ! if (is_object($visits) && method_exists($visits, 'Value')) ! return ($visits->Value); ! else ! return 0; } |
|
From: <bug...@we...> - 2005-04-02 01:46:03
|
http://bugzilla.openfirst.org/show_bug.cgi?id=160 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|de...@op... |ja...@op... Status|NEW |UNCONFIRMED ------- Additional Comments From ja...@op... 2005-04-01 19:45 ------- Working on fix ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You reported the bug, or are watching the reporter. |
|
From: Astronouth7303 <ast...@us...> - 2005-03-22 22:23:00
|
Update of /cvsroot/openfirst/base/config In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv21666/config Modified Files: auth.php dbase.php Log Message: Moved user creation code to ofirst_dbcreate() Index: auth.php =================================================================== RCS file: /cvsroot/openfirst/base/config/auth.php,v retrieving revision 1.15 retrieving revision 1.16 diff -C2 -d -r1.15 -r1.16 *** auth.php 24 Dec 2003 03:28:26 -0000 1.15 --- auth.php 22 Mar 2005 22:22:35 -0000 1.16 *************** *** 55,59 **** // Show a login form for the user. ! echo("<br><br><form action='". $_SERVER["PHP_SELF"] . "' method='post'>"); if(isset($_SERVER["HTTP_REFERER"])){ echo("<input name='referer' type='hidden' value='".$_SERVER["HTTP_REFERER"]."'/>"); --- 55,59 ---- // Show a login form for the user. ! echo("<br /><br /><form action='". $_SERVER["PHP_SELF"] . "' method='post'>"); if(isset($_SERVER["HTTP_REFERER"])){ echo("<input name='referer' type='hidden' value='".$_SERVER["HTTP_REFERER"]."'/>"); *************** *** 75,86 **** <tr> <td> </td> ! <td><input type=\"submit\" value=\"Login\">"; if(!isset($GLOBALS["pass_save_disabled"])){ ! echo " <br><input type=checkbox name=savepass id=savepass value=1 checked><label for=savepass>Save Password</label>"; } echo("</td></tr> <tr><td> </td><td><a href=\"".$GLOBALS["basepath"]."/members/forgotten.php\">Forgot Password</a></td></tr> </table> ! </form><br><br>"); return(0); } --- 75,86 ---- <tr> <td> </td> ! <td><input type=\"submit\" value=\"Login\" />"; if(!isset($GLOBALS["pass_save_disabled"])){ ! echo " <br /><input type=checkbox name=savepass id=savepass value=1 checked /><label for=savepass>Save Password</label>"; } echo("</td></tr> <tr><td> </td><td><a href=\"".$GLOBALS["basepath"]."/members/forgotten.php\">Forgot Password</a></td></tr> </table> ! </form><br /><br />"); return(0); } *************** *** 158,162 **** // There was an error, check if it's because they didn't create the // members table. ! if(ofirst_dberrno() == 1146) { echo("<p>Members table does not exist, therefore I am creating it.</p>"); $query = ofirst_dbquery("CREATE TABLE ofirst_members ( --- 158,162 ---- // There was an error, check if it's because they didn't create the // members table. ! /* if(ofirst_dberrno() == 1146) { echo("<p>Members table does not exist, therefore I am creating it.</p>"); $query = ofirst_dbquery("CREATE TABLE ofirst_members ( *************** *** 197,201 **** die(ofirst_dberror()); } ! } } if(isset($user->user)){ --- 197,201 ---- die(ofirst_dberror()); } ! }*/ } if(isset($user->user)){ Index: dbase.php =================================================================== RCS file: /cvsroot/openfirst/base/config/dbase.php,v retrieving revision 1.21 retrieving revision 1.22 diff -C2 -d -r1.21 -r1.22 *** dbase.php 22 Mar 2005 22:08:26 -0000 1.21 --- dbase.php 22 Mar 2005 22:22:35 -0000 1.22 *************** *** 290,293 **** --- 290,329 ---- PRIMARY KEY (`modulename`) )"); + /* copied from auth.php */ + echo("<p>Members table does not exist, therefore I am creating it.</p>"); + $query = ofirst_dbquery("CREATE TABLE ofirst_members ( + UNIQUE(user), + user CHAR(128), + firstname TINYTEXT, + lastname TINYTEXT, + lastseen TINYTEXT, + ip TINYTEXT, + password TEXT, + authcode TEXT, + membertype TINYTEXT, + division TINYTEXT, + year INTEGER, + email TEXT, + icq INTEGER, + aim TINYTEXT, + msn TINYTEXT, + yim TINYTEXT, + description TEXT, + signature TINYTEXT, + dateregistered TINYTEXT, + picturelocation TINYTEXT, + team INTEGER, + skills TEXT + );"); + if(ofirst_dberrno() == 0) { + // Insert a default user 'administrator' and set them to have + // administrative access and some password. + + $query = ofirst_dbquery("INSERT INTO ofirst_members (user, + membertype, password) VALUES('admin', 'administrator', '" . + cryptpassword("openfirst", $encryption) ."');"); + echo("<p>Members table has been created. Please login as <b>admin</b> using the password <b>openfirst</b> to set configuration options.</p>"); + } + /* End copy */ } ?> |
|
From: <bug...@we...> - 2005-03-22 22:10:07
|
http://bugzilla.openfirst.org/show_bug.cgi?id=156 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |FIXED ------- Additional Comments From ja...@op... 2005-03-22 16:10 ------- Fixed in CVS, see dbase.php v1.21. ------- You are receiving this mail because: ------- You reported the bug, or are watching the reporter. |
|
From: <bug...@we...> - 2005-03-22 22:09:09
|
http://bugzilla.openfirst.org/show_bug.cgi?id=156 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|de...@op... |ja...@op... ------- Additional Comments From ja...@op... 2005-03-22 16:08 ------- Accepting bug ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You reported the bug, or are watching the reporter. |
|
From: Astronouth7303 <ast...@us...> - 2005-03-22 22:09:01
|
Update of /cvsroot/openfirst/base/config In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv13070/config Modified Files: dbase.php Log Message: Bug #156: ofirst_dbnum_rows() will return -1 if the argument is not a resource. Index: dbase.php =================================================================== RCS file: /cvsroot/openfirst/base/config/dbase.php,v retrieving revision 1.20 retrieving revision 1.21 diff -C2 -d -r1.20 -r1.21 *** dbase.php 13 Mar 2005 01:46:12 -0000 1.20 --- dbase.php 22 Mar 2005 22:08:26 -0000 1.21 *************** *** 221,224 **** --- 221,225 ---- die("MySQL support is not available in your version of PHP. To use the openFIRST Web Portal Software, please either enable MySQL support, or choose another database type."); } + if (!is_resource($resource)) return -1; return(mysql_num_rows($resource)); } elseif($dbasetype == "mssql") { *************** *** 226,229 **** --- 227,231 ---- die("Microsoft SQL support is not available in your version of PHP. To use the openFIRST Web Portal Software, please either enable Microsoft SQL support, or choose another database type."); } + if (!is_resource($resource)) return -1; return(mssql_num_rows($resource)); } elseif($dbasetype == "odbc") { *************** *** 232,235 **** --- 234,238 ---- } if($resource != "") { + if (!is_resource($resource)) return -1; return(odbc_num_rows($resource)); } else { |
|
From: Astronouth7303 <ast...@us...> - 2005-03-22 21:35:12
|
Update of /cvsroot/openfirst/logger In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv28865/logger Modified Files: index.php Log Message: Small HTML detail Index: index.php =================================================================== RCS file: /cvsroot/openfirst/logger/index.php,v retrieving revision 1.15 retrieving revision 1.16 diff -C2 -d -r1.15 -r1.16 *** index.php 14 Mar 2005 00:51:03 -0000 1.15 --- index.php 22 Mar 2005 21:34:46 -0000 1.16 *************** *** 82,86 **** echo " <td>$log->HostLookup</td>"; echo "<td> ! <a href='./?DELETE=$log->IPAddress'><img border='0' src='$basepath/members/icons/actions/button_cancel.png'></a> <a href='track.php?ID=$log->IPAddress'><img src='$basepath/members/icons/actions/filefind.png' border='0'></a> </td>"; --- 82,86 ---- echo " <td>$log->HostLookup</td>"; echo "<td> ! <a href='./?DELETE=$log->IPAddress'><img border='0' src='$basepath/members/icons/actions/button_cancel.png' /></a> <a href='track.php?ID=$log->IPAddress'><img src='$basepath/members/icons/actions/filefind.png' border='0'></a> </td>"; |
|
From: <bug...@we...> - 2005-03-22 21:34:12
|
http://bugzilla.openfirst.org/show_bug.cgi?id=156 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- Component|logger |base ------- Additional Comments From ja...@op... 2005-03-22 15:34 ------- This is problem of dbase.php, not of logger. It is the responsibility of dbase.php to check the validity of a resource. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You reported the bug, or are watching the reporter. |
|
From: <bug...@we...> - 2005-03-22 21:16:19
|
http://bugzilla.openfirst.org/show_bug.cgi?id=155 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WORKSFORME ------- Additional Comments From ja...@op... 2005-03-22 15:16 ------- Attempting to access the page while not logged in results in no error. Changing it to WORKSFORME ------- You are receiving this mail because: ------- You reported the bug, or are watching the reporter. |
|
From: <bug...@we...> - 2005-03-22 21:12:06
|
http://bugzilla.openfirst.org/show_bug.cgi?id=156 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|WORKSFORME | ------- Additional Comments From ja...@op... 2005-03-22 15:11 ------- ***** auto advance! ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You reported the bug, or are watching the reporter. |
|
From: <bug...@we...> - 2005-03-22 21:11:15
|
http://bugzilla.openfirst.org/show_bug.cgi?id=156 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |WORKSFORME ------- Additional Comments From ja...@op... 2005-03-22 15:10 ------- When I logged out, and tried to go to the URL, it works w/o error, both on my system and on demo. Correct md5 hash on my system. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You reported the bug, or are watching the reporter. |
|
From: <bug...@we...> - 2005-03-22 21:07:29
|
http://bugzilla.openfirst.org/show_bug.cgi?id=155 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|de...@op... |ja...@op... ------- Additional Comments From ja...@op... 2005-03-22 15:07 ------- Accepting bug ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You reported the bug, or are watching the reporter. |
|
From: <bug...@we...> - 2005-03-22 20:52:02
|
http://bugzilla.openfirst.org/show_bug.cgi?id=18 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Additional Comments From ja...@op... 2005-03-22 14:51 ------- Fixed in CVS. Checks performed in downloads/index.php and downloads/admin/upload.php. Checks are only done if user is admin. ------- You are receiving this mail because: ------- You reported the bug, or are watching the reporter. |
|
From: <bug...@we...> - 2005-03-22 20:50:59
|
http://bugzilla.openfirst.org/show_bug.cgi?id=155 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | ------- Additional Comments From ja...@op... 2005-03-22 14:50 ------- Err, wrong bug. (Darned auto advance!) ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You reported the bug, or are watching the reporter. |
|
From: <bug...@we...> - 2005-03-22 20:49:48
|
http://bugzilla.openfirst.org/show_bug.cgi?id=155 ja...@op... changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED ------- Additional Comments From ja...@op... 2005-03-22 14:49 ------- Fixed in CVS. Checks performed in downloads/index.php and downloads/admin/upload.php. This check is only performed if the user is an admin. ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. You reported the bug, or are watching the reporter. |
|
From: Astronouth7303 <ast...@us...> - 2005-03-22 20:47:26
|
Update of /cvsroot/openfirst/downloads In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv7629/downloads Modified Files: readme.txt Log Message: Updating Index: readme.txt =================================================================== RCS file: /cvsroot/openfirst/downloads/readme.txt,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -d -r1.1 -r1.2 *** readme.txt 22 Mar 2005 20:44:38 -0000 1.1 --- readme.txt 22 Mar 2005 20:46:55 -0000 1.2 *************** *** 4,14 **** =================================== ! This directory is the default location for uploaded files. To change it, edit admin/upload.php: ! Line 34: $uploaddir=$fbasepath."/downloads/files/"; This is the absolute path to the folder for uploaded files. Line 35: $serverdir="files/"; This path is relative to getfile.php, and will be written to the database on upload. The script must have write permissions for the upload directory. It is also a good idea to disallow execution of scripts in the directory. --- 4,19 ---- =================================== ! The "files" directory is the default location for uploaded files. To change it, edit admin/upload.php: ! Line 34: $uploaddir="$fbasepath/downloads/files/"; This is the absolute path to the folder for uploaded files. Line 35: $serverdir="files/"; This path is relative to getfile.php, and will be written to the database on upload. + and index.php: + + Line 32: $uploaddir="$fbasepath/downloads/files/"; + This is the absolute path to the folder for uploaded files. + The script must have write permissions for the upload directory. It is also a good idea to disallow execution of scripts in the directory. *************** *** 16,18 **** =================================== IT IS SAFE TO DELETE THIS FILE ! =================================== \ No newline at end of file --- 21,23 ---- =================================== IT IS SAFE TO DELETE THIS FILE ! =================================== |
|
From: Astronouth7303 <ast...@us...> - 2005-03-22 20:44:49
|
Update of /cvsroot/openfirst/downloads In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv6618/downloads Added Files: .cvsignore readme.txt Log Message: -Moved "readme.txt" to this dir -ignoring files --- NEW FILE: .cvsignore --- files --- NEW FILE: readme.txt --- openFIRST Download Manager =================================== IT IS SAFE TO DELETE THIS FILE =================================== This directory is the default location for uploaded files. To change it, edit admin/upload.php: Line 34: $uploaddir=$fbasepath."/downloads/files/"; This is the absolute path to the folder for uploaded files. Line 35: $serverdir="files/"; This path is relative to getfile.php, and will be written to the database on upload. The script must have write permissions for the upload directory. It is also a good idea to disallow execution of scripts in the directory. =================================== IT IS SAFE TO DELETE THIS FILE =================================== |
|
From: Astronouth7303 <ast...@us...> - 2005-03-22 20:43:27
|
Update of /cvsroot/openfirst/downloads/files In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv5841/downloads/files Added Files: .cvsignore Removed Files: readme.txt Log Message: -Moved "readme.txt" to parent dir -Ignoring contents --- NEW FILE: .cvsignore --- * --- readme.txt DELETED --- |
|
From: Astronouth7303 <ast...@us...> - 2005-03-22 20:37:58
|
Update of /cvsroot/openfirst/downloads In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2790 Modified Files: index.php Log Message: Bug #18. Added checks to make sure the file is writable. Not thoroughly tested (meaning an error has not been induced to try it). Index: index.php =================================================================== RCS file: /cvsroot/openfirst/downloads/index.php,v retrieving revision 1.7 retrieving revision 1.8 diff -C2 -d -r1.7 -r1.8 *** index.php 25 Dec 2003 19:13:46 -0000 1.7 --- index.php 22 Mar 2005 20:37:29 -0000 1.8 *************** *** 30,33 **** --- 30,34 ---- $images = true; // To show images or not + $uploaddir="$fbasepath/downloads/files/"; define("cols",3); // To show the number of columns per page define("rows",2); // To show the number of rows *************** *** 59,63 **** $query = ofirst_dbquery("SELECT * FROM ofirst_downloadcat ORDER BY Category"); if(ofirst_dbnum_rows($query)!=0){ ! echo("<div>Please select a category from the list below.<br><br></div>"); echo("<table width=400><tr><th>Categories</th></tr>"); echo('<tr><td><a href="'.$_SERVER["PHP_SELF"].'">'); --- 60,64 ---- $query = ofirst_dbquery("SELECT * FROM ofirst_downloadcat ORDER BY Category"); if(ofirst_dbnum_rows($query)!=0){ ! echo("<div>Please select a category from the list below.<br /><br /></div>"); echo("<table width=400><tr><th>Categories</th></tr>"); echo('<tr><td><a href="'.$_SERVER["PHP_SELF"].'">'); *************** *** 85,89 **** $cat = ofirst_dbfetch_object($query); echo("<h1>$cat->Category</h1>"); ! echo("<div>$cat->Description<br><br></div>"); $category=$cat->Category; } --- 86,90 ---- $cat = ofirst_dbfetch_object($query); echo("<h1>$cat->Category</h1>"); ! echo("<div>$cat->Description<br /><br /></div>"); $category=$cat->Category; } *************** *** 95,99 **** $numfiles=ofirst_dbnum_rows($query); if ($numfiles!=0){ ! echo("<br><br><table><tr><th colspan=".cols.">$cattitle</th></tr><tr><td colspan=".cols.">"); $file = ofirst_dbfetch_object($query); --- 96,100 ---- $numfiles=ofirst_dbnum_rows($query); if ($numfiles!=0){ ! echo("<br /><br /><table><tr><th colspan=".cols.">$cattitle</th></tr><tr><td colspan=".cols.">"); $file = ofirst_dbfetch_object($query); *************** *** 169,183 **** if($admin){ ! echo('<br><br><form action=admin/upload.php method=POST enctype="multipart/form-data"> ! <table width=400><tr><th colspan=2>Add File</th></tr>'); ! echo('<tr><td> <label for=Title><b>Title</b></label></td><td><input name=Title id=Title></td></tr> <tr><td><label for=newfile><b>File</b></label></td><td><input type=file name=newfile id=newfile> ! <input name=Category type=hidden value="'.$category.'"></td></tr> <tr><td><label for=Description><b>Description</b></label></td><td><textarea name=Description id=Description></textarea></td></tr> <tr><td> </td><td><input type=checkbox name=db id=db value="1"><label for=db>Store in database</label></td></tr> <tr><td colspan=2 align=center><input type=submit value="Add File"> ! </td></tr>'); ! echo("</table></form>"); } --- 170,189 ---- if($admin){ ! if (!is_writable($uploaddir)) { ! echo '<div class="warning">The save directory "'.htmlencode($uploaddir).'" is not writable!<br /> ! This must be fixed before any files can be uploaded!</div>'; ! } ! ?><br /><br /><form action=admin/upload.php method=POST enctype="multipart/form-data"> ! <table width=400><tr><th colspan=2>Add File</th></tr> ! <tr><td> <label for=Title><b>Title</b></label></td><td><input name=Title id=Title></td></tr> <tr><td><label for=newfile><b>File</b></label></td><td><input type=file name=newfile id=newfile> ! <input name=Category type=hidden value="<?php echo htmlentities($category); ?>"></td></tr> <tr><td><label for=Description><b>Description</b></label></td><td><textarea name=Description id=Description></textarea></td></tr> <tr><td> </td><td><input type=checkbox name=db id=db value="1"><label for=db>Store in database</label></td></tr> <tr><td colspan=2 align=center><input type=submit value="Add File"> ! </td></tr> ! </table></form> ! <?php } |
|
From: Astronouth7303 <ast...@us...> - 2005-03-22 20:37:39
|
Update of /cvsroot/openfirst/downloads/admin In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv2790/admin Modified Files: upload.php Log Message: Bug #18. Added checks to make sure the file is writable. Not thoroughly tested (meaning an error has not been induced to try it). Index: upload.php =================================================================== RCS file: /cvsroot/openfirst/downloads/admin/upload.php,v retrieving revision 1.3 retrieving revision 1.4 diff -C2 -d -r1.3 -r1.4 *** upload.php 23 Dec 2003 23:30:25 -0000 1.3 --- upload.php 22 Mar 2005 20:37:18 -0000 1.4 *************** *** 30,34 **** // Directory to upload to ! $uploaddir=$fbasepath."/downloads/files/"; $serverdir="files/"; --- 30,34 ---- // Directory to upload to ! $uploaddir="$fbasepath/downloads/files/"; $serverdir="files/"; *************** *** 40,43 **** --- 40,48 ---- echo("<h1>File Upload</h1>"); + if (!is_writable($uploaddir)) { + echo '<div class="error">The save directory "'.htmlencode($uploaddir).'" is not writable!<br /> + This must be fixed before any files can be uploaded!</div>'; + die(include_once($footer)); + } // Check if user initiates upload process and run upload process if(isset($_POST['Title'])){ *************** *** 66,70 **** } ! echo('<br><br><div><a href="../index.php">[Return to File Manager]</a></div>'); ! include_once($footer); ?> \ No newline at end of file --- 71,75 ---- } ! echo('<br /><br /><div><a href="../index.php">[Return to File Manager]</a></div>'); ! include_once($footer); ?> |
7 messages has been excluded from this view by a project administrator.
