Menu
▾
▴
#81 eprescribe by MMF for H2H
E-prescribing is a key component of ‘meaningful use’. Prescribers who wish to participate in this program should ensure that their chosen EMR system
includes e-prescribing functionality that establishes an electronic connection with payers and pharmacies.
This module basically requires some authentication details and urls which can be obtained from H2H. Files that are attached contains the details regarding documentation(documentation-eprescribe.zip) and eprescribe code patch(eprescription.diff.zip) and folder structure(eprescribe.zip) where files are placed in subdirectories according to the path defined. For quick reference about the details regarding the eprescription module please refer to readMe.txt in documentation-eprescribe.zip..
Patch for eprescription
Documentation for eprescription
Folder structure with directory and subdirectory having specifi files
hey,
Put your code on a github branch, which makes it much easier for testers/reviewers:
http://github.com/bradymiller/openemr/commits/escribe-mmf_1
Recommend posting a message in the forums asking for code to be reviewed by other developers (important to give the github link and to also state you have attached some nice documentation here in the tracker)
I'll try to review it this weekend.
thanks for the contribution,
brady
AS an aside,
Check out how the github branch works. Note we will be able to leave comments in your actual code on:
http://github.com/bradymiller/openemr/commits/escribe-mmf_1
-brady
Hey Brady,
Thanks for your suggestion, we will be putting the code for eprescription into github branch. If it is possible for you to provide a link for how to work and upload code into github branch then that would be great.
hi,
To clarify; I already posted your code on that github branch. Sorry for the confusion. So, if you go to that github link below, you'll note a link a that top containing a commit with your code in it.
In the future, will be useful for your group to start learning how to use git/github. Here's a wiki page describing how to set it up for OpenEMR:
http://www.openmedsoftware.org/wiki/Git_for_dummies
For now, though, your code (and github branch) are ready for review. Just simply announce it in the developer forum (provide this tracker link since your documentation is here, and also provide my below github branch link).
thanks,
-brady
hey,
Embedded my code review in your code here:
http://github.com/bradymiller/openemr/commit/34afff0116c6af2bc0a37ea7c45855a3e1ac9e4d
-brady
Hi Brady,
As per your suggestion I have commit eprescription code on http://github.com/bradymiller/openemr/commits
/escribe-mmf_1 ,in reference to that I have certain questions regarding committing files on github which are as
follows:
a) I have made certain changes in some of the files regarding eprescription on my local working copy ,could you
please guide me what is the precise command for pointing at http://github.com/bradymiller/openemr/commits
/escribe-mmf_1 branch and committing the changes that I have made on my local working copy. I have gone
through http://www.openmedsoftware.org/wiki/Git_for_dummies but it would be better if you could give me some
guidance regarding the above asked questions.
Thanks
MMF systems
hi,
You can not post to others personal repos (ie. my github repo, which is where I placed your code; http://github.com/bradymiller/openemr/tree/escribe-mmf_1 ). However, it's trivial to grab my branch, work on it, and then post it to your personal repo on gitbhub.
To do this, I recommend going through the git for dummies tutorial, which will show you how to create your local working repo and public github repo and show you how to post branches to your public github repo (which would then allow us to test and review your code).
thanks,
-brady
MMF Systems,
If you're still having a problem with git/github, feel free to post a patch here instead (I'll then post it on my github repo).
thanks,
-brady
Hi Brady,
As per your comments on eprescription in git(http://github.com/bradymiller/openemr/commits/escribe-mmf_1),I have made changes and committed it in https://github.com/mmfsystem/openemr/commits/escribe-mmf_2 .Changes included are as follows:
1) Translation function have been included in eprescription related code.
2) Uncessary stripslashes has been removed from C_Prescription.class.php
3) Instead of using $_POST and $_GET their values has been stored in variables in C_Prescription.class.php
4) Typo mistake atleast => at least has been corrected in C_Prescription.class.php
5) Formdata function retained in rx_print.php
6) htmlspecialchars() functions has been retained in rx_print.php
7) Eprescription java script has been made as true/false feature and has been included in globals.inc.php and is
false by default ,available under Adminstration=>Globals=>Features and is applicable for adding,editing of new
user and patient.
8) Postal code length has been retained to 63 as per database.sql in Openemr4.0
9) chdir() is replaced with require_once in custom_report.php
10) Wrapper functions of sql.inc has been included in eprecription code rather then using mysql functions directly.
11) textformat.js.php is used for java script code so as xl( ) function could be retained for internationalization..
12) During adding of eprescription their are certain fields that are read only,reason for it is that they are auto populated
when medicine in searched and selected , sql/eprescription-upgrade.sql is used to populate medicines in
erx_medispan_db table.
Note: I have taken http://github.com/bradymiller/openemr/commits/escribe-mmf_1 as benchmark and merged code
into it and created new branch.
Please check and let me know if any changes needed..
Thanks
Devender
MMF Systems
hi,
I'm planning to review this code over the weekend.
thanks,
-brady
Hi,
Noted this code was based on an outdate OpenEMR from 12/2010. To update code and get this all into one commit recommend the following:
git checkout escribe-mmf_2
git checkout -b escribe-mmf_3
git rebase -i HEAD~4
-Keep 'pick' on the top commit and change 'pick' to 'squash' for the bottom three commits.
-At next screen modify the comments for your new rebases commit.
-When done you will now have one commit that includes all of your code
(next step is to update your code to most recent codebase)
git checkout -b escribe-mmf_4
git rebase master
-it will likely have conflicts. can see files with conflicts if do 'git status' and recommend googling for details on fixing the conflicts etc.
(feel free to contact me if problems. Also note I have you checking out new branches above (escribe-mmf_3, escribe-mmf_4) so you don't ruin you're current branches.
-brady
hey,
Tried below instructions and works fine (there's actually no merging conlficts). If you can't do below, then I can upload the commit to github, which you can then place on your github account (it's important to have the review done on your github repo so you get all the comments from the review).
-brady
HI Brady,
Thanks for providing the instructions for updating eprescription codbase with latest OpenEmr4.0 code,I will try it.In the meanwhile could you please commit the updated code in your github account so as it could be reviewed.
Thanks
Devender
MMF System
Hi,
I placed a rebase of your code in most current development code here (the first commit):
http://github.com/bradymiller/openemr/commits/escribe-mmf_2
Please look through my review on your first code submission (the first commit):
https://github.com/bradymiller/openemr/commits/escribe-mmf_1
I left about 45 or so comments (can find them by searching for bradymiller in the page) and it seems like at least half of them were not addressed. Please go through these and state whether issue was addressed. Then please address the issues not addressed with another review submission (use the code in my escribe-mmf_2 branch (link ed above) as your base to add commits to).
It actually took me some time to get your code updated to the most current code. I'm gonna ask you to do this for now on.
thanks and look forward to your next submission,
-brady