Menu
▾
▴
#70 Calendar modifications and Billing Facility Modifications
Changed calendar look and added some features. Billing facility made selectable at the encounter level.Please review
http://github.com/zhhealthcare/openemr/tree/calendar_and_billing_location_modifications
HEre is the link http://github.com/zhhealthcare/openemr/tree/calendar_and_billing_location_modifications
Sir,
As per your commend in git hub(typo?) .
Concerning '$dat' its not a typo, we have declared and initialized this variable just before where it is used.
Thanks and Regards
Jacob T.Paul
www.zhservices.com
hey,
thanks for reply.
posted review on the github branch.
-brady
We will correct according to your Instructions. Thanks for your valuable suggestions.
Thanks and regards
Jacob T.Paul
www.zhservices.com
Hai,
As per brady's comment we have corrected the codes, and the modified files are pushed to git hub
https://github.com/zhhealthcare/openemr/tree/calendar_and_billing_location_modifications_v1
It has two commits. Also uploaded the patches(Two patches for two commits- patch1.patch and patch2.patch)
Thanks and regards
Jacob T.Paul
www.zhservices.com
Patch 1 of https://github.com/zhhealthcare/openemr/tree/calendar_and_billing_location_modifications_v1
patch 2 of https://github.com/zhhealthcare/openemr/tree/calendar_and_billing_location_modifications_v1
hi,
Please also post a review request for code reviews in the developer forum. Otherwise you'll miss out on getting reviews and testing from others (such as Tony, Rod, etc.).
thanks
-brady
Hi,
we have corrected the codes, and the modified files
are pushed to git hub
Thanks and regards
Jacob T.Paul
www.zhservices.com
Hey Brady , Tony
What is the status of this? Has it been pushed into the code?
Thanks and regards
Sam
I'd be happy to merge it with current devtip, check it one more time and prepare it for commit.
--Tony
hey,
The issues brought up in the forums were not addressed:
http://sourceforge.net/projects/openemr/forums/forum/202506/topic/3943558
My main concern is that you're removing appt specific color coding functionality in order to add multi-facility color coding(when most users will be using one facility). Should be able to find a happy medium here. Please continue this discussion on the above forum thread, since we now have testers that will test your code and provide some more input.
-brady
1)Added type field(provider/patient) in category creating interface.
2)User wise settings for appointment color in calendar GUI.
GitHub Path:https://github.com/zhhealthcare/openemr/commit/3d9288c11fe4a6412baf06767f7c00577f03cc70
And also uploaded the patch
Thanks and Regards
Jacob T.Paul
ZH Healthcare
www.zhhealthcare.com
Calendar modifications and Billing Facility Modifications
Wow! Just started testing out the modified calender.
I remember someone complaining on the forums about a physician who dismissed OEMR on the basis that its UI looked "Too Primitive". I say let the physician look at it now!!
Anyway, the only glaring aesthetic issue I immediately noted was the mismatch between the new themes that came with MenuMod and the scheduling popup accessed by clicking on a slot on the calender or on "Add" button on calender page.
The background of the popup is grey, sometimes contrasting quite prominently with the theme color.
Wish it could "merge" with the theme seamlessly more or less like the "New Patient" screen.
Otherwise, great work guys. Will keep poking.
Mukoya.
hi,
I placed a review on github. It is looking really good; really just some minor stuff to deal with before commitable. Will be important to solicit both Rod and Tony's opinion (feel free to ask them directly on the forum to look at this; and feel free to say brady is also requesting this) regarding the billing facility feature. My billing knowledge is very limited, so I always like to have Rod and Tony look over stuff that is related to billing.
thanks,
-brady
Just so happens that I need this feature, like right now. So I'm going to install it on the system I need to do multi-facility billing and see how it goes. Just in time.
--Tony
I am unable to display appointment comments with the new calender.
Mukoya.
Mukoya - which style of calendar? That particular feature is not implemented the same way in all the styles. (it should be, but it isn't). --Tony
Any chance we could separate this into the Billing changes for multi facility and the Calendar changes? I think the Billing stuff is much simpler and could get adopted more easily. I hat to see that help up by the complex changes to the calendar functions.
--Tony
.... I hate to see that held up by the complex changes to the calendar functions.
(I want SF tools that let you edit your posts)
-Tony
Tony,
I cant seem to find the calender style page. Remember seeing it somewhere before upgrading my OEMR.
I am using the latest dev. tip with the (not yet committed) calender modification.
I am using sliding menu with Style_oemr.css theme.
The calender tab in globals has no style option except "Appointment/Event color" which is set to "Category Color Schema"
The calender under Admin>Others does not seem to have a style option.
Mukoya
I added some code comments to the github commit.
Rod
If you did not change it it the 'users' table then you are using the default which is 'Outlook'. There are two other styles, "Fancy" and "Original" listed under Calendar-UI. The OutLook format did only had display of comments added recently (by me) and it's possible that ZHH used a previous version as the base for these changes and lost that code.
--Tony