Overall it looks nice and test ok. I committed it to the sourceforge codebase, but a couple bugs and some other optional things to think about.
Bugs:
----Very ugly spacing for the date widget button (it end up under the date textbox)
----Just make the date From label 'From' (ie. remove Issues)
----Have typo below Refresh button ->> </spain>
----Make "This step will generate file which you have to save for future use"... line in xl all one line and don't use leading or trailing spacing within the string (otherwise breaks the script that collects new constants in the codebase).
----Incorporate the date function oeFormatShortDate() from library/formatting.inc.php script (see other reports for examples)
----I'm confused about the UPDATE line in the upgrade script. If this is meant to be commented out, please remove it, potential syntax error there with the comma if it is a comment (I am assuming you are testing the upgrade script, if not, please do so).
OPTIONAL STUFF:
--Perhaps figure out a way to save the HL7 file (either a straight file or a text (mediumtext likely enough) mysql entry.
--Perhaps attach the decision to allow reportable on the Admin->Code Types->Lists (from code_types table) Diagnosis flag (ct_diag column) rather than hard-coding to ICD9.
--Considering converting script to the new security model. (please ensure any new projects/scripts follow this model): http://www.openmedsoftware.org/wiki/Active_Projects#PLAN (best way to learn model is look at examples)
Michael,
Are you using a consistent programmer. If so, then may be best to consider cvs access for him/her (since they've demonstrated good openemr coding) (if Rod also agrees). Then will be easier for your programmer to fix the minor bugs in the SF cvs and add features, as needed, to this stuff.
thanks,
brady
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
patch for ess
hey,
Overall it looks nice and test ok. I committed it to the sourceforge codebase, but a couple bugs and some other optional things to think about.
Bugs:
----Very ugly spacing for the date widget button (it end up under the date textbox)
----Just make the date From label 'From' (ie. remove Issues)
----Have typo below Refresh button ->> </spain>
----Make "This step will generate file which you have to save for future use"... line in xl all one line and don't use leading or trailing spacing within the string (otherwise breaks the script that collects new constants in the codebase).
----Incorporate the date function oeFormatShortDate() from library/formatting.inc.php script (see other reports for examples)
----I'm confused about the UPDATE line in the upgrade script. If this is meant to be commented out, please remove it, potential syntax error there with the comma if it is a comment (I am assuming you are testing the upgrade script, if not, please do so).
OPTIONAL STUFF:
--Perhaps figure out a way to save the HL7 file (either a straight file or a text (mediumtext likely enough) mysql entry.
--Perhaps attach the decision to allow reportable on the Admin->Code Types->Lists (from code_types table) Diagnosis flag (ct_diag column) rather than hard-coding to ICD9.
--Considering converting script to the new security model. (please ensure any new projects/scripts follow this model):
http://www.openmedsoftware.org/wiki/Active_Projects#PLAN (best way to learn model is look at examples)
Michael,
Are you using a consistent programmer. If so, then may be best to consider cvs access for him/her (since they've demonstrated good openemr coding) (if Rod also agrees). Then will be easier for your programmer to fix the minor bugs in the SF cvs and add features, as needed, to this stuff.
thanks,
brady