Menu

#276 Code Editor Modernisation

open
code review (1)
5
2016-08-20
2016-08-14
No

Hi all,

Hope I am putting this in the right place,

I have been working on updating the code editor to something a bit more modern.

Currently I have the search and editing working okay, however if I edit an external code, it saves to the codes table but doesn't reflect anywhere, I looked at the original code editor and it seemed as if it worked that way, bu perhaps I have it wrong.

hopefully this is of some use to the project.

please see the pull request here : https://github.com/openemr/openemr/pull/182

github branch is here : https://github.com/cbezzy/openemr/tree/newCodeEdit

please guide me on this code review thing.

Also, I don't know which way the priorities work ie is 9 more important or 1, so I left it at the default 5.

Thanks

Discussion

  • Rod Roark

    Rod Roark - 2016-08-15

    I put a couple of questions in the PR, about things that seem omitted. It's important not to discard features without discussion; they are usually there for some good reason.

     
  • Rod Roark

    Rod Roark - 2016-08-15

    Also a screenshot or two would help us understand quickly what you're doing.

     
  • Craig Bezuidenhout

    thanks Rod, I want to include everything needed. going through your comments and will revert as soon as I have more info.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.