OpenEMR / Code Review / #270 Patient Portal fix

Patient Portal fix

#270 Patient Portal fix

Milestone: None

Status: open

Owner: nobody

Labels: Offsite Patient Portal (1)

Priority: 5

Updated: 2016-03-31

Created: 2016-03-30

Creator: ZH Healthcare

Private: No

Hi,

There was an issue in windows server when we pass an empty binding array to the function sqlstatement(). We have fixed the issue by passing false if the binding array is empty. Below is the github path for the same.

https://github.com/zhhealthcare/openemr/commit/f2edd78e517742c8deb1138f6d73719da858effb

Thanks & Regards
ZHHealthCare

Discussion

ZH Healthcare - 2016-03-30

summary: https://github.com/zhhealthcare/openemr/commit/f2edd78e517742c8deb1138f6d73719da858effb --> Patient Portal fix

Group: -->
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Brady Miller - 2016-03-31

Hi ZH,

Thanks for pointing out this bug, which likely arised after we redid the sql wrappers to support mysqli. Instead of adding your commit above, I added a commit to fix this in a more central location for all of the sql wrappers (I am guessing there will be several more places in the codebase that will break on windows, so seems best to just fix it centrally):
https://github.com/openemr/openemr/commit/a87f7824bd0679152f81227c101958a95a9c3aa2

-brady

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Brady Miller - 2016-03-31

Was hoping to get confirmation by you or Arnab that the above fix I just committed to the codebase worked.
thanks,
-brady

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Patient Portal fix

Group

Searches

Help

#270 Patient Portal fix

Discussion