Menu
▾
▴
#221 Allow arbitrarily long configuration file lines
Hi, I've found that opendmarc cannot handle long line in the opendmarc.conf (more than 1024 characters).
And it seems that opendkim has already fix the bug in this commit.
I've tested the patch on the opendmarc, and it works. So I think it's pretty easy to fix this bug in opendmarc.
I'm not the maintainer of OpenDMARC, but I think allowing arbitrarily long lines will open a DOS vector and I don't see a reason to do so. Why do we need arbitrarily long lines? What is wrong with a length of 1024 characters? As long as we handle it gracefully if a line is longer, I don't see a problem.
We might need to raise the limit to 4096 or even 8192 to handle path length that are close to the limit of PATH_MAX, but arbitrarily long lines?
Last edit: Juri Haberland 2018-03-30
The arbitrarily long lines allow me to add as many domains to IgnoreMailFrom. Since some domain names are pretty long, it's easy to hit the limit.
I think the right solution for your problem would be to introduce a new config option hat specifies a file holding a list of domain names (MailFrom) that should be ignored.
I agree. It would be great to be able to specify a file instead of specifying all domains in the config file.