It's actually a duplicate of ticket #187, which is for 1.3.2-beta0 & beta1, but only a part of the proposed patch was applied, missing the compile fix. I mentioned it in my (somewhat emtional) rant at the dev ML: http://www.trusteddomain.org/pipermail/opendmarc-dev/2017-January/000322.html
On another note I think it is better to not mix up bug fixes with unrelated optimizations (e.g. declaring some variables as const).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Point taken regarding bug vs. optimization. Unfortunately the link is non-public, can't look at it. About compile errors: it compiles on my Ubuntu 14.04 with gcc 4.8.4 without a single warning, so newer compilers seem to enforce this now...
But nevertheless, I still think it would be better to not mix different bug fixes into one patch, but make a separate ticket just fixing those types of bugs, and then maybe most or even all of them.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
As for const char * vs. char *, I'd rather do a global fix of that separately from this since it's not actually stopping this long-overdue release. I'll leave this open for that purpose.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
we believe we've fixed a lot of this in 1.4.0, and we have an open ticket for the char stuff. I'm closing this out here in preparation for collapsing this site.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
It's actually a duplicate of ticket #187, which is for 1.3.2-beta0 & beta1, but only a part of the proposed patch was applied, missing the compile fix. I mentioned it in my (somewhat emtional) rant at the dev ML: http://www.trusteddomain.org/pipermail/opendmarc-dev/2017-January/000322.html
On another note I think it is better to not mix up bug fixes with unrelated optimizations (e.g. declaring some variables as const).
That's not an optimization, but a bug fix as well.
Whenever literals are assigned to char pointers it's wrong.
OpenDMARC is actually full of such errors. Full list here: https://build.opensuse.org/build/home:dstoecker/openSUSE_Leap_42.1/x86_64/opendmarc/_log
Software with so many compiler warnings is seldom.
Point taken regarding bug vs. optimization. Unfortunately the link is non-public, can't look at it. About compile errors: it compiles on my Ubuntu 14.04 with gcc 4.8.4 without a single warning, so newer compilers seem to enforce this now...
But nevertheless, I still think it would be better to not mix different bug fixes into one patch, but make a separate ticket just fixing those types of bugs, and then maybe most or even all of them.
Ooops, I wasn't aware that the public links are different. There must be a "/public" in the link: :-)
https://build.opensuse.org/public/build/home:dstoecker/openSUSE_Leap_42.1/x86_64/opendmarc/_log
I fixed the actual bug independent of this patch.
As for const char * vs. char *, I'd rather do a global fix of that separately from this since it's not actually stopping this long-overdue release. I'll leave this open for that purpose.
we believe we've fixed a lot of this in 1.4.0, and we have an open ticket for the char stuff. I'm closing this out here in preparation for collapsing this site.