Menu

#188 [1.3.2 beta] bug fix: don't delete zip file too early in opendmarc-reports

1.3.1
closed
bugfix (5)
2017-03-04
2016-09-30
No

Opendmarc-reports loops over all reporting URIs a domain has. If a URI is erroneous, the report and the zip file will be deleted. If there is another reporting URI for processed domain, which is correct, the sending of the report fails because the zipfile was deleted previously.

The attached patch fixes this issue by removing all calls to unlink() in the loop. The report and the zipfile will be deleted after the loop anyway.

1 Attachments

Discussion

  • Murray S. Kucherawy

    • assigned_to: Murray S. Kucherawy
     
  • Murray S. Kucherawy

    Patch applied, thanks!

     
    • Juri Haberland

      Juri Haberland - 2016-12-18

      The distributed script "opendmarc-reports" is still the old one, but the template "opendmarc-reports.in" is correct. Would be best do remove all files from the source code archive that are generated by a "./configure"-run.

       

      Last edit: Juri Haberland 2016-12-21
  • Murray S. Kucherawy

    • status: open --> closed
     
  • Murray S. Kucherawy

    v1.3.2 released.

     

Log in to post a comment.

MongoDB Logo MongoDB