#155 disable-live-testing doesn't disable all tests that use net

2.7.4
closed-fixed
Packaging (15)
6
2013-02-25
2013-01-24
No

See the atttached patch. This solves build failures due to test issues on builders that don't have internet access.

Discussion

  • Scott Kitterman

    Scott Kitterman - 2013-01-24
     
  • Murray S. Kucherawy

    • milestone: --> 4575246
    • labels: --> 1195574
    • status: open --> pending
     
  • Murray S. Kucherawy

    Those three tests all use "example.com" as the signing domain, and the verification key for the signature is provided locally via the TestPublicKeys setting in the matching .conf file.

    Is it the ADSP query that's trying to go out live and failing? If so, it's probably better to add "DisableADSP" to the test configuration files until it's working again.

     
  • Scott Kitterman

    Scott Kitterman - 2013-01-24

    There are queries for the ADSP record, so that's at least part of it. There are also queries to dkim-reputation.org and agitos.de.

     
  • Scott Kitterman

    Scott Kitterman - 2013-01-24
    • status: pending --> open
     
  • Murray S. Kucherawy

    • assigned_to: nobody --> cm-msk
    • priority: 5 --> 6
    • milestone: 4575246 --> 2.7.4
    • labels: 1195574 --> Packaging
     
  • Murray S. Kucherawy

    "agitos.de" should be the result of NS resolution of "dkim-reputation.org" and not anything direct. But the latter, plus the ADSP checks, can be disabled in configuration. I'll adjust the test config files to do so except for the tests that are specifically trying to confirm those functions, and then those ones need to be excluded with --disable-live-testing.

    Moving to "Bugs".

     
  • Murray S. Kucherawy

    I've committed and pushed a change to "develop" that disables ADSP checking in all verification tests that aren't explicitly exercising the ADSP code. For those that are, the fake DNS records in the "pubkeys" file should be checked anyway, so they should never go to DNS.

    As for the dkim-reputation.org and agitos.de queries, those are always on if you build with --enable-dkim_reputation unless you configure a "DKIMReputationRoot" of "none". As I'm now planning to drop support for that feature altogether in the next major release after the 2.8.0 line, I suggest you either remove it from your tests and packages now, or add that config line to your tests.

    Together, that should leave you in a place where --disable-live-testing never needs net access. Please let me know if I've missed anything.

     
  • Murray S. Kucherawy

    Fix for this bug included in new release.

     
  • Murray S. Kucherawy

    • status: open --> closed-fixed
     

Log in to post a comment.