From: Stefan S. <se...@sy...> - 2004-05-27 15:41:50
|
hi there, I'm looking into the wide character support that has been added to opencxx recently (?) as I try to merge an equivalent patch into synopsis. The 'Encoding' class doesn't appear to account for wide characters. Is that an omission or am I missing something ? Regards, Stefan |
From: Stefan S. <se...@sy...> - 2004-05-27 21:26:29
|
Stefan Seefeld wrote: > hi there, > > I'm looking into the wide character support that has been > added to opencxx recently (?) as I try to merge an equivalent > patch into synopsis. > > The 'Encoding' class doesn't appear to account for wide characters. > Is that an omission or am I missing something ? I just committed a patch (to the 'sandbox_jakacki_frontend1' branch) to add wide character support to the Encoding and TypeInfo classes. It seems no opencxx user has noticed so far, only I did in synopsis. I backported it anyways, for completeness. Regards, Stefan |
From: Grzegorz J. <ja...@he...> - 2004-05-28 00:44:26
|
On Thu, 27 May 2004, Stefan Seefeld wrote: > Stefan Seefeld wrote: > > hi there, > > > > I'm looking into the wide character support that has been > > added to opencxx recently (?) as I try to merge an equivalent > > patch into synopsis. > > > > The 'Encoding' class doesn't appear to account for wide characters. > > Is that an omission or am I missing something ? > > I just committed a patch (to the 'sandbox_jakacki_frontend1' branch) > to add wide character support to the Encoding and TypeInfo classes. > It seems no opencxx user has noticed so far, only I did in synopsis. > I backported it anyways, for completeness. Thanks, Stefan. Indeed that must have been an omission. Could you also add a testcase? BR Grzegorz ################################################################## # Grzegorz Jakacki Huada Electronic Design # # Senior Engineer, CAD Dept. 1 Gaojiayuan, Chaoyang # # tel. +86-10-64365577 x2074 Beijing 100015, China # # Copyright (C) 2004 Grzegorz Jakacki, HED. All Rights Reserved. # ################################################################## |
From: Stefan S. <se...@sy...> - 2004-05-28 02:23:03
|
Grzegorz Jakacki wrote: >>I just committed a patch (to the 'sandbox_jakacki_frontend1' branch) >>to add wide character support to the Encoding and TypeInfo classes. >>It seems no opencxx user has noticed so far, only I did in synopsis. >>I backported it anyways, for completeness. > > > > Thanks, Stefan. Indeed that must have been an omission. Could you also add > a testcase? hmm, ok, once I understand how the TypeInfo class works ;-) In synopsis I only use the Encoding class, and the docs state to keep TypeInfo in sync whenever Encoding is changed, so I just followed the example... I'll have a closer look. Stefan |
From: Grzegorz J. <ja...@he...> - 2004-05-28 08:23:07
|
On Thu, 27 May 2004, Stefan Seefeld wrote: > Grzegorz Jakacki wrote: > > >>I just committed a patch (to the 'sandbox_jakacki_frontend1' branch) > >>to add wide character support to the Encoding and TypeInfo classes. > >>It seems no opencxx user has noticed so far, only I did in synopsis. > >>I backported it anyways, for completeness. > > > > > > > > Thanks, Stefan. Indeed that must have been an omission. Could you also add > > a testcase? > > hmm, ok, once I understand how the TypeInfo class works ;-) > In synopsis I only use the Encoding class, and the docs state to > keep TypeInfo in sync whenever Encoding is changed, so I just > followed the example... > I'll have a closer look. I never had time to understand if this is really necessary. Looks like a gratituous coupling. BR Grzegorz > > Stefan > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: Oracle 10g > Get certified on the hottest thing ever to hit the market... Oracle 10g. > Take an Oracle 10g class now, and we'll give you the exam FREE. > http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click > _______________________________________________ > Opencxx-users mailing list > Ope...@li... > https://lists.sourceforge.net/lists/listinfo/opencxx-users > > ################################################################## # Grzegorz Jakacki Huada Electronic Design # # Senior Engineer, CAD Dept. 1 Gaojiayuan, Chaoyang # # tel. +86-10-64365577 x2074 Beijing 100015, China # # Copyright (C) 2004 Grzegorz Jakacki, HED. All Rights Reserved. # ################################################################## |
From: Stefan S. <se...@sy...> - 2004-05-28 12:41:49
|
Grzegorz Jakacki wrote: >>hmm, ok, once I understand how the TypeInfo class works ;-) >>In synopsis I only use the Encoding class, and the docs state to >>keep TypeInfo in sync whenever Encoding is changed, so I just >>followed the example... >>I'll have a closer look. > > > I never had time to understand if this is really necessary. Looks like a > gratituous coupling. well, the dependencies aren't gratituous. As we discussed, the 'mop' classes all depend on the 'parser' classes, and that's particularly true for the 'TypeInfo' / 'Encoding' relationship. That said, it may be possible to better encapsulate the encoding stuff inside the Encoding class such that changes as the one I applied doesn't require a code change in the TypeInfo. Regards, Stefan |