Re: [Opencxx-users] parser/PtreeBrace.cc

[<se...@in...>]

On Wed, 2004-08-11 at 11:27, Grzegorz Jakacki wrote:
> Gilles J. Seguin wrote:
> > Grzegorz,
> > 
> > Can you verify this.
> > function is call second() but return the third element 
> > of the list.

in opencxx/parser/PtreeBrace.cc
on line 59, we have
Ptree* Second(Ptree* p)
This function return the third element
in fact I do not care which element number it is,
a want the element containing "body"

The impact is huge because "body" is also in rule
namespace identifier '{' body '}'

> I am not sure if I understand. PtreeUtil::Second(), as it stands

Why are you talking about PtreeUtil.cc file,
Grzegorz, the change is in opencxx/parser/PtreeBrace.cc

> both in HEAD and rel_2_8,

The patch says against version 1.2.2.1
which is branch rel_2_8

>  returns second element of the list (or
> NULL if it does not exist). After applying the patch from your
> e-mail (shown below), it will indeed return third element.
> This is a patch against what?

against CVS
$ cd opencxx/parser
$ cvs diff -u PtreeBrace.cc

> BR
> Grzegorz
> 
> > 
> > Since the result from qmtest are hardcoded,
> > $ qmtest -o myresults.qmr run  # lowercase 'o'
> > on future test do
> > $ qmtest -O myresults.qmr run   # uppercase 'O'
> 
> Where is the version with qmtest?

the link to the file is <http://www.infonet.ca/segg/occ.tgz>
Since the patch modify the ouput of "occ",
nearly all tests fail.
Previous commands allow to generated valid new output to retest against.

> > diff -u -r1.2.2.1 PtreeBrace.cc
> > --- PtreeBrace.cc       8 Jul 2004 11:57:13 -0000       1.2.2.1
> > +++ PtreeBrace.cc       10 Aug 2004 13:13:03 -0000
> > @@ -59,10 +59,10 @@
> >      Ptree* Second(Ptree* p)
> >      {
> >          if (p) {
> > -            p=p->Cdr();
> > -            if (p) {
> > +            //p=p->Cdr();
> > +            //if (p) {
> >                  return p->Cdr();
> > -            }
> > +            //}
> >          }
> >          return p;
> >      }