[Opencxx-users] Re: [opencxx] patch by Jean-Sebastien Mouret

[Grzegorz J. <ja...@he...>]

Hi,

> From: Jean-Sebastien Mouret <js at lrde.epita.fr>
> Date: 22 Oct 2002 05:01:54 +0200
>
> Hi,
>
> Here is a very small patch to fix struct's members default access.
> As seen somewhere in the iso c++ standard:
> "Members of a class defined with the keyword class are private by
>  default. Members of a class defined with the keywords struct or
>  union are public by default."
>
> Let me know if this helps,

Big thanks for submitting this patch. The only thing I would suggest is to
use constants like 'Ptree* Class::class_t' (see mop.h), instead of char*.

> and if this is the correct way of
> submitting such tiny patches.

The desired way of submitting the patches is:

(1) Get yourself account on SourceForge.net (free).
(2) Send your SourceForge id to me, so that I can set up CVS access for you.
(3) Check out HEAD revision from CVS (http://sourceforge.net/cvs/?group_id=40789)
(4) Write a testcase which would fail without your patch, but passes
    when your patch is applied (step-by-step HOWTOs on adding testcases
    can be found in subdirs of 'testsuite/'; it's easy),
(5) Build and run testsuite (./configure; make; cd testsuite; make tests).
(6) Apply your patch.
(7) Again build and run testsuite.
(8) If everything is ok, commit (cvs commit).

I am ready to help with all these steps (however I will be traveling
during the next week and I am not sure if I will be able to access
internet; I should be back on Monday, Nov 4th).

Alternatively, you may try to find somebody on this list who already has
CVS access and try to convince that person to commit your changes. However
it seems not to be easier than committing the changes yourself :-)

Thanks again for the patch. Hope to hear from you again.

Grzegorz

##################################################################
# Grzegorz Jakacki                       Huada Electronic Design #
# Senior Engineer, CAD Dept.              1 Gaojiayuan, Chaoyang #
# tel. +86-10-64365577 x2074               Beijing 100015, China #
# Copyright (C) 2002 Grzegorz Jakacki, HED. All Rights Reserved. #
##################################################################