[Opencxx-users] Re: [opencxx] changes/occ2.5.12

[Grzegorz J. <ja...@he...>]

Robert,

First, big thanks for contributing your patch. Really decent piece of work
I must say! My comments follow:

On Fri, 20 Sep 2002 ro...@lo... wrote:

> In all the changes I thought about backward-compatibility so even I you wrote
> code which depends heavily on the occ internal object implementations this
> shouldn't break anything:
>
> - for all pure virtual functions you can remove the pure specifier with
>   Member::RemovePureSpecifier(). Had to do this, since the member's declarator
>   is private and I didn't want to mess around with the access specifiers.

Right.

> - I had to set MaxNameLen in encoding.h to 1024, due to some complicated
>   namespace nestings, which exceeded the 512 character limit. I personally
>   would prefer to make this limit unnecessary at all but what I understand
>   from the source it seems that this might mean to change code at various,
>   essential places so I am not sure if I will do it.

I think that indeed it would take a substantial effort. The general
comment, not pertaining specifically to your patch, is that it is
inevitable. AFAIR with current encoding scheme the encoding of any
component of scoped identifier cannot exceed 255, which is not much if the
component is a template instance.

> - I added a new suffix as an indicator for C++ source (.eti, it's really an
>   internal thing but I don't have the time to clean up my patch at the moment).

This one I do not understand. Could you explain?

> - I added a new command line switch (-T) which let's occ output the
>   translated parse tree on stdout in addition to writing it to an .ii file.
>
> - last, but not least: I added a method similar to CopyList to ptree-core.
>   CloneList has some advantages over CopyList which I found to be very
>   useful:

Makes sense. I remember that I needed something like that once.

Let me contact you directly wrt. committing changes to the repository.

Regards
Grzegorz

##################################################################
# Grzegorz Jakacki                       Huada Electronic Design #
# Senior Engineer, CAD Dept.              1 Gaojiayuan, Chaoyang #
# tel. +86-10-64365577 x2074               Beijing 100015, China #
# Copyright (C) 2002 Grzegorz Jakacki, HED. All Rights Reserved. #
##################################################################