Menu

#241 RecursiveType constructor should at least be protected

v1.0 (example)
closed-fixed
None
5
2023-11-10
2023-03-02
Razvan Dana
No

When trying to override some existing functionality from the AbstractMappingStrategy, and more specifically involving the recursive behavior, one would need access to the constructor of the RecursiveType class. I believe the default access provider is by mistake, and not by design (the class itself is protected).

Discussion

  • Scott Conway

    Scott Conway - 2023-03-04
    • assigned_to: Scott Conway
     
  • Scott Conway

    Scott Conway - 2023-03-04

    I have made the change and all tests pass so I have commited it and it will go out in the next release.

    The next release may be a couple of months as I am looking at some profiling results to try and speed up the ResultSet processing and between life and work that is slow going.

     
  • Razvan Dana

    Razvan Dana - 2023-03-08

    Thanks Scott, would it be possible to make the access for recursiveTypeTree on AbstractMappingStrategy protected as well ?

     
  • Scott Conway

    Scott Conway - 2023-03-09

    done.

     
  • Andrew Rucker Jones

    This ticket can be closed, can it not? The changes are not listed on the project wiki's "What's new" page, but we have released since this was done.

     
  • Razvan Dana

    Razvan Dana - 2023-11-10

    Please feel free to close it on my account.

     
  • Scott Conway

    Scott Conway - 2023-11-10

    Yes I am going to close this and retroactively update the what's new page. I see that the change was made and it must have gone out in the 5.8 release but I must not have updated the what's new page when I merged the code in.

     
  • Scott Conway

    Scott Conway - 2023-11-10
    • status: open --> closed-fixed
     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.