Menu

#237 Error message don't use errorLocale

v1.0 (example)
closed-fixed
None
5
2023-11-10
2022-11-16
No

In ConverterEnum and ConverterCurrency errorLocale is not used, then we cannot override the locale.

ResourceBundle.getBundle(ICSVParser.DEFAULT_BUNDLE_NAME)

instead of

ResourceBundle.getBundle(ICSVParser.DEFAULT_BUNDLE_NAME, this.errorLocale)

Discussion

  • Andrew Rucker Jones

    • status: open --> pending
    • assigned_to: Andrew Rucker Jones
     
  • Andrew Rucker Jones

    Thanks for spotting this. I've fixed it in the repository, and the fix will be in the next release.

    Incidentally, if you have a translation you're willing to donate, we'd love to have it.

     
  • Pierrick Gosset

    Pierrick Gosset - 2022-11-16

    I cloud give you translations in French:
    illegal.enum.value=La valeur [%1$s] n'est pas une valeur valide pour le type énuméré %2$s.
    profile.not.found.date=Aucune annotation CsvDate n'a été trouvée pour le profil "%s". (Google Translate is OK)
    profile.not.found.number=Aucune annotation CsvNumber n'a été trouvée pour le profil "%s". (Google Translate is OK)

     
    • Andrew Rucker Jones

      Thanks, but I really meant the entire set of language resource files. It's fine if you're not willing to do that. It just sounded like you might already have it.

       
      • Pierrick Gosset

        Pierrick Gosset - 2022-11-16

        Oh ok. I don't already have it. But I could check it asap.

         
        • Pierrick Gosset

          Pierrick Gosset - 2022-12-07
           
          • Andrew Rucker Jones

            I'm simply delighted about that, and I merged your changes instantly (and gave you credit on our "What's New?" page, of course!). The fixes will be released with the next version of opencsv.

             
            • Pierrick Gosset

              Pierrick Gosset - 2022-12-07

              You are welcome. I hope I haven't forgotten anything.

               
  • Andrew Rucker Jones

    • status: pending --> closed-fixed
     
  • Andrew Rucker Jones

    This fix was released with version 5.8 in July. Sorry I didn't update the ticket.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.