Menu

#25 Compile fix for: grep: warning: stray \ before #

v0.5.0
closed
nobody
None
1
2024-06-28
2024-06-28
No

Compile fix for: grep: warning: stray \ before #

Building OpenCBM on a modern linux (ArchlLinux) spews out 100's of the warnings below:

grep: warning: stray \ before #

This fix removes the stray '\' from grep statements and forces grep to handle the pattern as a fixed string without regexps

1 Attachments

Discussion

  • Spiro Trikaliotis

    Thank you for your patch.

    Note that OpenCBM development is done on github nowadays. This is only a read-only copy of the repository.

    I can apply your patch (with git apply or patch), but in this case, I would loose your information and it would look as if I had done this patch.

    I cannot apply it with "git am", because it complains :

    $ git am -p0 < master_uj_fix_grep_stray_warning.patch
    Applying: commit ac019e937ce4c5df008986774a3e429b1ea095dc (HEAD -> refs/heads/master_uj_fix_grep_stray_warning, refs/remotes/origin/master_uj_fix_grep_stray_warning)
    fatal: empty ident name (for <>) not allowed
    

    To be honest, I am not very familiar with applying patches from others.

    As I want to retain your name and data to the patch, is it ok if I ask you to re-issue your patch as a PR on github?

     
  • Uffe Jakobsen

    Uffe Jakobsen - 2024-06-28

    Hi Spiro,

    Thanks for your fast reply.

    I've just made a github PR for this fix.

    And thanks for explaining - I actually thought that it was the other way around...
    Because "nibtools" on github was read-only I also believed that "opencbm" was also read-only on github - and that sf.net was the origin of development :-)

    BR/Uffe :-)

     
  • Uffe Jakobsen

    Uffe Jakobsen - 2024-06-28

    This PR is now found on github https://github.com/OpenCBM/OpenCBM/pull/113

    I believe that we can close this issue/case

     
  • Spiro Trikaliotis

    Thank you, the patch is applied

     
  • Spiro Trikaliotis

    • status: open --> closed
     

Anonymous
Anonymous

Add attachments
Cancel