[OpenCA-Devel] minor bug: email verification in OpenCA 1.5.x sends malformed MIME mails

[Martin H. <he...@hl...>]

Hi,

I have found a minor bug in OpenCA 1.5.x

the following templates:
src/common/lib/mails/*/verifyMail.msg 

contain MIME multipart messages which ask the user to confirm his email
address. The boundary between the alternatives is defined at the
beginning of each file as "----=OpenCA_Verify_Email_@$$@" and each new
part begins with such a boundary prepended by two hyphens:
--boundary
which is correct (there are six hyphens, then), but the whole message
should be closed by the encapsulation
--boundary--
instead of
--boundary
(the two trailing hyphens in the closing encapsulation boundary are
missing for all languages).
see http://en.wikipedia.org/wiki/MIME#Multipart_messages or
http://www.w3.org/Protocols/rfc1341/7_2_Multipart.html

Some mail clients (e.g. Thunderbird) show the message correctly, but
some others (Macintosh) display an empty message (which makes it
difficult to click on the link).

Also, I believe the intention is that @$$@ should be replaced by some
PID or so, which actually doesn't happen
I believe the characters @ and $ which remain in the boundary also are
not fully standard conform if you look at the ones explicitly given in
rfc1341 (although it simply speaks about "characters from a set of
characters known to be very robust through email gateways"... ). One
could simply drop this part of the boundary or we would need an
appropriate replacement rule in sub libSendEmailVerifyMessage in
src/common/lib/functions/mail-utils.lib:
                $txt = $query->subVar( $txt, '@$$@', $$ );
but isn't this anyway always the same PID until the server admin
restarts the openca daemon?

best regards,
Martin