#902 obabel segfault from invalid command-line arg

[Craig]

The simple command "obabel -i" causes a segfault.

The problem is several cases like this:

for (arg = 1; arg < argc; ++arg)
  {
   ...
   case 'i':
     iext = argv[arg] + 2;
     if(!*iext)
       iext = argv[++arg];

Note that arg is incremented without checking to see whether it's past argc, so it's accessing past the end of the argv array. By luck, it's getting a NULL pointer, but iext could point to anything. There are a number of instances of this in the command-line parsing section.

[Craig]

What the heck? I'm unable to change "Milestone" to 2.3.x or anything else in this bug report. What's up with that?