#10 Check openastromenace with static analysis tools

Next_Release
open
nobody
None
3
2013-08-24
2013-08-10
Artem
No

I suggest checking openastromenace with static analysis tools from time to time. For examlpe, I've checked it with cppcheck and found some warnings, see report.xml for more information.
As I'm not familiar with the code I can't change some things but here is a small and rather useless patch.

2 Attachments

Discussion

  • Artem

    Artem - 2013-08-10

    I've checked, game compiles but crashed during loading. Don't know whether it's due to my changes or not. Will provide backtrace later.

     
  • viewizard

    viewizard - 2013-08-10

    I don't really like any "code checkers" due to a lot of fail reports. Usually, I use gcc warnings instead. But I will look at report.xml, thanks a lot!

    upd, yeah, I am blind :)

     
    Last edit: viewizard 2013-08-10
  • Artem

    Artem - 2013-08-10

    Well, they can be tuned to pass some reports and don't complain about them. I've never done that before, though. :)

    Anyway, I think it might be a good idea to check a project, for example, before releasing new version.

     
  • viewizard

    viewizard - 2013-08-10

    Yep. Good idea for sure. I already did some changes in my local sources (did your patch implemented too), and will do more during report.xml file analyzing (this will take some time). I will post here when all will be finished and commited into svn for your test. :-)

     
  • viewizard

    viewizard - 2013-08-19

    I did all changes in upstream. Still have a lot of fail positive reports for "C-style pointer casting" in C files, so, ignore them.

    Thanks a lot for your report, Artem. :-)

     
  • Artem

    Artem - 2013-08-24

    Nice to know everything is cleaned up :)
    If you're interested, we can register openastromenace on coverity online scan and have much more complex analysis.
    It looks like this: http://kroartem.files.wordpress.com/2013/06/coverity1.png
    If not, you can close this ticket as I don't have enough rights to close it.

     

Log in to post a comment.