[Open1451-devel] Issues in Reference Implementation (Java).

[Williams, B. <bwi...@ra...>]

Greetings:

=20

In my previous email, I indicated that I had removed the Rhapsody
references from the code base and ported the build to the Borland
JBuilder IDE.

=20

I have now ported this "clean" port (by clean, I mean "no proprietary
software included").  More people would use this if it did not require
this tool.

=20

When I compiled the code base with Eclipse, I found the following
problems.  These are coding problems that should be easily corrected.

=20

=20

1.  The assignment to variable publication_topic has no effect
IEEE1451_BasePublisherPort.java            IEEE1451/src/ObjectModel
line 98   October 6, 2005 7:56:15 AM

=20

This should probably be changed to assign the value to the class
variable "publicationTopic".

=20

2. The local variable returnCode1 is never read
IEEE1451_NCAPBlock.java        IEEE1451/src/ObjectModel         line 318
October 6, 2005 7:56:14 AM

=20

The return of this value should be made executable.  There are paths in
this routine that will not work.

=20

3. The assignment to variable updateTimestampUncertainty has no effect
IEEE1451_TransducerBlock.java            IEEE1451/src/ObjectModel
line 173 October 6, 2005 7:56:14 AM

=20

Again, the assignment is coded improperly.  I think it should read
"update_timestamp_uncertainty=3DupdateTimestampUncertainty.

=20

4. The assignment to variable port has no effect
ObjectDispatchAddress.java       IEEE1451/src/DataModel            line
49            October 6, 2005 7:56:16 AM

=20

Again, the assignment is coded improperly.  It should read "this.port =
=3D
port_no".

=20

I have _not_ made these changes to the clean version.  I think it
desirable to clean this from the top rather than branching the source at
this point.

=20

It is desirable to have the reference implementation _not_ depend on a
proprietary tool

=20

I can ship the eclipse build via .zip file to the site maintenance team
if desired.

=20

Bert Williams.

=20

=20

=20