Menu

#183 open-wm-tools-9.4.6 has conflicting macro with current linux kernel

v1.0 (example)
open-fixed
nobody
None
5
2015-07-09
2015-01-01
No

Hi,

The file lib/include/vm_assert.h, lines 285 to 292, redefines a macro that was introduced in linux kernel 3.13 in include/linux/printk.h: DEPRECATED.

I noticed that the macro is not used in any other place on open-vm-tools code, so removing the mentioned lines makes the compilation continue and does not break anything, apparently.

Since the linux kernel's macro is not going away any time soon, I suggest that either open-vm-tool's macro is removed or renamed, otherwise it will be impossible to compile with newer linux headers.

Thanks!
Arthur Nascimento

Discussion

  • Ravindra Kumar

    Ravindra Kumar - 2015-01-02

    Thanks for reporting this issue. DEPRECATED macro will be removed in next update of open-vm-tools.

     
  • Ravindra Kumar

    Ravindra Kumar - 2015-07-09

    Could you please check this with latest release of open-vm-tools 9.10.2?

     
  • Ravindra Kumar

    Ravindra Kumar - 2015-07-09
    • status: open --> open-fixed
     

Log in to post a comment.