open-vm-tools-devel — List for open-vm-tools developer discussions.

[open-vm-tools-devel] [ open-vm-tools-Tracker-2064471 ] FEATURE:control vm recording by toolbox

[SourceForge.net <no...@so...>]

Tracker item #2064471, was opened at 2008-08-21 18:41
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2064471&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: toolbox
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: ven (ven9)
Assigned to: Nobody/Anonymous (nobody)
Summary: FEATURE:control vm recording by toolbox

Initial Comment:
A patch that affects both vmware-toolbox and vmware-toolbox-cmd, adding start/stop recording functionalities for them. It adds a new GuestApp routine, through vmware backdoor, to do it, a new panel for toolbox and a new command for toolbox-cmd as UI.
This patch is based on 2008.08.08 release. I have already posted a version in devel mailing list, now I submit to tracker for simpler tracking.
Thanks to Adar's review. More comments are welcomed.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2064471&group_id=204462

Re: [open-vm-tools-devel] Idea to add start/stop recording feature for toolbox

[Adar D. <ad...@vm...>]

> I have tried to fix the problems in this new patch. Thank you for the
> review.

Thanks, this looks very good. I appreciate your diligence with our coding standard; it's certainly not easy to pick up a new one.

Here is an additional round of comments:
- Can GuestApp_ControlRecord return a Bool indicating the success or failure of the operation? That is, can bp.out.ax.halfs.low be interpreted by the function itself as success or failure so that the caller need not?
- We should probably require root for these new commands. That involves setting the third argument in the command table (toolbox-cmd.c) to TRUE instead of FALSE for the command line toolbox, and adding a geteuid check in toolboxRecord.c (see toolboxScripts.c or toolboxShrink.c for an example).
- The function header for RecordHelp still says "StatHelp" and refers to the stat command.
- Since Record_OnStart and Record_OnStop are static functions, they shouldn't have underscores in their names (we use underscore to show that a function is "public" or "exported", depending on the context).
- When declaring a pointer type, separate the type and the asterisk with a space. So "GtkWidget*" should be "GtkWidget *" (near Record_Create).
- There should be two empty lines separating functions (toolboxRecord.c and toolboxcmdRecord.c).
- In Record_StopRecording's function header, "proccess," --> "process.".

> The agreement, however, puzzles me a little. Date seems not suitable
> for the first blank according to the preceded text, but I can find no
> more phrase for that.

I think the first and second blanks are for the month+day and year respectively. So if you signed the agreement today, the first line would look like this:

This Contributor Agreement (the "Agreement") effective as of August 20th, 2008 by and between...

Does that help clarify it?

Re: [open-vm-tools-devel] Idea to add start/stop recording feature for toolbox

[Yiwen Z. <zha...@gm...>]

On 8/18/08, Adar Dembo <ad...@vm...> wrote:
>
> > This is my patch for 2008.08.08 release. This patch adds a
> > simple "Record" panel to vmware-toolbox and "record" command
> > to vmware-toolbox-cmd.
> > I configured the build by "--without-procps --disable-unity",
> >  since I didn't install the two packages.
> > I have tested the patch on rhel5, suse10 and ubuntu7.04.
>
> Thanks! I haven't reviewed the entire patch yet, but here are some
> suggestions to get started:
> - Please clean up your patch and make it conform to the open-vm-tools
> coding style. You can see the coding style here:
> http://open-vm-tools.wiki.sourceforge.net/CodingStandards. If something is
> unclear or ambiguous, feel free to ask. Some specific things I immediately
> noticed:
> - Configure  your editor to use levels of indentation sized to 3 spaces.
> - No tabs; use an appropriate number of spaces instead.
> - Continuation lines should obey the nesting of parenthesization.
> - All arguments to new functions should have comment annotations next to
> them (such as IN, OUT, or IN/OUT).
> - New copyright preambles should be dated to 2008.
> - The second line in the RecordCommand function header's "Side effects"
> section needs more indentation.


Thank you for your comment. I will double check.

- I gather that you're familiar with the subcommands of the
> BDOOR_CMD_STATELOGGER backdoor command through working with internal
> engineers? I'm going to try and get the actual header documenting the
> commands released so that you need not hard-code the values 1 and 2 in calls
> to Record_Control.
> - I think Record_Control should actually be in lib/guestApp/guestApp.c, not
> in toolboxcmd-record.c. I'd rather that the GTK toolbox didn't depend on any
> toolboxcmd* files, since the toolbox* and toolboxcmd* group of files can be
> considered to be separate UI front-ends to a shared back-end.


This is the point. I was trying to give it a proper place but I was not sure
which lib it should be. Thanks.

> I get the contribution agreement document, but I am not sure
> > if paper form or electronic form is required.
>
> The agreement should be faxed or scanned and e-mailed.
> http://open-vm-tools.sourceforge.net/contribute.php has more information;
> choose whichever method is more convenient for you, and let me know if
> neither are doable and we can work something else out.
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> Build the coolest Linux based applications with Moblin SDK & win great
> prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> open-vm-tools-devel mailing list
> ope...@li...
> https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
>

Re: [open-vm-tools-devel] Idea to add start/stop recording feature for toolbox

[Adar D. <ad...@vm...>]

> This is my patch for 2008.08.08 release. This patch adds a
> simple "Record" panel to vmware-toolbox and "record" command
> to vmware-toolbox-cmd.
> I configured the build by "--without-procps --disable-unity",
>  since I didn't install the two packages.
> I have tested the patch on rhel5, suse10 and ubuntu7.04.

Thanks! I haven't reviewed the entire patch yet, but here are some suggestions to get started:
- Please clean up your patch and make it conform to the open-vm-tools coding style. You can see the coding style here: http://open-vm-tools.wiki.sourceforge.net/CodingStandards. If something is unclear or ambiguous, feel free to ask. Some specific things I immediately noticed:
  - Configure  your editor to use levels of indentation sized to 3 spaces.
  - No tabs; use an appropriate number of spaces instead.
  - Continuation lines should obey the nesting of parenthesization.
  - All arguments to new functions should have comment annotations next to them (such as IN, OUT, or IN/OUT).
  - New copyright preambles should be dated to 2008.
- The second line in the RecordCommand function header's "Side effects" section needs more indentation.
- I gather that you're familiar with the subcommands of the BDOOR_CMD_STATELOGGER backdoor command through working with internal engineers? I'm going to try and get the actual header documenting the commands released so that you need not hard-code the values 1 and 2 in calls to Record_Control.
- I think Record_Control should actually be in lib/guestApp/guestApp.c, not in toolboxcmd-record.c. I'd rather that the GTK toolbox didn't depend on any toolboxcmd* files, since the toolbox* and toolboxcmd* group of files can be considered to be separate UI front-ends to a shared back-end.

> I get the contribution agreement document, but I am not sure
> if paper form or electronic form is required.

The agreement should be faxed or scanned and e-mailed. http://open-vm-tools.sourceforge.net/contribute.php has more information; choose whichever method is more convenient for you, and let me know if neither are doable and we can work something else out.

[open-vm-tools-devel] [ open-vm-tools-Tracker-2048423 ] Build fails on Fedora 9 and Ubuntu Intrepid Ibex

[SourceForge.net <no...@so...>]

Tracker item #2048423, was opened at 2008-08-12 12:35
Message generated for change (Comment added) made by adembo
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Charles (travalas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Build fails on Fedora 9 and Ubuntu Intrepid Ibex

Initial Comment:
configure options:  --without-unity (because uri is backlevel i think)



gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\ 2008.08.08-109361\" -DPACKAGE_BUGREPORT=\"ope...@li...\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.   -DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/open-vm-tools-2008.08.08-109361/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include -I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT guestInfoPosix.o -MD -MP -MF .deps/guestInfoPosix.Tpo -c -o guestInfoPosix.o guestInfoPosix.c
cc1: warnings being treated as errors
guestInfoPosix.c: In function ‘ReadInterfaceDetails’:
guestInfoPosix.c:203: error: format not a string literal and no format arguments
make[2]: *** [guestInfoPosix.o] Error 1
make[2]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib'
make: *** [all-recursive] Error 1



----------------------------------------------------------------------

>Comment By: Adar Dembo (adembo)
Date: 2008-08-17 21:32

Message:
Logged In: YES 
user_id=1867590
Originator: NO

I answered my own question: it is the only problem. The patch I wrote is
very similar to yours, but it also frees ctmp if Posix_RealPath succeeds
and if the second chdir fails. I've committed it to the git repository.
File Added: appUtilX11_new.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-17 20:40

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're right; I didn't try building with Unity enabled because the
uriparser in Intrepid is still too old. Was this the only problem?

I'll build uriparser from source, do a full build of open-vm-tools on
Intrepid with Unity, and post something comprehensive.

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-15 19:36

Message:
Logged In: YES 
user_id=2178601
Originator: YES

I think if you build with unity you also need to do something like in
appUtilX11.patch
File Added: appUtilX11.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-15 16:04

Message:
Logged In: YES 
user_id=1867590
Originator: NO

I made a mistake in intrepid.patch. Here's another patch that you should
apply on top to get the correct runtime behavior (the original patch
compiles successfully).

Both patches were committed to the git repository.
File Added: intrepid2.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-15 09:47

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yep looks good. Thanks!

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-14 22:25

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Here, give these patches a shot. If it works, I'll put it in the next code
refresh.
File Added: intrepid.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-14 19:41

Message:
Logged In: YES 
user_id=1867590
Originator: NO

For what it's worth, I built an Intrepid VM, ran through the open-vm-tools
compilation, and fixed all the errors. I'll post the patches later.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 11:35

Message:
Logged In: YES 
user_id=1867590
Originator: NO

It seems sane to me. Posix_Printf is intended to wrap the standard printf
function such that you can pass a set of UTF-8 encoded formatted arguments
into it (the ConstUnicode type is intended to represent UTF-8 encoded
strings), and it will firstly convert those arguments to a single string
encoded in the process's current encoding and secondly call the regular
printf on it.

The problem appears to be that printf is being called directly on a
string, which can actually lead to formatting string vulnerabilities (and
it appears that the compiler is sensitive to such vulnerabilities now). The
fix would be to change the printf(outCurr) call to printf("%s", outCurr).

As I said in an earlier comment, I'm going to hold off generating a patch
for this so that I can do something more comprehensive for Intrepid. If you
feel up to the task, feel free to patch these problems and I'll commit your
patches, provided you can sign the open-vm-tools contribution agreement.

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-13 07:12

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yes I am using the git repository.  

I applied that patch, but it still blows up.

cc1: warnings being treated as errors
../posixPosix.c: In function 'Posix_Printf':
../posixPosix.c:2984: error: format not a string literal and no format
arguments

I'm trying to get better at C and I was curious is that Posix_Printf
function really doing what it says it's doing?  BTW Thanks for your help in
this!


----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:27

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're using the git repository, right?

Some of our modules ship our real includeCheck.h file while others simply
touch an empty version of that file at build-time (there's no good reason
for this inconsistency). Looks like vsock is the latter, and although
includeCheck.h exists in the tarball I uploaded to SF, when I patched the
git repository it dropped the file, presumably because it was empty.

I recreated the empty file, and it seems to have worked this time.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:09

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, here's the patch for guestInfoPerfMonLinux.c.

If there's another such issue (and I imagine there is, if the compiler
flags on Intrepid now warn about not checking certain return values), I'll
stop generating one-off patches, build an Intrepid VM, get the
open-vm-tools building in it, and publish something more comprehensive.
File Added: guestInfoPerfMonLinux.c.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 19:33

Message:
Logged In: YES 
user_id=2178601
Originator: YES

on Fedora 9 
it borks with 
  CC [M] 
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.o
In file included from
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.c:95:
/home/nathan/code/open-vm-tools/modules/linux/vsock/./include/driver-config.h:33:26:
error: includeCheck.h: No such file or directory

copying lib/include/includeCheck.h does let it build


----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 18:57

Message:
Logged In: YES 
user_id=2178601
Originator: YES

looks like that causes it to blow up in a different way on ubuntu, 
haven't tried it on fedora 9 yet.

cc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\
2008.08.08-109361\"
-DPACKAGE_BUGREPORT=\"ope...@li...\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.  
-DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38
-DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/code/open-vm-tools/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include
-I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value
-fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT
guestInfoPerfMonLinux.o -MD -MP -MF .deps/guestInfoPerfMonLinux.Tpo -c -o
guestInfoPerfMonLinux.o guestInfoPerfMonLinux.c
cc1: warnings being treated as errors
guestInfoPerfMonLinux.c: In function ‘GuestInfoMonitorReadMeminfo’:
guestInfoPerfMonLinux.c:183: error: ignoring return value of ‘fscanf’,
declared with attribute warn_unused_result
make[2]: *** [guestInfoPerfMonLinux.o] Error 1
make[2]: Leaving directory
`/home/nathan/code/open-vm-tools/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/code/open-vm-tools/lib'
make: *** [all-recursive] Error 1

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:14

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Whoops, looks like I accidentally changed the summary back.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:13

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Doesn't look like this is a regression; that call to Str_Sprintf has been
there for some time.

In any case, does this patch fix the problem for you?

File Added: a.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

[open-vm-tools-devel] [ open-vm-tools-Tracker-2048423 ] Build fails on Fedora 9 and Ubuntu Intrepid Ibex

[SourceForge.net <no...@so...>]

Tracker item #2048423, was opened at 2008-08-12 12:35
Message generated for change (Comment added) made by adembo
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Charles (travalas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Build fails on Fedora 9 and Ubuntu Intrepid Ibex

Initial Comment:
configure options:  --without-unity (because uri is backlevel i think)



gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\ 2008.08.08-109361\" -DPACKAGE_BUGREPORT=\"ope...@li...\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.   -DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/open-vm-tools-2008.08.08-109361/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include -I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT guestInfoPosix.o -MD -MP -MF .deps/guestInfoPosix.Tpo -c -o guestInfoPosix.o guestInfoPosix.c
cc1: warnings being treated as errors
guestInfoPosix.c: In function ReadInterfaceDetails:
guestInfoPosix.c:203: error: format not a string literal and no format arguments
make[2]: *** [guestInfoPosix.o] Error 1
make[2]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib'
make: *** [all-recursive] Error 1



----------------------------------------------------------------------

>Comment By: Adar Dembo (adembo)
Date: 2008-08-17 20:40

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're right; I didn't try building with Unity enabled because the
uriparser in Intrepid is still too old. Was this the only problem?

I'll build uriparser from source, do a full build of open-vm-tools on
Intrepid with Unity, and post something comprehensive.

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-15 19:36

Message:
Logged In: YES 
user_id=2178601
Originator: YES

I think if you build with unity you also need to do something like in
appUtilX11.patch
File Added: appUtilX11.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-15 16:04

Message:
Logged In: YES 
user_id=1867590
Originator: NO

I made a mistake in intrepid.patch. Here's another patch that you should
apply on top to get the correct runtime behavior (the original patch
compiles successfully).

Both patches were committed to the git repository.
File Added: intrepid2.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-15 09:47

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yep looks good. Thanks!

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-14 22:25

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Here, give these patches a shot. If it works, I'll put it in the next code
refresh.
File Added: intrepid.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-14 19:41

Message:
Logged In: YES 
user_id=1867590
Originator: NO

For what it's worth, I built an Intrepid VM, ran through the open-vm-tools
compilation, and fixed all the errors. I'll post the patches later.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 11:35

Message:
Logged In: YES 
user_id=1867590
Originator: NO

It seems sane to me. Posix_Printf is intended to wrap the standard printf
function such that you can pass a set of UTF-8 encoded formatted arguments
into it (the ConstUnicode type is intended to represent UTF-8 encoded
strings), and it will firstly convert those arguments to a single string
encoded in the process's current encoding and secondly call the regular
printf on it.

The problem appears to be that printf is being called directly on a
string, which can actually lead to formatting string vulnerabilities (and
it appears that the compiler is sensitive to such vulnerabilities now). The
fix would be to change the printf(outCurr) call to printf("%s", outCurr).

As I said in an earlier comment, I'm going to hold off generating a patch
for this so that I can do something more comprehensive for Intrepid. If you
feel up to the task, feel free to patch these problems and I'll commit your
patches, provided you can sign the open-vm-tools contribution agreement.

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-13 07:12

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yes I am using the git repository.  

I applied that patch, but it still blows up.

cc1: warnings being treated as errors
../posixPosix.c: In function 'Posix_Printf':
../posixPosix.c:2984: error: format not a string literal and no format
arguments

I'm trying to get better at C and I was curious is that Posix_Printf
function really doing what it says it's doing?  BTW Thanks for your help in
this!


----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:27

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're using the git repository, right?

Some of our modules ship our real includeCheck.h file while others simply
touch an empty version of that file at build-time (there's no good reason
for this inconsistency). Looks like vsock is the latter, and although
includeCheck.h exists in the tarball I uploaded to SF, when I patched the
git repository it dropped the file, presumably because it was empty.

I recreated the empty file, and it seems to have worked this time.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:09

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, here's the patch for guestInfoPerfMonLinux.c.

If there's another such issue (and I imagine there is, if the compiler
flags on Intrepid now warn about not checking certain return values), I'll
stop generating one-off patches, build an Intrepid VM, get the
open-vm-tools building in it, and publish something more comprehensive.
File Added: guestInfoPerfMonLinux.c.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 19:33

Message:
Logged In: YES 
user_id=2178601
Originator: YES

on Fedora 9 
it borks with 
  CC [M] 
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.o
In file included from
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.c:95:
/home/nathan/code/open-vm-tools/modules/linux/vsock/./include/driver-config.h:33:26:
error: includeCheck.h: No such file or directory

copying lib/include/includeCheck.h does let it build


----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 18:57

Message:
Logged In: YES 
user_id=2178601
Originator: YES

looks like that causes it to blow up in a different way on ubuntu, 
haven't tried it on fedora 9 yet.

cc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\
2008.08.08-109361\"
-DPACKAGE_BUGREPORT=\"ope...@li...\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.  
-DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38
-DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/code/open-vm-tools/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include
-I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value
-fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT
guestInfoPerfMonLinux.o -MD -MP -MF .deps/guestInfoPerfMonLinux.Tpo -c -o
guestInfoPerfMonLinux.o guestInfoPerfMonLinux.c
cc1: warnings being treated as errors
guestInfoPerfMonLinux.c: In function GuestInfoMonitorReadMeminfo:
guestInfoPerfMonLinux.c:183: error: ignoring return value of fscanf,
declared with attribute warn_unused_result
make[2]: *** [guestInfoPerfMonLinux.o] Error 1
make[2]: Leaving directory
`/home/nathan/code/open-vm-tools/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/code/open-vm-tools/lib'
make: *** [all-recursive] Error 1

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:14

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Whoops, looks like I accidentally changed the summary back.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:13

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Doesn't look like this is a regression; that call to Str_Sprintf has been
there for some time.

In any case, does this patch fix the problem for you?

File Added: a.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Re: [open-vm-tools-devel] Idea to add start/stop recording feature for toolbox

[Yiwen Z. <zha...@gm...>]

From 1cf55724e08a0773c946e755a4c7eb1ec8f27d2a Mon Sep 17 00:00:00 2001
From: root <root@localhost.localdomain>
Date: Mon, 18 Aug 2008 10:06:32 +0800
Subject: [PATCH] Record control

---
 toolbox/Makefile.am         |    3 +
 toolbox/Makefile.in         |   16 ++++--
 toolbox/toolbox-cmd.c       |   65 ++++++++++++++++++++++-
 toolbox/toolbox-gtk.c       |    4 ++
 toolbox/toolboxCmdInt.h     |    5 ++
 toolbox/toolboxGtkInt.h     |    3 +
 toolbox/toolboxRecord.c     |  126 +++++++++++++++++++++++++++++++++++++++++++
 toolbox/toolboxcmd-record.c |   38 +++++++++++++
 8 files changed, 254 insertions(+), 6 deletions(-)
 create mode 100644 toolbox/toolboxRecord.c
 create mode 100644 toolbox/toolboxcmd-record.c

diff --git a/toolbox/Makefile.am b/toolbox/Makefile.am
index c8e082d..457b870 100644
--- a/toolbox/Makefile.am
+++ b/toolbox/Makefile.am
@@ -63,6 +63,8 @@ if HAVE_X11
    vmware_toolbox_SOURCES += toolboxOptions.c
    vmware_toolbox_SOURCES += toolboxScripts.c
    vmware_toolbox_SOURCES += toolboxShrink.c
+   vmware_toolbox_SOURCES += toolboxRecord.c
+   vmware_toolbox_SOURCES += toolboxcmd-record.c
 
 # Here's something wacky: automake will muck up the translation of this
 # conditional if it is indented. For more details, see:
@@ -106,6 +108,7 @@ vmware_toolbox_cmd_SOURCES += toolboxcmd-scripts.c
 vmware_toolbox_cmd_SOURCES += toolboxcmd-shrink.c
 vmware_toolbox_cmd_SOURCES += toolboxcmd-stat.c
 vmware_toolbox_cmd_SOURCES += toolboxcmd-time.c
+vmware_toolbox_cmd_SOURCES += toolboxcmd-record.c
 
 if HAVE_ICU
    vmware_toolbox_cmd_LDADD += @ICU_LIBS@
diff --git a/toolbox/Makefile.in b/toolbox/Makefile.in
index db516c0..f13a652 100644
--- a/toolbox/Makefile.in
+++ b/toolbox/Makefile.in
@@ -71,13 +71,16 @@ binPROGRAMS_INSTALL = $(INSTALL_PROGRAM)
 PROGRAMS = $(bin_PROGRAMS)
 am__vmware_toolbox_SOURCES_DIST = debugStdio.c toolbox-gtk.c \
 	toolboxAbout.c toolboxDevices.c toolboxOptions.c \
-	toolboxScripts.c toolboxShrink.c
+	toolboxScripts.c toolboxShrink.c toolboxRecord.c \
+	toolboxcmd-record.c
 @HAVE_X11_TRUE@am_vmware_toolbox_OBJECTS = debugStdio.$(OBJEXT) \
 @HAVE_X11_TRUE@	toolbox-gtk.$(OBJEXT) toolboxAbout.$(OBJEXT) \
 @HAVE_X11_TRUE@	toolboxDevices.$(OBJEXT) \
 @HAVE_X11_TRUE@	toolboxOptions.$(OBJEXT) \
 @HAVE_X11_TRUE@	toolboxScripts.$(OBJEXT) \
-@HAVE_X11_TRUE@	toolboxShrink.$(OBJEXT)
+@HAVE_X11_TRUE@	toolboxShrink.$(OBJEXT)  \
+@HAVE_X11_TRUE@ toolboxRecord.$(OBJEXT) \
+@HAVE_X11_TRUE@ toolboxcmd-record.$(OBJEXT)
 vmware_toolbox_OBJECTS = $(am_vmware_toolbox_OBJECTS)
 am__DEPENDENCIES_1 =
 @HAVE_X11_TRUE@vmware_toolbox_DEPENDENCIES =  \
@@ -86,7 +89,8 @@ am__DEPENDENCIES_1 =
 am_vmware_toolbox_cmd_OBJECTS = debugStdio.$(OBJEXT) \
 	toolbox-cmd.$(OBJEXT) toolboxcmd-devices.$(OBJEXT) \
 	toolboxcmd-scripts.$(OBJEXT) toolboxcmd-shrink.$(OBJEXT) \
-	toolboxcmd-stat.$(OBJEXT) toolboxcmd-time.$(OBJEXT)
+	toolboxcmd-stat.$(OBJEXT) toolboxcmd-time.$(OBJEXT) \
+	toolboxcmd-record.$(OBJEXT)
 vmware_toolbox_cmd_OBJECTS = $(am_vmware_toolbox_cmd_OBJECTS)
 vmware_toolbox_cmd_DEPENDENCIES = ../libguestlib/libguestlib.la \
 	../lib/guestInfo/libGuestInfo.a ../lib/guestApp/libGuestApp.a \
@@ -279,7 +283,7 @@ COMMON = ../lib/conf/libConf.a ../lib/eventManager/libEventManager.a \
 @HAVE_X11_TRUE@vmware_toolbox_SOURCES = debugStdio.c toolbox-gtk.c \
 @HAVE_X11_TRUE@	toolboxAbout.c toolboxDevices.c \
 @HAVE_X11_TRUE@	toolboxOptions.c toolboxScripts.c \
-@HAVE_X11_TRUE@	toolboxShrink.c
+@HAVE_X11_TRUE@	toolboxShrink.c toolboxRecord.c toolboxcmd-record.c
 @HAVE_ICU_FALSE@@HAVE_X11_TRUE@vmware_toolbox_LINK = $(LINK)
 @HAVE_ICU_TRUE@@HAVE_X11_TRUE@vmware_toolbox_LINK = $(LIBTOOL) --tag=CXX $(AM_LIBTOOLFLAGS) \
 @HAVE_ICU_TRUE@@HAVE_X11_TRUE@                         $(LIBTOOLFLAGS) --mode=link $(CXX) $(AM_CXXFLAGS) \
@@ -290,7 +294,7 @@ vmware_toolbox_cmd_LDADD = ../libguestlib/libguestlib.la \
 	$(COMMON) $(am__append_3)
 vmware_toolbox_cmd_SOURCES = debugStdio.c toolbox-cmd.c \
 	toolboxcmd-devices.c toolboxcmd-scripts.c toolboxcmd-shrink.c \
-	toolboxcmd-stat.c toolboxcmd-time.c
+	toolboxcmd-stat.c toolboxcmd-time.c toolboxRecord.c
 @HAVE_ICU_FALSE@vmware_toolbox_cmd_LINK = $(LINK)
 @HAVE_ICU_TRUE@vmware_toolbox_cmd_LINK = $(LIBTOOL) --tag=CXX $(AM_LIBTOOLFLAGS) \
 @HAVE_ICU_TRUE@                             $(LIBTOOLFLAGS) --mode=link $(CXX) \
@@ -384,6 +388,8 @@ distclean-compile:
 @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/toolboxcmd-shrink.Po@am__quote@
 @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/toolboxcmd-stat.Po@am__quote@
 @AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/toolboxcmd-time.Po@am__quote@
+@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/toolboxRecord.Po@am__quote@
+@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/toolboxcmd-record.Po@am__quote@
 
 .c.o:
 @am__fastdepCC_TRUE@	$(COMPILE) -MT $@ -MD -MP -MF $(DEPDIR)/$*.Tpo -c -o $@ $<
diff --git a/toolbox/toolbox-cmd.c b/toolbox/toolbox-cmd.c
index 0b4887e..46d8551 100644
--- a/toolbox/toolbox-cmd.c
+++ b/toolbox/toolbox-cmd.c
@@ -71,11 +71,13 @@ static int DiskCommand(char **argv, int argc);
 static int StatCommand(char **argv, int argc);
 static int ScriptCommand(char **argv, int argc);
 static int TimeSyncCommand(char **argv, int argc);
+static int RecordCommand(char **argv, int argc);
 static void DeviceHelp(char *progName);
 static void DiskHelp(char *progName);
 static void ScriptHelp(char *progName);
 static void StatHelp(char *progName);
 static void TimeSyncHelp(char *progName);
+static void RecordHelp(char *progName);
 static void ToolboxCmdHelp(char *progName);
 static const CmdTable * ParseCommand(char **argv, int argc);
 static Bool CheckArgumentLength(char **argv, int argc);
@@ -91,6 +93,7 @@ static const CmdTable commands[] = {
    { "disk", DiskCommand, TRUE, DiskHelp},
    { "stat", StatCommand, FALSE, StatHelp},
    { "device", DeviceCommand, FALSE, DeviceHelp},
+   { "record", RecordCommand, FALSE, RecordHelp},
    { "help", HelpCommand, FALSE, ToolboxCmdHelp},
    { NULL, } };
 
@@ -185,7 +188,8 @@ ToolboxCmdHelp(char *progName)
           "   device\n"
           "   script\n"
           "   disk\n"
-          "   stat\n\n"
+          "   stat\n"
+	  "   record\n\n"
           "For additional information please visit http://www.vmware.com/support/\n\n",
           progName, progName, progName, progName);
 }
@@ -313,6 +317,32 @@ StatHelp(char *progName) // IN: The name of the program obtained from argv[0]
           "   cpulimit: Prints cput limit\n", progName);
 }
 
+/*
+ *-----------------------------------------------------------------------------
+ *
+ * StatHelp --
+ *
+ *      Prints the help for the stat command.
+ *
+ * Results:
+ *      None.
+ *
+ * Side effects:
+ *      None.
+ *
+ *-----------------------------------------------------------------------------
+ */
+
+static void
+RecordHelp(char *progName) // IN: The name of the program obtained from argv[0]
+{
+   printf("record: control recording process inside guest\n"
+	  "Usage: %s record <subcommand>\n\n"
+	  "Subcommands\n"
+	  "   start: start recording\n"
+	  "   stop: stop recording\n", progName);
+}
+
 
 /*
  *-----------------------------------------------------------------------------
@@ -582,7 +612,40 @@ TimeSyncCommand(char **argv, // IN: command line arguments
    return EX_USAGE;
 }
 
+/*
+ *-----------------------------------------------------------------------------
+ *
+ * RecordCommand --
+ *
+ *      Parse and Handle recording commands.
+ *
+ * Results:
+ *      Returns EXIT_SUCCESS on success.
+ *      Returns the appropriate exit code errors.
+ *
+ * Side effects:
+ *      Might start and stop recording, guest os may be suspended
+ *    to wait for the recording panel in host.
+ *
+ *-----------------------------------------------------------------------------
+ */
 
+static int
+RecordCommand(char **argv, // IN: Command line arguments
+              int argc)    // IN: Length of command line argumenst
+{
+   if (CheckArgumentLength(argv, argc)) {
+      if (strcmp(argv[optind], "start") == 0) {
+	 return Record_Control(1);
+      } else if (strcmp(argv[optind], "stop") == 0) {
+   	 return Record_Control(2);
+      } else {
+	 fprintf(stderr, "Unknown subcommand");
+      }
+   }
+   RecordHelp(argv[0]);
+   return EX_USAGE;
+}
 /*
  *-----------------------------------------------------------------------------
  *
diff --git a/toolbox/toolbox-gtk.c b/toolbox/toolbox-gtk.c
index a49bd55..753928f 100644
--- a/toolbox/toolbox-gtk.c
+++ b/toolbox/toolbox-gtk.c
@@ -589,6 +589,8 @@ ToolsMain_Create(void)
                          gtk_label_new_with_mnemonic(TAB_LABEL_SCRIPTS));
    gtk_notebook_append_page(GTK_NOTEBOOK(notebookMain), Shrink_Create(ToolsMain),
                             gtk_label_new_with_mnemonic(TAB_LABEL_SHRINK));
+   gtk_notebook_append_page(GTK_NOTEBOOK(notebookMain), Record_Create(ToolsMain),
+                            gtk_label_new_with_mnemonic(TAB_LABEL_RECORD));
    gtk_notebook_append_page(GTK_NOTEBOOK(notebookMain), About_Create(ToolsMain),
                             gtk_label_new_with_mnemonic(TAB_LABEL_ABOUT));
 #else
@@ -596,6 +598,8 @@ ToolsMain_Create(void)
                          gtk_label_new(TAB_LABEL_SCRIPTS));
    gtk_notebook_append_page(GTK_NOTEBOOK(notebookMain), Shrink_Create(ToolsMain),
                             gtk_label_new(TAB_LABEL_SHRINK));
+   gtk_notebook_append_page(GTK_NOTEBOOK(notebookMain), Record_Create(ToolsMain),
+                            gtk_lable_new(TAB_LABEL_RECORD));
    gtk_notebook_append_page(GTK_NOTEBOOK(notebookMain), About_Create(ToolsMain),
                             gtk_label_new(TAB_LABEL_ABOUT));
 #endif
diff --git a/toolbox/toolboxCmdInt.h b/toolbox/toolboxCmdInt.h
index f3a8f0c..0f4305d 100644
--- a/toolbox/toolboxCmdInt.h
+++ b/toolbox/toolboxCmdInt.h
@@ -80,4 +80,9 @@ int Stat_GetMemorySwapped(void);
 int Stat_GetMemoryLimit(void);
 int Stat_GetMemoryReservation(void);
 
+/*
+ * Record commands
+ */
+int Record_Control(int mode);
+
 #endif /*_TOOLBOX_CMD_H_*/
diff --git a/toolbox/toolboxGtkInt.h b/toolbox/toolboxGtkInt.h
index 3f9c42f..1cb1d78 100644
--- a/toolbox/toolboxGtkInt.h
+++ b/toolbox/toolboxGtkInt.h
@@ -48,12 +48,14 @@
 #define TAB_LABEL_DEVICES "De_vices"
 #define TAB_LABEL_SCRIPTS "Scri_pts"
 #define TAB_LABEL_SHRINK "Shrin_k"
+#define TAB_LABEL_RECORD "_Record"
 #define TAB_LABEL_ABOUT "Abo_ut"
 #else
 #define TAB_LABEL_OPTIONS "Options"
 #define TAB_LABEL_DEVICES "Devices"
 #define TAB_LABEL_SCRIPTS "Scripts"
 #define TAB_LABEL_SHRINK "Shrink"
+#define TAB_LABEL_RECORD "Record"
 #define TAB_LABEL_ABOUT "About"
 #endif
 
@@ -69,6 +71,7 @@ GtkWidget* Devices_Create(GtkWidget* mainWnd);
 GtkWidget* Options_Create(GtkWidget* mainWnd);
 GtkWidget* Scripts_Create(GtkWidget* mainWnd);
 GtkWidget* Shrink_Create(GtkWidget* mainWnd);
+GtkWidget* Record_Create(GtkWidget* mainWnd);
 
 void Options_OnTimeSyncToggled(gpointer btn, gpointer data);
 void Devices_OnDeviceToggled(gpointer btn, gpointer data);
diff --git a/toolbox/toolboxRecord.c b/toolbox/toolboxRecord.c
new file mode 100644
index 0000000..aa381d9
--- /dev/null
+++ b/toolbox/toolboxRecord.c
@@ -0,0 +1,126 @@
+/*********************************************************
+ * Copyright (C) 2005 VMware, Inc. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as published
+ * by the Free Software Foundation version 2.1 and no later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+ * or FITNESS FOR A PARTICULAR PURPOSE.  See the Lesser GNU General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA.
+ *
+ *********************************************************/
+
+/*
+ * toolboxRecord.c --
+ *
+ *     The record tab for the linux gtk toolbox.
+ */
+
+#include "toolboxGtkInt.h"
+#include "toolboxCmdInt.h"
+
+static void Record_OnStart(gpointer, gpointer);
+static void Record_OnStop(gpointer, gpointer);
+
+/*
+ *-----------------------------------------------------------------------------
+ *
+ * Record_Create  --
+ *
+ *      Create, layout, and init the Record tab UI and all its widgets.
+ *
+ * Results:
+ *      The Record tab widget (it's a vbox).
+ *
+ * Side effects:
+ *      None.
+ *
+ *-----------------------------------------------------------------------------
+ */
+GtkWidget*
+Record_Create(GtkWidget* mainWnd)
+{
+   GtkWidget* recordtab;
+   GtkWidget* hbox[2];
+   GtkWidget* startbtn;
+   GtkWidget* stopbtn;
+   recordtab = gtk_vbox_new(FALSE, 50);
+   gtk_widget_show(recordtab);
+   hbox[0] = gtk_hbox_new(FALSE, 10);
+   hbox[1] = gtk_hbox_new(FALSE, 10);
+   gtk_widget_show(hbox[0]);
+   gtk_widget_show(hbox[1]);
+   gtk_box_pack_start(GTK_BOX(recordtab), hbox[0], FALSE, FALSE, 0);
+   gtk_box_pack_start(GTK_BOX(recordtab), hbox[1], FALSE, FALSE, 0);
+#ifdef GTK2
+   startbtn = gtk_button_new_with_mnemonic("Sta_rt");
+   stopbtn = gtk_button_new_with_mnemonic("S_top");
+#else
+   startbtn = gtk_button_new_with_label("Start");
+   stopbtn = gtk_button_new_with_label("Stop");
+#endif
+   gtk_widget_show(startbtn);
+   gtk_box_pack_start(GTK_BOX(hbox[1]), startbtn, FALSE, FALSE, 10);
+   gtk_widget_set_usize(startbtn, 70, 25);
+   gtk_signal_connect(GTK_OBJECT(startbtn), "clicked",
+             	      GTK_SIGNAL_FUNC(Record_OnStart), NULL);
+   gtk_widget_show(stopbtn);
+   gtk_box_pack_end(GTK_BOX(hbox[1]), stopbtn, FALSE, FALSE, 10);
+   gtk_widget_set_usize(stopbtn, 70, 6);
+   gtk_signal_connect(GTK_OBJECT(stopbtn), "clicked",
+		      GTK_SIGNAL_FUNC(Record_OnStop), NULL);
+   return recordtab;
+}
+
+/*
+ *-----------------------------------------------------------------------------
+ *
+ * Record_OnStart --
+ *
+ *      Callback for the gtk signal "clicked" on the Record tab's start
+ *      button. 
+ *
+ * Results:
+ *      None.
+ *
+ * Side effects:
+ *      Host VMware product starts recording this vm.
+ *
+ *-----------------------------------------------------------------------------
+ */
+void
+Record_OnStart(gpointer btn,	// IN: unused
+	       gpointer data)	// IN: unused
+{
+   Record_Control(1);
+}
+
+/*
+ *-----------------------------------------------------------------------------
+ *
+ * Record_OnStop --
+ *
+ *      Callback for the gtk signal "clicked" on the Record tab's stop
+ *      button. 
+ *
+ * Results:
+ *      None.
+ *
+ * Side effects:
+ *      Host VMware product stops recording this vm.
+ *
+ *-----------------------------------------------------------------------------
+ */
+void
+Record_OnStop(gpointer btn,    // IN: unused
+               gpointer data)   // IN: unused
+{
+   Record_Control(2);
+}
+
diff --git a/toolbox/toolboxcmd-record.c b/toolbox/toolboxcmd-record.c
new file mode 100644
index 0000000..cf49eb1
--- /dev/null
+++ b/toolbox/toolboxcmd-record.c
@@ -0,0 +1,54 @@
+/*********************************************************
+ * Copyright (C) 2005 VMware, Inc. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as published
+ * by the Free Software Foundation version 2.1 and no later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+ * or FITNESS FOR A PARTICULAR PURPOSE.  See the Lesser GNU General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA.
+ *
+ *********************************************************/
+
+/*
+ * toolboxRecord.c --
+ *
+ *     Record operations for toolbox command line console.
+ */
+
+#include "toolboxCmdInt.h"
+#include "backdoor.h"
+#include "backdoor_def.h"
+
+/*
+ *-----------------------------------------------------------------------------
+ *
+ * Record_Control --
+ *
+ *      Start or stop recording proccess, flagged by mode. 
+ *	 mode 1 for start and mode 2 for stop.
+ *
+ * Results:
+ *      1 if the call is successful.
+ *
+ * Side effects:
+ *      Host VMware product starts or stops recording this vm.
+ *
+ *-----------------------------------------------------------------------------
+ */
+int
+Record_Control(int mode) // IN: flag of starting or stopping recording
+{
+   Backdoor_proto bp;
+   bp.in.size = mode;
+   bp.in.cx.halfs.low = BDOOR_CMD_STATELOGGER;
+   Backdoor(&bp);
+   return bp.out.ax.halfs.low;
+}
+
-- 
1.5.6.5

[open-vm-tools-devel] [ open-vm-tools-Tracker-2048423 ] Build fails on Fedora 9 and Ubuntu Intrepid Ibex

[SourceForge.net <no...@so...>]

Tracker item #2048423, was opened at 2008-08-12 15:35
Message generated for change (Comment added) made by travalas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Charles (travalas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Build fails on Fedora 9 and Ubuntu Intrepid Ibex

Initial Comment:
configure options:  --without-unity (because uri is backlevel i think)



gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\ 2008.08.08-109361\" -DPACKAGE_BUGREPORT=\"ope...@li...\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.   -DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/open-vm-tools-2008.08.08-109361/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include -I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT guestInfoPosix.o -MD -MP -MF .deps/guestInfoPosix.Tpo -c -o guestInfoPosix.o guestInfoPosix.c
cc1: warnings being treated as errors
guestInfoPosix.c: In function ReadInterfaceDetails:
guestInfoPosix.c:203: error: format not a string literal and no format arguments
make[2]: *** [guestInfoPosix.o] Error 1
make[2]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib'
make: *** [all-recursive] Error 1



----------------------------------------------------------------------

>Comment By: Nathan Charles (travalas)
Date: 2008-08-15 22:36

Message:
Logged In: YES 
user_id=2178601
Originator: YES

I think if you build with unity you also need to do something like in
appUtilX11.patch
File Added: appUtilX11.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-15 19:04

Message:
Logged In: YES 
user_id=1867590
Originator: NO

I made a mistake in intrepid.patch. Here's another patch that you should
apply on top to get the correct runtime behavior (the original patch
compiles successfully).

Both patches were committed to the git repository.
File Added: intrepid2.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-15 12:47

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yep looks good. Thanks!

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-15 01:25

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Here, give these patches a shot. If it works, I'll put it in the next code
refresh.
File Added: intrepid.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-14 22:41

Message:
Logged In: YES 
user_id=1867590
Originator: NO

For what it's worth, I built an Intrepid VM, ran through the open-vm-tools
compilation, and fixed all the errors. I'll post the patches later.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 14:35

Message:
Logged In: YES 
user_id=1867590
Originator: NO

It seems sane to me. Posix_Printf is intended to wrap the standard printf
function such that you can pass a set of UTF-8 encoded formatted arguments
into it (the ConstUnicode type is intended to represent UTF-8 encoded
strings), and it will firstly convert those arguments to a single string
encoded in the process's current encoding and secondly call the regular
printf on it.

The problem appears to be that printf is being called directly on a
string, which can actually lead to formatting string vulnerabilities (and
it appears that the compiler is sensitive to such vulnerabilities now). The
fix would be to change the printf(outCurr) call to printf("%s", outCurr).

As I said in an earlier comment, I'm going to hold off generating a patch
for this so that I can do something more comprehensive for Intrepid. If you
feel up to the task, feel free to patch these problems and I'll commit your
patches, provided you can sign the open-vm-tools contribution agreement.

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-13 10:12

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yes I am using the git repository.  

I applied that patch, but it still blows up.

cc1: warnings being treated as errors
../posixPosix.c: In function 'Posix_Printf':
../posixPosix.c:2984: error: format not a string literal and no format
arguments

I'm trying to get better at C and I was curious is that Posix_Printf
function really doing what it says it's doing?  BTW Thanks for your help in
this!


----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 03:27

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're using the git repository, right?

Some of our modules ship our real includeCheck.h file while others simply
touch an empty version of that file at build-time (there's no good reason
for this inconsistency). Looks like vsock is the latter, and although
includeCheck.h exists in the tarball I uploaded to SF, when I patched the
git repository it dropped the file, presumably because it was empty.

I recreated the empty file, and it seems to have worked this time.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 03:09

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, here's the patch for guestInfoPerfMonLinux.c.

If there's another such issue (and I imagine there is, if the compiler
flags on Intrepid now warn about not checking certain return values), I'll
stop generating one-off patches, build an Intrepid VM, get the
open-vm-tools building in it, and publish something more comprehensive.
File Added: guestInfoPerfMonLinux.c.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 22:33

Message:
Logged In: YES 
user_id=2178601
Originator: YES

on Fedora 9 
it borks with 
  CC [M] 
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.o
In file included from
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.c:95:
/home/nathan/code/open-vm-tools/modules/linux/vsock/./include/driver-config.h:33:26:
error: includeCheck.h: No such file or directory

copying lib/include/includeCheck.h does let it build


----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 21:57

Message:
Logged In: YES 
user_id=2178601
Originator: YES

looks like that causes it to blow up in a different way on ubuntu, 
haven't tried it on fedora 9 yet.

cc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\
2008.08.08-109361\"
-DPACKAGE_BUGREPORT=\"ope...@li...\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.  
-DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38
-DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/code/open-vm-tools/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include
-I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value
-fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT
guestInfoPerfMonLinux.o -MD -MP -MF .deps/guestInfoPerfMonLinux.Tpo -c -o
guestInfoPerfMonLinux.o guestInfoPerfMonLinux.c
cc1: warnings being treated as errors
guestInfoPerfMonLinux.c: In function GuestInfoMonitorReadMeminfo:
guestInfoPerfMonLinux.c:183: error: ignoring return value of fscanf,
declared with attribute warn_unused_result
make[2]: *** [guestInfoPerfMonLinux.o] Error 1
make[2]: Leaving directory
`/home/nathan/code/open-vm-tools/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/code/open-vm-tools/lib'
make: *** [all-recursive] Error 1

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 21:14

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Whoops, looks like I accidentally changed the summary back.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 21:13

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Doesn't look like this is a regression; that call to Str_Sprintf has been
there for some time.

In any case, does this patch fix the problem for you?

File Added: a.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

[open-vm-tools-devel] [ open-vm-tools-Tracker-2048423 ] Build fails on Fedora 9 and Ubuntu Intrepid Ibex

[SourceForge.net <no...@so...>]

Tracker item #2048423, was opened at 2008-08-12 12:35
Message generated for change (Comment added) made by adembo
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Charles (travalas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Build fails on Fedora 9 and Ubuntu Intrepid Ibex

Initial Comment:
configure options:  --without-unity (because uri is backlevel i think)



gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\ 2008.08.08-109361\" -DPACKAGE_BUGREPORT=\"ope...@li...\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.   -DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/open-vm-tools-2008.08.08-109361/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include -I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT guestInfoPosix.o -MD -MP -MF .deps/guestInfoPosix.Tpo -c -o guestInfoPosix.o guestInfoPosix.c
cc1: warnings being treated as errors
guestInfoPosix.c: In function ReadInterfaceDetails:
guestInfoPosix.c:203: error: format not a string literal and no format arguments
make[2]: *** [guestInfoPosix.o] Error 1
make[2]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib'
make: *** [all-recursive] Error 1



----------------------------------------------------------------------

>Comment By: Adar Dembo (adembo)
Date: 2008-08-15 16:04

Message:
Logged In: YES 
user_id=1867590
Originator: NO

I made a mistake in intrepid.patch. Here's another patch that you should
apply on top to get the correct runtime behavior (the original patch
compiles successfully).

Both patches were committed to the git repository.
File Added: intrepid2.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-15 09:47

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yep looks good. Thanks!

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-14 22:25

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Here, give these patches a shot. If it works, I'll put it in the next code
refresh.
File Added: intrepid.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-14 19:41

Message:
Logged In: YES 
user_id=1867590
Originator: NO

For what it's worth, I built an Intrepid VM, ran through the open-vm-tools
compilation, and fixed all the errors. I'll post the patches later.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 11:35

Message:
Logged In: YES 
user_id=1867590
Originator: NO

It seems sane to me. Posix_Printf is intended to wrap the standard printf
function such that you can pass a set of UTF-8 encoded formatted arguments
into it (the ConstUnicode type is intended to represent UTF-8 encoded
strings), and it will firstly convert those arguments to a single string
encoded in the process's current encoding and secondly call the regular
printf on it.

The problem appears to be that printf is being called directly on a
string, which can actually lead to formatting string vulnerabilities (and
it appears that the compiler is sensitive to such vulnerabilities now). The
fix would be to change the printf(outCurr) call to printf("%s", outCurr).

As I said in an earlier comment, I'm going to hold off generating a patch
for this so that I can do something more comprehensive for Intrepid. If you
feel up to the task, feel free to patch these problems and I'll commit your
patches, provided you can sign the open-vm-tools contribution agreement.

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-13 07:12

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yes I am using the git repository.  

I applied that patch, but it still blows up.

cc1: warnings being treated as errors
../posixPosix.c: In function 'Posix_Printf':
../posixPosix.c:2984: error: format not a string literal and no format
arguments

I'm trying to get better at C and I was curious is that Posix_Printf
function really doing what it says it's doing?  BTW Thanks for your help in
this!


----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:27

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're using the git repository, right?

Some of our modules ship our real includeCheck.h file while others simply
touch an empty version of that file at build-time (there's no good reason
for this inconsistency). Looks like vsock is the latter, and although
includeCheck.h exists in the tarball I uploaded to SF, when I patched the
git repository it dropped the file, presumably because it was empty.

I recreated the empty file, and it seems to have worked this time.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:09

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, here's the patch for guestInfoPerfMonLinux.c.

If there's another such issue (and I imagine there is, if the compiler
flags on Intrepid now warn about not checking certain return values), I'll
stop generating one-off patches, build an Intrepid VM, get the
open-vm-tools building in it, and publish something more comprehensive.
File Added: guestInfoPerfMonLinux.c.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 19:33

Message:
Logged In: YES 
user_id=2178601
Originator: YES

on Fedora 9 
it borks with 
  CC [M] 
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.o
In file included from
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.c:95:
/home/nathan/code/open-vm-tools/modules/linux/vsock/./include/driver-config.h:33:26:
error: includeCheck.h: No such file or directory

copying lib/include/includeCheck.h does let it build


----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 18:57

Message:
Logged In: YES 
user_id=2178601
Originator: YES

looks like that causes it to blow up in a different way on ubuntu, 
haven't tried it on fedora 9 yet.

cc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\
2008.08.08-109361\"
-DPACKAGE_BUGREPORT=\"ope...@li...\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.  
-DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38
-DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/code/open-vm-tools/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include
-I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value
-fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT
guestInfoPerfMonLinux.o -MD -MP -MF .deps/guestInfoPerfMonLinux.Tpo -c -o
guestInfoPerfMonLinux.o guestInfoPerfMonLinux.c
cc1: warnings being treated as errors
guestInfoPerfMonLinux.c: In function GuestInfoMonitorReadMeminfo:
guestInfoPerfMonLinux.c:183: error: ignoring return value of fscanf,
declared with attribute warn_unused_result
make[2]: *** [guestInfoPerfMonLinux.o] Error 1
make[2]: Leaving directory
`/home/nathan/code/open-vm-tools/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/code/open-vm-tools/lib'
make: *** [all-recursive] Error 1

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:14

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Whoops, looks like I accidentally changed the summary back.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:13

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Doesn't look like this is a regression; that call to Str_Sprintf has been
there for some time.

In any case, does this patch fix the problem for you?

File Added: a.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Re: [open-vm-tools-devel] Fedora 9 libXinerama library not found during configure

[Nathan C. <nch...@gm...>]

On Fri, Aug 15, 2008 at 4:26 AM, Adar Dembo <ad...@vm...> wrote:
>> That was a good call, I figured out It was actually failing on missing
>> libXext-devel, adding that reported a failure on Xrandr which was
>> actually Xrender-devel.'
>
> Yeah, I should have noticed this in config.log:
> configure:22092: checking for XineramaQueryVersion in -lXinerama
> configure:22127: gcc -o conftest -g -O2  -DUSING_AUTOCONF=1   conftest.c -lXinerama -lXext -lX11   >&5
> /usr/bin/ld: cannot find -lXext
>
> I reordered some of the checks in configure.ac so that:
> - There's a separate check for libXext.
> - The libXrender and libXrandr checks are split up.
> - X_PRE_LIBS and X_EXTRA_LIBS (from AC_PATH_XTRA) are taken into account. They're probably useless for most modern Linux systems, but make the checks more complete.
>
> I'll commit the patch to git.
>
>> configure no succeeds, but I'm getting lots of garbage like,
>>
>>  cd . && /bin/sh /home/nathan/code/open-vm-tools/missing --run
>> automake-1.10 --gnu
>> lib/SLPv2Parser/Makefile.am:18: library used but `RANLIB' is undefined
>> lib/SLPv2Parser/Makefile.am:18:   The usual way to define `RANLIB' is
>> to add `AC_PROG_RANLIB'
>> lib/SLPv2Parser/Makefile.am:18:   to `configure.ac' and run
>> `autoconf' again.
>
> That's strange. We shouldn't need to call AC_PROG_RANLIB because it's not our logic that specifically needs it, it's libtool. And AC_PROG_LIBTOOL will (looking at libtool.m4) call AC_PROG_RANLIB. If you run autoreconf, does the problem go away? Autoreconf should trace through all of configure.ac and understand that AC_PROG_LIBTOOL will provide AC_PROG_RANLIB.
>

I think I broke something by accident.  I recloned the repository and
got back to where i was and now it builds fine.

> If not, please file a bug report so we can track the problem.
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> open-vm-tools-devel mailing list
> ope...@li...
> https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
>



-- 
Nathan Charles

[open-vm-tools-devel] [ open-vm-tools-Tracker-2048423 ] Build fails on Fedora 9 and Ubuntu Intrepid Ibex

[SourceForge.net <no...@so...>]

Tracker item #2048423, was opened at 2008-08-12 15:35
Message generated for change (Comment added) made by travalas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Charles (travalas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Build fails on Fedora 9 and Ubuntu Intrepid Ibex

Initial Comment:
configure options:  --without-unity (because uri is backlevel i think)



gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\ 2008.08.08-109361\" -DPACKAGE_BUGREPORT=\"ope...@li...\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.   -DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/open-vm-tools-2008.08.08-109361/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include -I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT guestInfoPosix.o -MD -MP -MF .deps/guestInfoPosix.Tpo -c -o guestInfoPosix.o guestInfoPosix.c
cc1: warnings being treated as errors
guestInfoPosix.c: In function ReadInterfaceDetails:
guestInfoPosix.c:203: error: format not a string literal and no format arguments
make[2]: *** [guestInfoPosix.o] Error 1
make[2]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib'
make: *** [all-recursive] Error 1



----------------------------------------------------------------------

>Comment By: Nathan Charles (travalas)
Date: 2008-08-15 12:47

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yep looks good. Thanks!

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-15 01:25

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Here, give these patches a shot. If it works, I'll put it in the next code
refresh.
File Added: intrepid.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-14 22:41

Message:
Logged In: YES 
user_id=1867590
Originator: NO

For what it's worth, I built an Intrepid VM, ran through the open-vm-tools
compilation, and fixed all the errors. I'll post the patches later.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 14:35

Message:
Logged In: YES 
user_id=1867590
Originator: NO

It seems sane to me. Posix_Printf is intended to wrap the standard printf
function such that you can pass a set of UTF-8 encoded formatted arguments
into it (the ConstUnicode type is intended to represent UTF-8 encoded
strings), and it will firstly convert those arguments to a single string
encoded in the process's current encoding and secondly call the regular
printf on it.

The problem appears to be that printf is being called directly on a
string, which can actually lead to formatting string vulnerabilities (and
it appears that the compiler is sensitive to such vulnerabilities now). The
fix would be to change the printf(outCurr) call to printf("%s", outCurr).

As I said in an earlier comment, I'm going to hold off generating a patch
for this so that I can do something more comprehensive for Intrepid. If you
feel up to the task, feel free to patch these problems and I'll commit your
patches, provided you can sign the open-vm-tools contribution agreement.

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-13 10:12

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yes I am using the git repository.  

I applied that patch, but it still blows up.

cc1: warnings being treated as errors
../posixPosix.c: In function 'Posix_Printf':
../posixPosix.c:2984: error: format not a string literal and no format
arguments

I'm trying to get better at C and I was curious is that Posix_Printf
function really doing what it says it's doing?  BTW Thanks for your help in
this!


----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 03:27

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're using the git repository, right?

Some of our modules ship our real includeCheck.h file while others simply
touch an empty version of that file at build-time (there's no good reason
for this inconsistency). Looks like vsock is the latter, and although
includeCheck.h exists in the tarball I uploaded to SF, when I patched the
git repository it dropped the file, presumably because it was empty.

I recreated the empty file, and it seems to have worked this time.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 03:09

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, here's the patch for guestInfoPerfMonLinux.c.

If there's another such issue (and I imagine there is, if the compiler
flags on Intrepid now warn about not checking certain return values), I'll
stop generating one-off patches, build an Intrepid VM, get the
open-vm-tools building in it, and publish something more comprehensive.
File Added: guestInfoPerfMonLinux.c.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 22:33

Message:
Logged In: YES 
user_id=2178601
Originator: YES

on Fedora 9 
it borks with 
  CC [M] 
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.o
In file included from
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.c:95:
/home/nathan/code/open-vm-tools/modules/linux/vsock/./include/driver-config.h:33:26:
error: includeCheck.h: No such file or directory

copying lib/include/includeCheck.h does let it build


----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 21:57

Message:
Logged In: YES 
user_id=2178601
Originator: YES

looks like that causes it to blow up in a different way on ubuntu, 
haven't tried it on fedora 9 yet.

cc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\
2008.08.08-109361\"
-DPACKAGE_BUGREPORT=\"ope...@li...\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.  
-DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38
-DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/code/open-vm-tools/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include
-I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value
-fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT
guestInfoPerfMonLinux.o -MD -MP -MF .deps/guestInfoPerfMonLinux.Tpo -c -o
guestInfoPerfMonLinux.o guestInfoPerfMonLinux.c
cc1: warnings being treated as errors
guestInfoPerfMonLinux.c: In function GuestInfoMonitorReadMeminfo:
guestInfoPerfMonLinux.c:183: error: ignoring return value of fscanf,
declared with attribute warn_unused_result
make[2]: *** [guestInfoPerfMonLinux.o] Error 1
make[2]: Leaving directory
`/home/nathan/code/open-vm-tools/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/code/open-vm-tools/lib'
make: *** [all-recursive] Error 1

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 21:14

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Whoops, looks like I accidentally changed the summary back.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 21:13

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Doesn't look like this is a regression; that call to Str_Sprintf has been
there for some time.

In any case, does this patch fix the problem for you?

File Added: a.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Re: [open-vm-tools-devel] Fedora 9 libXinerama library not found during configure

[Adar D. <ad...@vm...>]

> That was a good call, I figured out It was actually failing on missing
> libXext-devel, adding that reported a failure on Xrandr which was
> actually Xrender-devel.'

Yeah, I should have noticed this in config.log:
configure:22092: checking for XineramaQueryVersion in -lXinerama
configure:22127: gcc -o conftest -g -O2  -DUSING_AUTOCONF=1   conftest.c -lXinerama -lXext -lX11   >&5
/usr/bin/ld: cannot find -lXext

I reordered some of the checks in configure.ac so that:
- There's a separate check for libXext.
- The libXrender and libXrandr checks are split up.
- X_PRE_LIBS and X_EXTRA_LIBS (from AC_PATH_XTRA) are taken into account. They're probably useless for most modern Linux systems, but make the checks more complete.

I'll commit the patch to git.

> configure no succeeds, but I'm getting lots of garbage like,
>
>  cd . && /bin/sh /home/nathan/code/open-vm-tools/missing --run
> automake-1.10 --gnu
> lib/SLPv2Parser/Makefile.am:18: library used but `RANLIB' is undefined
> lib/SLPv2Parser/Makefile.am:18:   The usual way to define `RANLIB' is
> to add `AC_PROG_RANLIB'
> lib/SLPv2Parser/Makefile.am:18:   to `configure.ac' and run
> `autoconf' again.

That's strange. We shouldn't need to call AC_PROG_RANLIB because it's not our logic that specifically needs it, it's libtool. And AC_PROG_LIBTOOL will (looking at libtool.m4) call AC_PROG_RANLIB. If you run autoreconf, does the problem go away? Autoreconf should trace through all of configure.ac and understand that AC_PROG_LIBTOOL will provide AC_PROG_RANLIB.

If not, please file a bug report so we can track the problem.

Re: [open-vm-tools-devel] Fedora 9 libXinerama library not found during configure

[Nathan C. <nch...@gm...>]

On Thu, Aug 14, 2008 at 9:32 PM, Adar Dembo <ad...@vm...> wrote:
>> 1.) here is the config.log
>> http://char1es.net/config.log
>
> That's quite a prolific set of arguments passed to ./configure. Out of curiosity, why so many?
>
They must be defaults because I didn't pass all of them.

>> 2.) here are the files it installs
>> nathan@fedoravm open-vm-tools]$ rpm -lq libXinerama libXinerama-devel
>> /usr/lib/libXinerama.so.1
>> /usr/lib/libXinerama.so.1.0.0
>> /usr/share/doc/libXinerama-1.0.3
>> /usr/share/doc/libXinerama-1.0.3/AUTHORS
>> /usr/share/doc/libXinerama-1.0.3/COPYING
>> /usr/share/doc/libXinerama-1.0.3/ChangeLog
>> /usr/share/doc/libXinerama-1.0.3/README
>> /usr/lib/libXinerama.so
>> /usr/lib/pkgconfig/xinerama.pc
>> /usr/share/man/man3/Xinerama.3.gz
>> /usr/share/man/man3/XineramaIsActive.3.gz
>> /usr/share/man/man3/XineramaQueryExtension.3.gz
>> /usr/share/man/man3/XineramaQueryScreens.3.gz
>> /usr/share/man/man3/XineramaQueryVersion.3.gz
>
> My libXinerama-dev package (Debian unstable) also includes /usr/lib/libXinerama.a, but configure checks both the shared object and the archive (preferring the shared object) for symbols, so that shouldn't be an issue. Are all the libXinerama.so* files/links set up correctly? No permission issues there?
>
> Another thing to check is gcc's search directories. Run gcc with the -print-search-dirs argument and make sure that /usr/lib (or some path to it) is present in "libraries".
>
> If that doesn't lead anywhere, try running ./configure under strace ("strace -f -o strace.log ./configure") and see what file IO is performed when accessing libXinerama, and why it might be failing.
That was a good call, I figured out It was actually failing on missing
libXext-devel, adding that reported a failure on Xrandr which was
actually Xrender-devel.'

configure no succeeds, but I'm getting lots of garbage like,

 cd . && /bin/sh /home/nathan/code/open-vm-tools/missing --run
automake-1.10 --gnu
lib/SLPv2Parser/Makefile.am:18: library used but `RANLIB' is undefined
lib/SLPv2Parser/Makefile.am:18:   The usual way to define `RANLIB' is
to add `AC_PROG_RANLIB'
lib/SLPv2Parser/Makefile.am:18:   to `configure.ac' and run `autoconf' again.


> Lastly, I could modify the libXinerama check to make use of the pkg-config file that ships with libXinerama-devel (/usr/lib/pkgconfig/xinerama.pc). Does yours reference "-L/usr/lib" (or some variant of /usr/lib including variables enclosed within braces) in "Libs"?
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> open-vm-tools-devel mailing list
> ope...@li...
> https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
>



-- 
Nathan Charles

[open-vm-tools-devel] [ open-vm-tools-Tracker-2048423 ] Build fails on Fedora 9 and Ubuntu Intrepid Ibex

[SourceForge.net <no...@so...>]

Tracker item #2048423, was opened at 2008-08-12 12:35
Message generated for change (Comment added) made by adembo
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Charles (travalas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Build fails on Fedora 9 and Ubuntu Intrepid Ibex

Initial Comment:
configure options:  --without-unity (because uri is backlevel i think)



gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\ 2008.08.08-109361\" -DPACKAGE_BUGREPORT=\"ope...@li...\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.   -DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/open-vm-tools-2008.08.08-109361/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include -I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT guestInfoPosix.o -MD -MP -MF .deps/guestInfoPosix.Tpo -c -o guestInfoPosix.o guestInfoPosix.c
cc1: warnings being treated as errors
guestInfoPosix.c: In function ReadInterfaceDetails:
guestInfoPosix.c:203: error: format not a string literal and no format arguments
make[2]: *** [guestInfoPosix.o] Error 1
make[2]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib'
make: *** [all-recursive] Error 1



----------------------------------------------------------------------

>Comment By: Adar Dembo (adembo)
Date: 2008-08-14 22:25

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Here, give these patches a shot. If it works, I'll put it in the next code
refresh.
File Added: intrepid.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-14 19:41

Message:
Logged In: YES 
user_id=1867590
Originator: NO

For what it's worth, I built an Intrepid VM, ran through the open-vm-tools
compilation, and fixed all the errors. I'll post the patches later.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 11:35

Message:
Logged In: YES 
user_id=1867590
Originator: NO

It seems sane to me. Posix_Printf is intended to wrap the standard printf
function such that you can pass a set of UTF-8 encoded formatted arguments
into it (the ConstUnicode type is intended to represent UTF-8 encoded
strings), and it will firstly convert those arguments to a single string
encoded in the process's current encoding and secondly call the regular
printf on it.

The problem appears to be that printf is being called directly on a
string, which can actually lead to formatting string vulnerabilities (and
it appears that the compiler is sensitive to such vulnerabilities now). The
fix would be to change the printf(outCurr) call to printf("%s", outCurr).

As I said in an earlier comment, I'm going to hold off generating a patch
for this so that I can do something more comprehensive for Intrepid. If you
feel up to the task, feel free to patch these problems and I'll commit your
patches, provided you can sign the open-vm-tools contribution agreement.

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-13 07:12

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yes I am using the git repository.  

I applied that patch, but it still blows up.

cc1: warnings being treated as errors
../posixPosix.c: In function 'Posix_Printf':
../posixPosix.c:2984: error: format not a string literal and no format
arguments

I'm trying to get better at C and I was curious is that Posix_Printf
function really doing what it says it's doing?  BTW Thanks for your help in
this!


----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:27

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're using the git repository, right?

Some of our modules ship our real includeCheck.h file while others simply
touch an empty version of that file at build-time (there's no good reason
for this inconsistency). Looks like vsock is the latter, and although
includeCheck.h exists in the tarball I uploaded to SF, when I patched the
git repository it dropped the file, presumably because it was empty.

I recreated the empty file, and it seems to have worked this time.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:09

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, here's the patch for guestInfoPerfMonLinux.c.

If there's another such issue (and I imagine there is, if the compiler
flags on Intrepid now warn about not checking certain return values), I'll
stop generating one-off patches, build an Intrepid VM, get the
open-vm-tools building in it, and publish something more comprehensive.
File Added: guestInfoPerfMonLinux.c.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 19:33

Message:
Logged In: YES 
user_id=2178601
Originator: YES

on Fedora 9 
it borks with 
  CC [M] 
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.o
In file included from
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.c:95:
/home/nathan/code/open-vm-tools/modules/linux/vsock/./include/driver-config.h:33:26:
error: includeCheck.h: No such file or directory

copying lib/include/includeCheck.h does let it build


----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 18:57

Message:
Logged In: YES 
user_id=2178601
Originator: YES

looks like that causes it to blow up in a different way on ubuntu, 
haven't tried it on fedora 9 yet.

cc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\
2008.08.08-109361\"
-DPACKAGE_BUGREPORT=\"ope...@li...\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.  
-DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38
-DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/code/open-vm-tools/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include
-I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value
-fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT
guestInfoPerfMonLinux.o -MD -MP -MF .deps/guestInfoPerfMonLinux.Tpo -c -o
guestInfoPerfMonLinux.o guestInfoPerfMonLinux.c
cc1: warnings being treated as errors
guestInfoPerfMonLinux.c: In function GuestInfoMonitorReadMeminfo:
guestInfoPerfMonLinux.c:183: error: ignoring return value of fscanf,
declared with attribute warn_unused_result
make[2]: *** [guestInfoPerfMonLinux.o] Error 1
make[2]: Leaving directory
`/home/nathan/code/open-vm-tools/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/code/open-vm-tools/lib'
make: *** [all-recursive] Error 1

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:14

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Whoops, looks like I accidentally changed the summary back.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:13

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Doesn't look like this is a regression; that call to Str_Sprintf has been
there for some time.

In any case, does this patch fix the problem for you?

File Added: a.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

[open-vm-tools-devel] [ open-vm-tools-Tracker-2048423 ] Build fails on Fedora 9 and Ubuntu Intrepid Ibex

[SourceForge.net <no...@so...>]

Tracker item #2048423, was opened at 2008-08-12 12:35
Message generated for change (Comment added) made by adembo
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Charles (travalas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Build fails on Fedora 9 and Ubuntu Intrepid Ibex

Initial Comment:
configure options:  --without-unity (because uri is backlevel i think)



gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\ 2008.08.08-109361\" -DPACKAGE_BUGREPORT=\"ope...@li...\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.   -DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/open-vm-tools-2008.08.08-109361/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include -I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT guestInfoPosix.o -MD -MP -MF .deps/guestInfoPosix.Tpo -c -o guestInfoPosix.o guestInfoPosix.c
cc1: warnings being treated as errors
guestInfoPosix.c: In function ReadInterfaceDetails:
guestInfoPosix.c:203: error: format not a string literal and no format arguments
make[2]: *** [guestInfoPosix.o] Error 1
make[2]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib'
make: *** [all-recursive] Error 1



----------------------------------------------------------------------

>Comment By: Adar Dembo (adembo)
Date: 2008-08-14 19:41

Message:
Logged In: YES 
user_id=1867590
Originator: NO

For what it's worth, I built an Intrepid VM, ran through the open-vm-tools
compilation, and fixed all the errors. I'll post the patches later.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 11:35

Message:
Logged In: YES 
user_id=1867590
Originator: NO

It seems sane to me. Posix_Printf is intended to wrap the standard printf
function such that you can pass a set of UTF-8 encoded formatted arguments
into it (the ConstUnicode type is intended to represent UTF-8 encoded
strings), and it will firstly convert those arguments to a single string
encoded in the process's current encoding and secondly call the regular
printf on it.

The problem appears to be that printf is being called directly on a
string, which can actually lead to formatting string vulnerabilities (and
it appears that the compiler is sensitive to such vulnerabilities now). The
fix would be to change the printf(outCurr) call to printf("%s", outCurr).

As I said in an earlier comment, I'm going to hold off generating a patch
for this so that I can do something more comprehensive for Intrepid. If you
feel up to the task, feel free to patch these problems and I'll commit your
patches, provided you can sign the open-vm-tools contribution agreement.

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-13 07:12

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yes I am using the git repository.  

I applied that patch, but it still blows up.

cc1: warnings being treated as errors
../posixPosix.c: In function 'Posix_Printf':
../posixPosix.c:2984: error: format not a string literal and no format
arguments

I'm trying to get better at C and I was curious is that Posix_Printf
function really doing what it says it's doing?  BTW Thanks for your help in
this!


----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:27

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're using the git repository, right?

Some of our modules ship our real includeCheck.h file while others simply
touch an empty version of that file at build-time (there's no good reason
for this inconsistency). Looks like vsock is the latter, and although
includeCheck.h exists in the tarball I uploaded to SF, when I patched the
git repository it dropped the file, presumably because it was empty.

I recreated the empty file, and it seems to have worked this time.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:09

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, here's the patch for guestInfoPerfMonLinux.c.

If there's another such issue (and I imagine there is, if the compiler
flags on Intrepid now warn about not checking certain return values), I'll
stop generating one-off patches, build an Intrepid VM, get the
open-vm-tools building in it, and publish something more comprehensive.
File Added: guestInfoPerfMonLinux.c.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 19:33

Message:
Logged In: YES 
user_id=2178601
Originator: YES

on Fedora 9 
it borks with 
  CC [M] 
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.o
In file included from
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.c:95:
/home/nathan/code/open-vm-tools/modules/linux/vsock/./include/driver-config.h:33:26:
error: includeCheck.h: No such file or directory

copying lib/include/includeCheck.h does let it build


----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 18:57

Message:
Logged In: YES 
user_id=2178601
Originator: YES

looks like that causes it to blow up in a different way on ubuntu, 
haven't tried it on fedora 9 yet.

cc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\
2008.08.08-109361\"
-DPACKAGE_BUGREPORT=\"ope...@li...\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.  
-DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38
-DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/code/open-vm-tools/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include
-I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value
-fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT
guestInfoPerfMonLinux.o -MD -MP -MF .deps/guestInfoPerfMonLinux.Tpo -c -o
guestInfoPerfMonLinux.o guestInfoPerfMonLinux.c
cc1: warnings being treated as errors
guestInfoPerfMonLinux.c: In function GuestInfoMonitorReadMeminfo:
guestInfoPerfMonLinux.c:183: error: ignoring return value of fscanf,
declared with attribute warn_unused_result
make[2]: *** [guestInfoPerfMonLinux.o] Error 1
make[2]: Leaving directory
`/home/nathan/code/open-vm-tools/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/code/open-vm-tools/lib'
make: *** [all-recursive] Error 1

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:14

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Whoops, looks like I accidentally changed the summary back.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:13

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Doesn't look like this is a regression; that call to Str_Sprintf has been
there for some time.

In any case, does this patch fix the problem for you?

File Added: a.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Re: [open-vm-tools-devel] Fedora 9 libXinerama library not found during configure

[Adar D. <ad...@vm...>]

> 1.) here is the config.log
> http://char1es.net/config.log

That's quite a prolific set of arguments passed to ./configure. Out of curiosity, why so many?

> 2.) here are the files it installs
> nathan@fedoravm open-vm-tools]$ rpm -lq libXinerama libXinerama-devel
> /usr/lib/libXinerama.so.1
> /usr/lib/libXinerama.so.1.0.0
> /usr/share/doc/libXinerama-1.0.3
> /usr/share/doc/libXinerama-1.0.3/AUTHORS
> /usr/share/doc/libXinerama-1.0.3/COPYING
> /usr/share/doc/libXinerama-1.0.3/ChangeLog
> /usr/share/doc/libXinerama-1.0.3/README
> /usr/lib/libXinerama.so
> /usr/lib/pkgconfig/xinerama.pc
> /usr/share/man/man3/Xinerama.3.gz
> /usr/share/man/man3/XineramaIsActive.3.gz
> /usr/share/man/man3/XineramaQueryExtension.3.gz
> /usr/share/man/man3/XineramaQueryScreens.3.gz
> /usr/share/man/man3/XineramaQueryVersion.3.gz

My libXinerama-dev package (Debian unstable) also includes /usr/lib/libXinerama.a, but configure checks both the shared object and the archive (preferring the shared object) for symbols, so that shouldn't be an issue. Are all the libXinerama.so* files/links set up correctly? No permission issues there?

Another thing to check is gcc's search directories. Run gcc with the -print-search-dirs argument and make sure that /usr/lib (or some path to it) is present in "libraries".

If that doesn't lead anywhere, try running ./configure under strace ("strace -f -o strace.log ./configure") and see what file IO is performed when accessing libXinerama, and why it might be failing.

Lastly, I could modify the libXinerama check to make use of the pkg-config file that ships with libXinerama-devel (/usr/lib/pkgconfig/xinerama.pc). Does yours reference "-L/usr/lib" (or some variant of /usr/lib including variables enclosed within braces) in "Libs"?

Re: [open-vm-tools-devel] Fedora 9 libXinerama library not found during configure

[Nathan C. <nch...@gm...>]

1.) here is the config.log
http://char1es.net/config.log

2.) here are the files it installs
nathan@fedoravm open-vm-tools]$ rpm -lq libXinerama libXinerama-devel
/usr/lib/libXinerama.so.1
/usr/lib/libXinerama.so.1.0.0
/usr/share/doc/libXinerama-1.0.3
/usr/share/doc/libXinerama-1.0.3/AUTHORS
/usr/share/doc/libXinerama-1.0.3/COPYING
/usr/share/doc/libXinerama-1.0.3/ChangeLog
/usr/share/doc/libXinerama-1.0.3/README
/usr/lib/libXinerama.so
/usr/lib/pkgconfig/xinerama.pc
/usr/share/man/man3/Xinerama.3.gz
/usr/share/man/man3/XineramaIsActive.3.gz
/usr/share/man/man3/XineramaQueryExtension.3.gz
/usr/share/man/man3/XineramaQueryScreens.3.gz
/usr/share/man/man3/XineramaQueryVersion.3.gz


On Thu, Aug 14, 2008 at 6:02 PM, Adar Dembo <ad...@vm...> wrote:
>> I'm running a ./configure and it croaks on Xinerama even though it's
>> install.  Anybody have an idea where the issue could be at?
>>
>> checking for XineramaQueryVersion in -lXinerama... no
>> configure: error: libXinerama not found. Please configure without
>> multimon (using --disable-multimon), configure without X11 (using
>> --without-x), or install the libXinerama devel package(s).
>> [nathan@fedoravm open-vm-tools]$ rpm -q libXinerama-devel
>> libXinerama-devel-1.0.3-1.fc9.i386
>
> Interesting. Two questions:
> 1) Can I see your config.log?
> 2) What files did the libXinerama-devel-1.0.3-1.fc9.i386 package install, and where did it put them?
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> open-vm-tools-devel mailing list
> ope...@li...
> https://lists.sourceforge.net/lists/listinfo/open-vm-tools-devel
>



-- 
Nathan Charles
200 Woodcroft Parkway Unit 44B
Durham, NC 27713
USA
http://www.char1es.net
919-949-8895

Re: [open-vm-tools-devel] Fedora 9 libXinerama library not found during configure

[Adar D. <ad...@vm...>]

> I'm running a ./configure and it croaks on Xinerama even though it's
> install.  Anybody have an idea where the issue could be at?
>
> checking for XineramaQueryVersion in -lXinerama... no
> configure: error: libXinerama not found. Please configure without
> multimon (using --disable-multimon), configure without X11 (using
> --without-x), or install the libXinerama devel package(s).
> [nathan@fedoravm open-vm-tools]$ rpm -q libXinerama-devel
> libXinerama-devel-1.0.3-1.fc9.i386

Interesting. Two questions:
1) Can I see your config.log?
2) What files did the libXinerama-devel-1.0.3-1.fc9.i386 package install, and where did it put them?

[open-vm-tools-devel] Fedora 9 libXinerama library not found during configure

[Nathan C. <nch...@gm...>]

I'm running a ./configure and it croaks on Xinerama even though it's
install.  Anybody have an idea where the issue could be at?

checking for XineramaQueryVersion in -lXinerama... no
configure: error: libXinerama not found. Please configure without
multimon (using --disable-multimon), configure without X11 (using
--without-x), or install the libXinerama devel package(s).
[nathan@fedoravm open-vm-tools]$ rpm -q libXinerama-devel
libXinerama-devel-1.0.3-1.fc9.i386


-- 
Nathan Charles

Re: [open-vm-tools-devel] Idea to add start/stop recording feature for toolbox

[Adar D. <ad...@vm...>]

>         I used to work on migrating vassert sdk from windows
> to linux platform, with the help of some internal engineers.
> The latest release of vassert sdk in windows supports start
> and stop recording inside the guest, and I just make the
> upgrade in linux. I think it useful to add a GUI for toolbox
> or some command line tool controlling record process, to the
> open-vm-tools. I have made a private copy based on 2008.07.01
> release, and I am testing it on the latest release as well as
> various platforms. I would be glad to contribute it as a
> patch, do you think it is useful?
>         If so, is there some process to get it done? It seems
> that the tracking system is favoured here, but I am not sure
> if this idea is suitable with it.
>         I am eager to hear your comments.

I think the ability to control the record process would be a great addition to the toolbox, and we'd love to take your contribution. Note that since 2008.08.08 there's also the command line toolbox, so it would likewise be great if you could add support for this feature in both the command line toolbox as well as the graphical toolbox. In terms of code factoring, it would probably be best to add the infrastructure (backdoor commands or whatever) to lib/guestApp, and then implement a gtk pane for the graphical toolbox and a new set of commands in the command line toolbox, both making use of the calls in lib/guestApp.

In terms of the process, I suggest you start by signing our contribution agreement (http://open-vm-tools.sourceforge.net/files/vca.pdf) so we can get that bit of bureaucracy out of the way. After that, it would be best to create some patches that implement your design and send them for review to this mailing list. Please stick to the open-vm-tools coding style, which you can find at http://open-vm-tools.wiki.sourceforge.net/CodingStandards.

[open-vm-tools-devel] [ open-vm-tools-Tracker-2048423 ] Build fails on Fedora 9 and Ubuntu Intrepid Ibex

[SourceForge.net <no...@so...>]

Tracker item #2048423, was opened at 2008-08-12 12:35
Message generated for change (Comment added) made by adembo
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Charles (travalas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Build fails on Fedora 9 and Ubuntu Intrepid Ibex

Initial Comment:
configure options:  --without-unity (because uri is backlevel i think)



gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\ 2008.08.08-109361\" -DPACKAGE_BUGREPORT=\"ope...@li...\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.   -DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/open-vm-tools-2008.08.08-109361/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include -I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT guestInfoPosix.o -MD -MP -MF .deps/guestInfoPosix.Tpo -c -o guestInfoPosix.o guestInfoPosix.c
cc1: warnings being treated as errors
guestInfoPosix.c: In function ReadInterfaceDetails:
guestInfoPosix.c:203: error: format not a string literal and no format arguments
make[2]: *** [guestInfoPosix.o] Error 1
make[2]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib'
make: *** [all-recursive] Error 1



----------------------------------------------------------------------

>Comment By: Adar Dembo (adembo)
Date: 2008-08-13 11:35

Message:
Logged In: YES 
user_id=1867590
Originator: NO

It seems sane to me. Posix_Printf is intended to wrap the standard printf
function such that you can pass a set of UTF-8 encoded formatted arguments
into it (the ConstUnicode type is intended to represent UTF-8 encoded
strings), and it will firstly convert those arguments to a single string
encoded in the process's current encoding and secondly call the regular
printf on it.

The problem appears to be that printf is being called directly on a
string, which can actually lead to formatting string vulnerabilities (and
it appears that the compiler is sensitive to such vulnerabilities now). The
fix would be to change the printf(outCurr) call to printf("%s", outCurr).

As I said in an earlier comment, I'm going to hold off generating a patch
for this so that I can do something more comprehensive for Intrepid. If you
feel up to the task, feel free to patch these problems and I'll commit your
patches, provided you can sign the open-vm-tools contribution agreement.

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-13 07:12

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yes I am using the git repository.  

I applied that patch, but it still blows up.

cc1: warnings being treated as errors
../posixPosix.c: In function 'Posix_Printf':
../posixPosix.c:2984: error: format not a string literal and no format
arguments

I'm trying to get better at C and I was curious is that Posix_Printf
function really doing what it says it's doing?  BTW Thanks for your help in
this!


----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:27

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're using the git repository, right?

Some of our modules ship our real includeCheck.h file while others simply
touch an empty version of that file at build-time (there's no good reason
for this inconsistency). Looks like vsock is the latter, and although
includeCheck.h exists in the tarball I uploaded to SF, when I patched the
git repository it dropped the file, presumably because it was empty.

I recreated the empty file, and it seems to have worked this time.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:09

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, here's the patch for guestInfoPerfMonLinux.c.

If there's another such issue (and I imagine there is, if the compiler
flags on Intrepid now warn about not checking certain return values), I'll
stop generating one-off patches, build an Intrepid VM, get the
open-vm-tools building in it, and publish something more comprehensive.
File Added: guestInfoPerfMonLinux.c.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 19:33

Message:
Logged In: YES 
user_id=2178601
Originator: YES

on Fedora 9 
it borks with 
  CC [M] 
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.o
In file included from
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.c:95:
/home/nathan/code/open-vm-tools/modules/linux/vsock/./include/driver-config.h:33:26:
error: includeCheck.h: No such file or directory

copying lib/include/includeCheck.h does let it build


----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 18:57

Message:
Logged In: YES 
user_id=2178601
Originator: YES

looks like that causes it to blow up in a different way on ubuntu, 
haven't tried it on fedora 9 yet.

cc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\
2008.08.08-109361\"
-DPACKAGE_BUGREPORT=\"ope...@li...\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.  
-DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38
-DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/code/open-vm-tools/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include
-I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value
-fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT
guestInfoPerfMonLinux.o -MD -MP -MF .deps/guestInfoPerfMonLinux.Tpo -c -o
guestInfoPerfMonLinux.o guestInfoPerfMonLinux.c
cc1: warnings being treated as errors
guestInfoPerfMonLinux.c: In function GuestInfoMonitorReadMeminfo:
guestInfoPerfMonLinux.c:183: error: ignoring return value of fscanf,
declared with attribute warn_unused_result
make[2]: *** [guestInfoPerfMonLinux.o] Error 1
make[2]: Leaving directory
`/home/nathan/code/open-vm-tools/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/code/open-vm-tools/lib'
make: *** [all-recursive] Error 1

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:14

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Whoops, looks like I accidentally changed the summary back.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:13

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Doesn't look like this is a regression; that call to Str_Sprintf has been
there for some time.

In any case, does this patch fix the problem for you?

File Added: a.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

[open-vm-tools-devel] [ open-vm-tools-Tracker-2048423 ] Build fails on Fedora 9 and Ubuntu Intrepid Ibex

[SourceForge.net <no...@so...>]

Tracker item #2048423, was opened at 2008-08-12 15:35
Message generated for change (Comment added) made by travalas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Charles (travalas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Build fails on Fedora 9 and Ubuntu Intrepid Ibex

Initial Comment:
configure options:  --without-unity (because uri is backlevel i think)



gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\ 2008.08.08-109361\" -DPACKAGE_BUGREPORT=\"ope...@li...\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.   -DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/open-vm-tools-2008.08.08-109361/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include -I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT guestInfoPosix.o -MD -MP -MF .deps/guestInfoPosix.Tpo -c -o guestInfoPosix.o guestInfoPosix.c
cc1: warnings being treated as errors
guestInfoPosix.c: In function ReadInterfaceDetails:
guestInfoPosix.c:203: error: format not a string literal and no format arguments
make[2]: *** [guestInfoPosix.o] Error 1
make[2]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib'
make: *** [all-recursive] Error 1



----------------------------------------------------------------------

>Comment By: Nathan Charles (travalas)
Date: 2008-08-13 10:12

Message:
Logged In: YES 
user_id=2178601
Originator: YES

Yes I am using the git repository.  

I applied that patch, but it still blows up.

cc1: warnings being treated as errors
../posixPosix.c: In function 'Posix_Printf':
../posixPosix.c:2984: error: format not a string literal and no format
arguments

I'm trying to get better at C and I was curious is that Posix_Printf
function really doing what it says it's doing?  BTW Thanks for your help in
this!


----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 03:27

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're using the git repository, right?

Some of our modules ship our real includeCheck.h file while others simply
touch an empty version of that file at build-time (there's no good reason
for this inconsistency). Looks like vsock is the latter, and although
includeCheck.h exists in the tarball I uploaded to SF, when I patched the
git repository it dropped the file, presumably because it was empty.

I recreated the empty file, and it seems to have worked this time.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 03:09

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, here's the patch for guestInfoPerfMonLinux.c.

If there's another such issue (and I imagine there is, if the compiler
flags on Intrepid now warn about not checking certain return values), I'll
stop generating one-off patches, build an Intrepid VM, get the
open-vm-tools building in it, and publish something more comprehensive.
File Added: guestInfoPerfMonLinux.c.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 22:33

Message:
Logged In: YES 
user_id=2178601
Originator: YES

on Fedora 9 
it borks with 
  CC [M] 
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.o
In file included from
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.c:95:
/home/nathan/code/open-vm-tools/modules/linux/vsock/./include/driver-config.h:33:26:
error: includeCheck.h: No such file or directory

copying lib/include/includeCheck.h does let it build


----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 21:57

Message:
Logged In: YES 
user_id=2178601
Originator: YES

looks like that causes it to blow up in a different way on ubuntu, 
haven't tried it on fedora 9 yet.

cc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\
2008.08.08-109361\"
-DPACKAGE_BUGREPORT=\"ope...@li...\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.  
-DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38
-DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/code/open-vm-tools/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include
-I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value
-fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT
guestInfoPerfMonLinux.o -MD -MP -MF .deps/guestInfoPerfMonLinux.Tpo -c -o
guestInfoPerfMonLinux.o guestInfoPerfMonLinux.c
cc1: warnings being treated as errors
guestInfoPerfMonLinux.c: In function GuestInfoMonitorReadMeminfo:
guestInfoPerfMonLinux.c:183: error: ignoring return value of fscanf,
declared with attribute warn_unused_result
make[2]: *** [guestInfoPerfMonLinux.o] Error 1
make[2]: Leaving directory
`/home/nathan/code/open-vm-tools/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/code/open-vm-tools/lib'
make: *** [all-recursive] Error 1

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 21:14

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Whoops, looks like I accidentally changed the summary back.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 21:13

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Doesn't look like this is a regression; that call to Str_Sprintf has been
there for some time.

In any case, does this patch fix the problem for you?

File Added: a.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

[open-vm-tools-devel] Idea to add start/stop recording feature for toolbox

[Yiwen Z. <zha...@gm...>]

Hi,
        I used to work on migrating vassert sdk from windows to linux
platform, with the help of some internal engineers. The latest release of
vassert sdk in windows supports start and stop recording inside the guest,
and I just make the upgrade in linux. I think it useful to add a GUI for
toolbox or some command line tool controlling record process, to the
open-vm-tools. I have made a private copy based on 2008.07.01 release, and I
am testing it on the latest release as well as various platforms. I would be
glad to contribute it as a patch, do you think it is useful?
        If so, is there some process to get it done? It seems that the
tracking system is favoured here, but I am not sure if this idea is suitable
with it.
        I am eager to hear your comments.
        Thanks,

Yiwen

[open-vm-tools-devel] [ open-vm-tools-Tracker-2046262 ] open-vm-tools-2008.08.08-109361 fails to configure

[SourceForge.net <no...@so...>]

Tracker item #2046262, was opened at 2008-08-11 12:45
Message generated for change (Comment added) made by tgurr
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2046262&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Timo Gurr (tgurr)
Assigned to: Nobody/Anonymous (nobody)
Summary: open-vm-tools-2008.08.08-109361 fails to configure

Initial Comment:
When performing ./configure it bails out with following error message:

checking for GCC flag -Wno-pointer-sign... yes
checking for GCC flag -Wno-unused-value... yes
checking for GCC flag -fno-strict-aliasing... yes
checking for GCC flag -Wno-unknown-pragmas... yes
checking for GCC flag -Wno-uninitialized... yes
configure: error: conditional "am__fastdepCXX" was never defined.
Usually this means the macro was only invoked conditionally.

Using:
gcc-4.3.1
automake-1.10.1

Attached patch fixes the issue for me.

----------------------------------------------------------------------

>Comment By: Timo Gurr (tgurr)
Date: 2008-08-13 12:01

Message:
Logged In: YES 
user_id=1687320
Originator: YES

Worked perfectly, just had to create the missing m4 directory. Thanks for
looking into this, greatly appreciated!

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 09:03

Message:
Logged In: YES 
user_id=1867590
Originator: NO

File Added: configure.ac.patch

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 09:02

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, I've spent a while looking at this and I think I have it figured
out. The reason this problem manifests itself only when you run autoreconf
is because you probably have libtool-2.2 installed in your system.
Internally we build the configure script using libtool-1.5.22, and when I
changed our build to use libtool-2.2, I also saw the same errors.

So I've gone ahead and done three things:
- I've upgraded our internal compile test infrastructure to use
libtool-2.2 instead of libtool-1.5.22, because it fixes a few other issues
and is more cutting edge. This necessitated a few other changes to
configure.ac (which you'll see in the patch I'm uploading).
- I've also made the AC_PROG_CXX check unconditional as you did in your
patch. I looked at how autoconf implements the AC_PROG_CXX macro and saw
that unlike AC_PROG_CC, it does _not_ throw an error if the compiler isn't
found. So it should be safe to have everyone use AC_PROG_CXX, even if they
aren't using libicu.
- To make sure that we actually do have a C++ compiler, I added a call to
AC_CHECK_TOOL on CXX in the case where we're using libicu.

Here's the patch; you'll need to use autoreconf because I'm too lazy to
generate diffs on configure and all the Makefile.in files. Let me know if
it solves the problem.
File Added: Makefile.am.patch

----------------------------------------------------------------------

Comment By: Timo Gurr (tgurr)
Date: 2008-08-12 11:34

Message:
Logged In: YES 
user_id=1687320
Originator: YES

Tarball, because the file was too big to attach in plain/text.
File Added: configure.fail.tar.bz2

----------------------------------------------------------------------

Comment By: Timo Gurr (tgurr)
Date: 2008-08-12 11:29

Message:
Logged In: YES 
user_id=1687320
Originator: YES

File Added: build.log

----------------------------------------------------------------------

Comment By: Timo Gurr (tgurr)
Date: 2008-08-12 11:28

Message:
Logged In: YES 
user_id=1687320
Originator: YES

Attached is my config.log. After reading your comment I also found out
that if I don't force the rebuild of the of the autotools scripts it works
like in your case, I'm also attaching my full build.log and configure.fail
(the autoconf 2.62 regenerated configure script).
File Added: config.log

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-11 21:38

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Hmm, I don't think that patch is correct. If you look further into
configure.ac you'll see that AC_PROG_CXX is already invoked in the case
where icu is enabled. If icu is disabled (which it is in your case) we
shouldn't need the C++ compiler/linker, and so we shouldn't require it for
all open-vm-tools builds. That's why it's surprising to see this failure. 

When I run your ./configure line locally (after removing my /usr/bin/g++
symlink) I don't see this problem. Could you share your config.log file? Is
anyone else experiencing this bug?

----------------------------------------------------------------------

Comment By: Timo Gurr (tgurr)
Date: 2008-08-11 13:01

Message:
Logged In: YES 
user_id=1687320
Originator: YES

Forgot the most important, following ./configure parameters were given:

./configure --prefix=/usr --host=x86_64-pc-linux-gnu
--mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share
--sysconfdir=/etc --localstatedir=/var/lib --without-kernel-modules
--without-icu --without-x --disable-multimon --libdir=/usr/lib64
--build=x86_64-pc-linux-gnu

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2046262&group_id=204462

[open-vm-tools-devel] [ open-vm-tools-Tracker-2048423 ] Build fails on Fedora 9 and Ubuntu Intrepid Ibex

[SourceForge.net <no...@so...>]

Tracker item #2048423, was opened at 2008-08-12 12:35
Message generated for change (Comment added) made by adembo
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nathan Charles (travalas)
Assigned to: Nobody/Anonymous (nobody)
Summary: Build fails on Fedora 9 and Ubuntu Intrepid Ibex

Initial Comment:
configure options:  --without-unity (because uri is backlevel i think)



gcc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\" -DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\ 2008.08.08-109361\" -DPACKAGE_BUGREPORT=\"ope...@li...\" -DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1 -DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1 -DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1 -DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.   -DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38 -DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/open-vm-tools-2008.08.08-109361/lib/include -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include -I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value -fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT guestInfoPosix.o -MD -MP -MF .deps/guestInfoPosix.Tpo -c -o guestInfoPosix.o guestInfoPosix.c
cc1: warnings being treated as errors
guestInfoPosix.c: In function ReadInterfaceDetails:
guestInfoPosix.c:203: error: format not a string literal and no format arguments
make[2]: *** [guestInfoPosix.o] Error 1
make[2]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/open-vm-tools-2008.08.08-109361/lib'
make: *** [all-recursive] Error 1



----------------------------------------------------------------------

>Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:27

Message:
Logged In: YES 
user_id=1867590
Originator: NO

You're using the git repository, right?

Some of our modules ship our real includeCheck.h file while others simply
touch an empty version of that file at build-time (there's no good reason
for this inconsistency). Looks like vsock is the latter, and although
includeCheck.h exists in the tarball I uploaded to SF, when I patched the
git repository it dropped the file, presumably because it was empty.

I recreated the empty file, and it seems to have worked this time.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-13 00:09

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Alright, here's the patch for guestInfoPerfMonLinux.c.

If there's another such issue (and I imagine there is, if the compiler
flags on Intrepid now warn about not checking certain return values), I'll
stop generating one-off patches, build an Intrepid VM, get the
open-vm-tools building in it, and publish something more comprehensive.
File Added: guestInfoPerfMonLinux.c.patch

----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 19:33

Message:
Logged In: YES 
user_id=2178601
Originator: YES

on Fedora 9 
it borks with 
  CC [M] 
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.o
In file included from
/home/nathan/code/open-vm-tools/modules/linux/vsock/linux/af_vsock.c:95:
/home/nathan/code/open-vm-tools/modules/linux/vsock/./include/driver-config.h:33:26:
error: includeCheck.h: No such file or directory

copying lib/include/includeCheck.h does let it build


----------------------------------------------------------------------

Comment By: Nathan Charles (travalas)
Date: 2008-08-12 18:57

Message:
Logged In: YES 
user_id=2178601
Originator: YES

looks like that causes it to blow up in a different way on ubuntu, 
haven't tried it on fedora 9 yet.

cc -DPACKAGE_NAME=\"open-vm-tools\" -DPACKAGE_TARNAME=\"open-vm-tools\"
-DPACKAGE_VERSION=\"2008.08.08-109361\" -DPACKAGE_STRING=\"open-vm-tools\
2008.08.08-109361\"
-DPACKAGE_BUGREPORT=\"ope...@li...\"
-DPACKAGE=\"open-vm-tools\" -DVERSION=\"2008.08.08-109361\"
-DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
-DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1
-DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DHAVE_ECVT=1
-DHAVE_FCVT=1 -DHAVE_CRYPT_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_WCHAR_H=1 -DHAVE_SYS_IO_H=1 -DHAVE_SYS_PARAM_H=1
-DHAVE_SYS_SYSINFO_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_USER_H=1
-DHAVE_SYS_VFS_H=1 -DHAVE_UNWIND_H=1 -DHAVE__BOOL=1 -DHAVE_STDBOOL_H=1
-DHAVE_STRUCT_STAT_ST_RDEV=1 -DTIME_WITH_SYS_TIME=1 -DHAVE_LSEEK=1 -I.  
-DUSING_AUTOCONF=1  -D_REENTRANT -I/usr/include -DUSE_ICU -DHAVE_ICU_38
-DVMX86_TOOLS -DNO_CORE_ICU -I/home/nathan/code/open-vm-tools/lib/include
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -D_XOPEN_SOURCE=500
-D_BSD_SOURCE -D_SVID_SOURCE -I/usr/local/include -I/usr/include
-I../../include -g -O2 -Wall -Werror -Wno-pointer-sign -Wno-unused-value
-fno-strict-aliasing -Wno-unknown-pragmas -Wno-uninitialized -MT
guestInfoPerfMonLinux.o -MD -MP -MF .deps/guestInfoPerfMonLinux.Tpo -c -o
guestInfoPerfMonLinux.o guestInfoPerfMonLinux.c
cc1: warnings being treated as errors
guestInfoPerfMonLinux.c: In function GuestInfoMonitorReadMeminfo:
guestInfoPerfMonLinux.c:183: error: ignoring return value of fscanf,
declared with attribute warn_unused_result
make[2]: *** [guestInfoPerfMonLinux.o] Error 1
make[2]: Leaving directory
`/home/nathan/code/open-vm-tools/lib/guestInfo'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nathan/code/open-vm-tools/lib'
make: *** [all-recursive] Error 1

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:14

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Whoops, looks like I accidentally changed the summary back.

----------------------------------------------------------------------

Comment By: Adar Dembo (adembo)
Date: 2008-08-12 18:13

Message:
Logged In: YES 
user_id=1867590
Originator: NO

Doesn't look like this is a regression; that call to Str_Sprintf has been
there for some time.

In any case, does this patch fix the problem for you?

File Added: a.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=989708&aid=2048423&group_id=204462