Re: [open-vm-tools-devel] Power functions in vmware-guestd

[Elliot L. <el...@vm...>]

On 11/1/07 12:11 PM, "Justin M. Forbes" <jmf...@li...> wrote:

>> In that case, the default scripts would really just do the default
>> fallback.  In other words, the behavior would be the same if the scripts
>> were present or not.  In this case, it would be better to not package
>> the scripts, so that users could replace them without worrying about
>> getting trampled by their package manager, or more importantly, the
>> packaged implementation could be used while packages providing more
>> specific scripts could be packaged elsewhere without file conflicts.
>> 
> 
> Okay, a bit more reading and understanding the code here... I didn't
> realize those are pre/post scripts.  So the issue is that VMware
> Workstation or VMware Server shouldn't complain if guestd replies not
> implemented on those scripts, but no point in changing the client to
> give a fake response either.  It seems most sane to actually add/package
> those scripts and make them check some given dir
> (say /etc/vmware-tools/scripts.d) for the corresponding script and
> execute the script if it exists, exit cleanly if not.  that not only
> keeps the console from erroring or complaining about missing
> functionality, but allows people to package proper shutdown and startup
> scripts if they have any real needs.
> Sorry for the earlier confusion.

Hey Justin,

I believe that the missing scripts were actually an oversight and should be
included in the next open-vm-tools release. Sorry about that!

Right now it looks like the scripts as they'll be shipped either execute
another script directly, or just run a bunch of initscripts (/etc/init.d/*
stuff). At this point, it sounds like you understand more about those
scripts than I do. Are you mainly suggesting that each of the default
scripts look in a scripts.d directory for other scripts to execute?

Best,
-- Elliot