|
From: Justin M. F. <jmf...@li...> - 2007-11-01 15:16:24
|
On Thu, 2007-11-01 at 11:05 -0400, Sean Dilda wrote: > Justin M. Forbes wrote: > > > Aha, after a bit of probing, it seems that it chokes > > when /etc/vmware-tools/poweroff-vm-default is not present instead of > > simply falling back to CONFVAL_HALT_DEFAULT, though I am not sure why it > > works on the second try. I guess the question is, should we include > > default scripts, or just make the code DTRT if the scripts are not > > present. > > > > The right answer is probably to do both. Include the scripts, and make > sure the code DTRT if they're not there. > In that case, the default scripts would really just do the default fallback. In other words, the behavior would be the same if the scripts were present or not. In this case, it would be better to not package the scripts, so that users could replace them without worrying about getting trampled by their package manager, or more importantly, the packaged implementation could be used while packages providing more specific scripts could be packaged elsewhere without file conflicts. Justin |