uClibc compilation - w/ patch

[Károly K. <ka...@gm...>]

Hello,

I'm compiling open-vm-tools-9.4.0-1280544 (stable) with uClibc (using
current buildroot GIT).
Compiling fails with the message:

../lib/misc/.libs/libMisc.a(msgList.o): In function `MsgList_ToString':
msgList.c:(.text+0x688): undefined reference to `MsgFmt_Asprintf'
../lib/misc/.libs/libMisc.a(msgList.o): In function `MsgList_Log':
msgList.c:(.text+0x788): undefined reference to `MsgFmt_Asprintf'

This function can be backtraced to lib/misc/msgfmt.c, and it only compiles
if HAS_BSD_PRINTF was defined.
It looks like that msgList.c has 2 functions referencing back
unconditionally, but they are not used anyway, when the define exist.
If I insert the same #ifdef in msgList.c it compiles uClibc successfully,
my limited tests show that it works afterwards.

I recommend applying the following patch:

--- openvmtools-9.4.0-1280544.orig/lib/misc/msgList.c<->2013-09-23
17:51:10.000000000 +0200
+++ openvmtools-9.4.0-1280544/lib/misc/msgList.c<------>2014-04-03 13:42:
14.138500061 +0200
@@ -487,6 +487,7 @@
    return messages->id;
 }
.
+#ifdef HAS_BSD_PRINTF
.
 /*
  *----------------------------------------------------------------------
@@ -566,6 +567,7 @@
    }
 }
.
+#endif
.
 /*
  *----------------------------------------------------------------------


Best regards,
Karoly